Press Ctrl / CMD + C to copy this to your clipboard.
This post will be reported to the moderators as potential spam to be looked at
Hi, have had a strange thing happen. Essentially i have had a site running for the last couple of months and it used DAMP 2.0 i did have the issue of the image disappearing on the front end, and after reading a few messages decided to upgrade to 2.5. The upgrade went smoothloy enough, well i actually uninstalled 2.0 and then installed 2.5. Once this was done i checked that the datatypes were still correct, however all images seemed to have disappeared from the content.
I decided to go through and re-save all the images (via the media section) once i had done this all the images appeared correctly for the content item .... well they appeared correctly for content items i had not saved since the upgrade, any content item which i did save lost its image. While this in itself is straneg my actual problem now is that i am getting errors in the log file
I am getting this error on every page which has empty DAMP items, so in the above example on node 1092 i can see that there are 2 DAMP items with nothing in them. I have checked through a few nodes and the error appears for each DAMP item that is not filled in ...
Is this expected or have i done something to corrupt my data.
PS am using Umbraco 4.11.4 on IIS7.5 Windows 2008R2, MSSQL2008R2, and have uComponents and FLAM housekeeping installed
Thanks for the info. So when you try to save a node which has a DAMP property that has no items you get this error? Could you please try to debug the issue to give me more info? http://damp.codeplex.com/SourceControl/list/changesets?branch=default
Hi Jeron and thx for the speedy reply, right now the error described above is happening when i simply load a node. I have run a slightly more indepth workflow, reading the umbraco log form the bottom up.
When i load a node (Lancashire -1067) i get the error (4 times), if i then save and publish i do not get any errors, if i do however reload the node i do egt the error again (4 times).
I have been testing this on a live system, so i need to backup the db and files etc, will also get the source code from codeplex and then get you some more information.
Have gotten the LIVE system restored on my local machine ... i scripted the entire db (schema and data) and got the entire Media folder.
At first glance all images appear to have dissappeared from the backoffice DAMP datatype. I then loaded the homepage of the site and the images that get used on that page now appear in the backoffice.
If however i publish a node (whose URL has not been visited) then the image is removed from the DAMP property (ie if i visit the page the image is not shown)
This is proving a bit tricky to debug becuase as soon as you load the page in the front end then the DAMP item in the back office correctly shows the image.
With regard to the error that is beign logged in the umbraco log, from what i can see in DigibizAdvancedMediaPicker.ascx.cs file around line 275 an XDocument is being created based on the ids via the function DigibizMediaHelper.GetXML() if there are no ids then this returns null, and when it sends null to the method ConvertXML(XDocument xmlDocument) it errors.
the full exception is
Exception: Object reference not set to an instance of an object. - StackTrace: at DigibizAdvancedMediaPicker.DigibizAdvancedMediaPicker.ConvertXML(XDocument xmlDocument) in D:\Projects\damp_2.5\DigibizAdvanceMediaPicker\DigibizAdvancedMediaPicker.ascx.cs:line 421
Thanks for the info. I'll try to reproduce it.
Am slowly getting somewhere with the disappearing images.
If I load a node where the image doesn’t appear, debugging though the code the method MediaExists() is returning null because the select count statement is returning 0. Have double checked this in the database and indeed there is no entry in cmsContentXml table for that nodeid.
As soon as I go to the Media section and open the media item in question the item gets added to the cmsContentXml table, am a bit confused as to why the entry isn’t in the database. I have opened a node which is giving this problem and if I check the LIVE database I can find an entry but for some reason the entry does not exist in the DEV database, I have even gone as far as checking the script file I generated and it is present there. So something deleted the entry ....
OK, have found why this is happening ... well I think I have .... I have a tendency to use the http;//YOURDOMAIN/Umbraco/dialogs/republish.aspx?xml=true to republish all content on a site (which I did straight after I ran the db generate script). From the umbraco source I can see that it runs a command SqlHelper.ExecuteNonQuery("delete from cmsContentXml"); before it goes and then gets all the published docs and repopulates the table ..... so have found the delete culprit
I am assuming that the Image XML that gets stored in the cmsContentXml table is generated by DAMP ... do you by any chance have a method that will go and republish all the image XML?
I suppose a longer term fix would be to change the MediaExists method so that if it doesn’t find an entry in the cmsContentXml table, then it double checks against Umbraco and if it finds something it should create the cmsContentXml entry
Hi Jeroen, did you manage to re-create the issue with empty DAMP properties adding entries in the error log.
And does my comments about the disappearing images make sense?
Sorry I didn't have time to look at the issue yet. Probably won't have time until somewhere next week.
Completely understand, thanks for letting me know, your efforts are greatly appreciated.
i have the same disappearing images issue with 2.5.
i had images selected for several nodes. i edited the doctype adding a property using MNTP. the photos in all nodes are gone. no publishing, nothing. they are just gone.
hope you get a fix for this soon.
Hi Fergus if you go to the actual image in the media section, and then reload the cotnent page does it re-appear ?
Asif - yes!, they do.
I have put together a usercontrol that will go through each media item and resave it .... fixes the problem for me right now .... short term solution. if you want the solution/package let me know your emial and i will send it over
Just to help out.
I just updated to 2.5 but havnt uninstalled 2.0 in the first place.
Everything seems to work and the issue your describing is not something im experiencing.
we are running some 4.11.1-4ish
Hi Rasmus and thanks for your comment, i dont think the issue i had was with regard to the upgrade process. I think it was because i ran the republish URL http;//YOURDOMAIN/Umbraco/dialogs/republish.aspx?xml=true which deletes and then recreates all the content xml (but misses out the image xml creation).
So am not actually sure it is a DAMP issue more of an Umbraco issue, i have a work around in place for now but am wiating for Jeroen (or anyone else) to confirm if i am digging around in the right place
Sorry I didn't have time to look at it yet.
Please take your time, i have a temp fix in place already, so if you can update this message as and when that would be good.
I've been doing some testing and I'm able to reproduce this. When you call /Umbraco/dialogs/republish.aspx?xml=true is removes all media items from the cmsContentXml table and doesn't recreate them. Seems to be a bug in Umbraco, but I'll try to add an extra safety check in DAMP for it.
You don't even need to save the media item. Just opening it again already adds it to the cmsContentXml table.
Also created issue for it: http://issues.umbraco.org/issue/U4-1772
Hi Jeroen and thanks for confirming the above issue, i just wasnt 100% sure if this was a DAMP thing or an Umbraco one.
On the topic of the error log entry did you have any luck in confirming it is a bug in DAMP? I am copying my initial findings below.
I haven't looked at that error yet. Will try to have a look today.
thx for your quick response Jeroen
Fixed both issues.
- Added a quickfix for http://issues.umbraco.org/issue/U4-1772
- Fixed the Object reference not set to an instance of an object. on ConvertXml
You can find both changes here: http://damp.codeplex.com/SourceControl/list/changesets?branch=default
Thanks Jeroen have tested it and all is working great now, thanks
I was also getting this problem on v6.0.0. After upgrading to 6.0.2 I haven't been able to replicate it again.
Excuse my ignorance, but how do I apply the quickfix? Will I need to compile the entire project myself, or is there an easier way to get it going?
Thanks in advance!
it should be available in the nightlies for 6.0.3: http://nightly.umbraco.org/
Try the UmbracoCms.6.0.3-build.23.zip download
Thanks for chiming in!
We're working on a rather large website which we'll be launching next week. It's v4.11.5 and I'm not too keen on upgrading the whole shebang this close to launch.
Is there any way I can upgrade just DAMP without having to do a full Umbraco upgrade?
I think DAMP may have been rebuilt with the fix in it (although the version number is still 2.5)
The source code is also available here: http://damp.codeplex.com/SourceControl/list/changesets
Latest release is from January, so I think I'll go ahead and try to get my own build going.
Thanks for your input!
I'll release DAMP 2.6 soon, but for now download the source code from CodePlex and build the solution. You'll need to replace the DigibizAdvancedMediaPicker.dll and DigibizTree.dll files.
I'm also having issues with nodes missing in DAMP. Umbraco 6.1.1, DAMP 2.5.
First screenshot shows in the Media UI, the Library folder has lots of items (subfolders) within.
But using the DAMP control on a content node (2nd screenshot), there's initially a little "expand" triangle to the left of the Library node, but when you click the triangle, it just disappears and doesn't expand the library folder.
You can click the library folder which then lists the contents to the right, but you can't click any of those subfolders to get further descendant nodes.
It also incorrectly lists itself as its own child (there is no library/library folder, first entry should be 1982).
is working on a reply...
Write your reply to:
Image will be uploaded when post is submitted