Jsut a heads up - when debugging/running the website through Visual Studio 2013, you may experience issues with DAMP controls on document types etc. Basically, Browser Link turns
+ "</script></head><body></body></html>";
into
+ "</script></head><body> <!-- Visual Studio Browser Link --> <script type="application/json" id="__browserLink_initializationData"> {"appName":"InternetExplorer"} </script> <script type="text/javascript" src="http://localhost:63769/f68451d207624ba98099dda56bd76b5f/browserLink" async="async"></script> <!-- End Browser Link -->
</body></html>";
I've not come up with a solution just yet other than modifying the source of DAMP...
Ok, so here's what I've done to fix this little bugbear: Change \umbraco\plugins\DigibizAdvancedMediaPicker\DAMPScript.js on line 21 to:
+ "</script></head><body>" + "</body></html>";
It appears that browserlink does some sort of regex insertion inside any body tags it finds, and doesn't care whether they are string literals in javascript or not.
Indeed - however, I find the feature quite nice and don't want to turn it off... hopefully it will be fixed in a not-too-distant update, and we won't have to turn it off or code around it.
Note: you can also turn it off inside Visual Studio (also discussed in that blog post).
Visual Studio Browser Link breaks DAMP
Jsut a heads up - when debugging/running the website through Visual Studio 2013, you may experience issues with DAMP controls on document types etc. Basically, Browser Link turns
into
I've not come up with a solution just yet other than modifying the source of DAMP...
Ok, so here's what I've done to fix this little bugbear: Change \umbraco\plugins\DigibizAdvancedMediaPicker\DAMPScript.js on line 21 to:
It appears that browserlink does some sort of regex insertion inside any body tags it finds, and doesn't care whether they are string literals in javascript or not.
https://github.com/madskristensen/WebEssentials2013/issues/199#issuecomment-28051877
I'm already working on a fix in the source :-)
ah nice!
It is a VS 2013 "feature". You can turn it off in web.config:
<appSettings>
<add key ="vs:EnableBrowserLink" value="false" />
Indeed - however, I find the feature quite nice and don't want to turn it off... hopefully it will be fixed in a not-too-distant update, and we won't have to turn it off or code around it.
Note: you can also turn it off inside Visual Studio (also discussed in that blog post).
- Rob
I've already fixed it. We'll release an update very soon.
Yup, didn't think it was too far away :) good work!
DAMP 2.7 is out with this fix.
Jeroen
is working on a reply...
This forum is in read-only mode while we transition to the new forum.
You can continue this topic on the new forum by tapping the "Continue discussion" link below.