Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Heather Floyd 477 posts 609 karma points MVP c-trib
    May 10, 2019 @ 13:51
    Heather Floyd
    0

    Any Plans for a v8 uEditorNotes?

    Hi guys! I really love this package. Are you planning a port to Umbraco V8? I wouldn't mind helping, but wanted to check in about whether you already have something in the works.

    Thanks!

  • Marc Goodson 916 posts 5949 karma points MVP 4x c-trib
    May 12, 2019 @ 17:09
    Marc Goodson
    101

    Hi Heather

    Yes; it's on a list of things... This enquiry will bump it up the list!

    First issue I encountered was having a rich text editor as a property editor pre-value...

    I'd kind of fudged it in V7 using umbEditor directive...looks like that has all been updated in V8...

    So yes if we can sort that out the rest should be pretty much the same .. (the opening of the pane option will probably be different too... But can see is documented)

    Regards

    Marc

  • Heather Floyd 477 posts 609 karma points MVP c-trib
    May 12, 2019 @ 19:37
    Heather Floyd
    0

    Great news! Let me know if I can assist at all... (Not that I have ever made a custom property editor... )

  • Marc Goodson 916 posts 5949 karma points MVP 4x c-trib
    May 19, 2019 @ 23:42
    Marc Goodson
    0

    Hi Heather

    Be great if you could test this:

    https://our.umbraco.com/FileDownload?id=19565

    and let me know if it works ok in V8 for you.

    Kind regards

    Marc

  • Heather Floyd 477 posts 609 karma points MVP c-trib
    1 week ago
    Heather Floyd
    0

    Sorry it took so long for my response, Marc, but I was finally able to install into a v. 8.1 site today.

    I had no problems setting up the datatypes - worked very smoothly.

    In the Content node, I think the display could use a bit of padding: https://shots.screenr.co/screenr.html?id=o8oiHNB2JfVm

    (this is using the "alert alert-info" class)

    Adding a .5em to the sides of the header and body panels would be sufficient:

    <div ng-show="noteRenderMode=='Collapsible'" class="umb-panel-header-name expanded" ng-class="isCollapsed ? 'collapsed' : 'expanded'" style="   padding: 0 .5em;">
    
    ...
    
    <div ng-bind-html="editorNotes | safe_html" style="padding: 0  .5em;">...</div>
    

    What do you think?

  • Marc Goodson 916 posts 5949 karma points MVP 4x c-trib
    1 week ago
    Marc Goodson
    0

    Hi Heather

    Thanks for taking the time to test, much appreciated!

    It has gone a bit weird form your screenshot!

    I've tried to recreate on a fresh 8.1 (all 8.1s are fresh!!) and I do have padding being picked up on the alert class!

    enter image description here

    I haven't really made any attempt to style the output of the note! as I'm lazy, but in theory there is an editornotes.css file in the app_plugins folder that could be used - or just any additional stylesheet added by a package.manifest file could apply some style rules...

    ... but what i cottoned onto was the core uses or used to use the 'bootstrap' classes for alerts, so if people used them it would automatically pick up the backoffice styling for the relevant umbraco version and sort of look ok...

    in your screenshot though I noticed the collapsible heading 'hello' text is black, and of course you don't have the padding - but both of these styles come from the 'alert' class... so I wonder if there is a typo? in your configuration for the Note CSS class ? or whether that's the bit that's not working correctly...

    so if you have a moment to double double check, that it matches: alert alert-info that would be ace to know.

    enter image description here

    thanks!

    Marc

  • Heather Floyd 477 posts 609 karma points MVP c-trib
    1 week ago
    Heather Floyd
    0

    Marc, #H5YR / #H5IS :-)

    Yes, it was missing the "alert" class!

    Sorry for making you investigate that.

Please Sign in or register to post replies

Write your reply to:

Draft