Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • horsted 65 posts 116 karma points
    Oct 07, 2009 @ 11:46
    horsted
    0

    A few suggestion :-)

    This is a fantasitc and very usefull datatype - thanks alot for sharing!

    I trouble getting your datatype to work, as I couldn't resize or move the crop area after uploading an image. I'm using IE8, and after som fiddling I found out it worked flawless when using the 'Compatibility view', so IE8 imulates IE7 - but it would be nice if the datatype also worked in IE8 :-)

    Also it doesn't seem to work on .png images - when uploading the datatype appears like the standard upload datatype without the crop option/area. It would be even more usefull if it also could crop .png and .gif images...

    In your first screenshot your image cropper appears as 'Terabyte Image Cropper' in  the Render control dropdown, but when I install it appears just as 'Image Cropper', which is the same name as Kenneths 'Image cropper' (which I belive will be a part of 4.1), so naming it 'Terabyte Image Cropper' like in your screen shot will be better i think :-)

    I have really been missing a datatype like this, and (like Kenneths) i hope this will become part of the umbraco core i the future...

    Thanks again!

    Cheers, horsted 

  • Murray Roke 452 posts 839 karma points c-trib
    Oct 07, 2009 @ 23:26
    Murray Roke
    0

    Thanks Horsted,

    IE8: I think the problem you had with IE8 is really a general problem It seems the cropper fails to initialise if the page loads with a different tab open. I have not managed to solve this issue (I'll add it to a known issues list on the project page)

    when you switch to compatibilty mode it probably reloaded the page with that tab open first, so it worked.

    I've tried it just now and this seems to be the case.

    PNG: yes, my image cropping does not have code to save PNG files yet, if you wish you can crop the png into a jpg by altering line 2 in the file:

    /umbraco/plugins/Terabyte/ImageCropper/jquery.ImageCrop.js

    Name: I took the screenshot from the next version in which I have updated the name to "Terabyte Image Cropper". (I'll upload it)

  • Murray Roke 452 posts 839 karma points c-trib
    Oct 07, 2009 @ 23:46
    Murray Roke
    0

    P.S. Here is a quick work-around to the cropper not initialising because the tab is hidden....

    Open the tab with the cropper, Click the 'save' button, this will then re-load and the cropper will initialise.

    If anyone knows how I can hook up an on-tab-changed event give me a yell, and I'll try and fix this problem.

  • horsted 65 posts 116 karma points
    Oct 08, 2009 @ 08:31
    horsted
    0

    Thanks for your response...

    Apparently my IE8 (version 8.0.6001.18813) browser doesn't act as yours :-)

    In compatibilty mode EVERYTHING sems to work fine - even when cropper isn't in first tab.

    In none-compatibilty mode however i can't even get your work-around to work. It seems like the cropper initialise (i can see the lines and handles), but i can't resize or move the croparea. Same senario when cropper is n the first tab...

    Am I the only one having the above problem?

    Would be nice to be able to hook up on the 'on-tab-changed event' - add for v4.1 on codeplex?

    If you plan on developing further on your image cropper I think a nice feature would be to add the 'Box sizeing Method', so it'll be possible to crop larger images in better overview and without too much scrolling...

  • Murray Roke 452 posts 839 karma points c-trib
    Oct 09, 2009 @ 02:58
    Murray Roke
    0

    Box sizing has been implemented, give it a try, let me know if it doesn't work for you.

  • Murray Roke 452 posts 839 karma points c-trib
    Oct 09, 2009 @ 03:51
    Murray Roke
    0

    Previous post should read: box sizing has always been implemented :-) .... and yes, I see your IE8 problem,

    I fixed that  (well, jcrop fixed it) for some reason the version of the jcrop library I put in has reverted. I'll fix that, also it looks like the next version of jcrop implements a feature on my wish list too, so I'll have to upgrade to that at the same time, if you can't wait for the next version, replace the file here

        \umbraco\plugins\Terabyte\ImageCropper\jquery.Jcrop.min.js

    with the latest version of jCrop from deep-liquid

    For future browsers incompatibility issues this is a good place to start :-)

  • horsted 65 posts 116 karma points
    Oct 09, 2009 @ 09:53
    horsted
    0

    heh, didn't check version as I thought it was a new package and the last jCrop update is from april...

    With the replaced jquery.Jcrop.min.js file the cropper works fine in both IE8 and compatibilty mode. I'm not sure where to enter the Box sizeing size in umbraco, but I got it working by hardcoding the size in jquery.ImageCrop.js AND have the

    setSelect: [0, 0, $(imageToCrop).width(), $(imageToCrop).height()]  

    trigger before setting boxWidth and boxHeight.

    Btw, your latest version (0.92) doesn't include the two .dll files, but I just used the ones from 0.91 which work fine...

    I'm so happy to have it working like i hoped it would - thanks for your time!

    Looking forward to your next version :-)

    Have a nice weekend!

  • Murray Roke 452 posts 839 karma points c-trib
    Oct 11, 2009 @ 23:23
    Murray Roke
    0

    The box size is not configured it's calculted to be the size of your browser like so:

    boxWidth: $(imageToCrop).parents(".propertyItem").width(),
    boxHeight: $(window).height(),

    I've also updated the package to include the DLLs and the latest JCrop.

Please Sign in or register to post replies

Write your reply to:

Draft