Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Keith Donnell 82 posts 187 karma points
    Dec 05, 2016 @ 17:26
    Keith Donnell
    0

    Paypal gateway AddressOverride currently hard-coded

    Hey again Rusty,

    Our client wants the shipping address entered in the system to be used, and not allow the customer to change their address in Paypal. In order to do so, the AddressOverride flag needs to be set to "1". In looking at the code, this appears to be hard-coded as "0" @ https://github.com/Merchello/Merchello/blob/26475ff0b4184137c940fe1a23ba21492f7a8345/src/Merchello.Providers/Payment/PayPal/Services/PayPalExpressCheckoutService.cs#L450

    The long-term recommendation would be to move this into some sort of configuration/setting, however is there a work-around for now, aside from pulling down Merchello source and hard-coding this to "1" for this project?

  • Rusty Swayne 1655 posts 4993 karma points c-trib
    Dec 05, 2016 @ 18:37
    Rusty Swayne
    0

    To be honest, I've tried different settings for that property and have not been able to get it to work correctly in the PayPal API. It's on a list to look into and figure out exactly what is going on ... whether it's a bug in Merchello or the PayPal SDK ... dunno.

    Worst case scenario it is a bug in the PayPal SDK that has been resolved in a later version of the dll, which we can't reference due to dependencies we get from Umbraco (thinking of Newtonsoft.Json here).

  • Keith Donnell 82 posts 187 karma points
    Dec 05, 2016 @ 18:56
    Keith Donnell
    0

    Rusty, are you saying that even hard-coding that property to "1" (with the version of the PayPal SDK you are using) doesn't work?

  • Rusty Swayne 1655 posts 4993 karma points c-trib
    Dec 05, 2016 @ 19:43
    Rusty Swayne
    100

    I was saying that, but I just changed it and ran it again and it did indeed disable the address ... so um, awesome (and strange) - positive it was not accepting the value before.

    I'll add a task to make this configurable in version 2.4.0.

  • Keith Donnell 82 posts 187 karma points
    Dec 05, 2016 @ 20:17
    Keith Donnell
    0

    Thanks Rusty. Any idea when 2.4 will be dropping?

  • Rusty Swayne 1655 posts 4993 karma points c-trib
    Dec 05, 2016 @ 20:20
    Rusty Swayne
    1

    It'll be a few weeks yet - I still have quite a bit to do.

    http://issues.merchello.com/youtrack/agiles/76-1/77-76

Please Sign in or register to post replies

Write your reply to:

Draft