Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Rasmus Fjord 675 posts 1566 karma points c-trib
    Jul 11, 2017 @ 09:58
    Rasmus Fjord
    0

    Updated umbraco (7.6.4) and Nested Content (0.2 >> 0.4), with multiple doctypes cannot add anything

    Hey there :)

    So as described i just updated to 7.6.4 and updated NC to 0.4 aswell. Everything seems to work but when i have a NC doctype, with multiple document types as options, it dosnt work when i click the "+" button.

    enter image description here

    So when ive added the package to the grid with DocTypeGridEditor which is also updated. and when we click the plus button nothing happens, there is no issues in the console or the log, and i can see 3 api calls are made:

    enter image description here enter image description here

    I can see an old bug with this is also posted on DTGEs page: https://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor/doc-type-grid-editor-feedback/85329-bug-using-dtge-plus-nested-content-with-multiple-doctypes

  • Lee Kelleher 4020 posts 15802 karma points MVP 13x admin c-trib
    Jul 11, 2017 @ 10:07
    Lee Kelleher
    1

    Hi Rasmus,

    I think it may be to do with the positioning of the Content Type selection modal, (but I haven't tried NC in 7.6.4 yet). As in it's somehow hidden off the screen.

    A few other people have raised an issue about this, and we did a potential fix, (unreleased) ...

    See here: https://github.com/umco/umbraco-nested-content/commit/9884999e65fbf9be5c2cd43c14f52a4302d1baec

    But then a couple of other people had issues with that fix...

    See here: https://github.com/umco/umbraco-nested-content/issues/130#issuecomment-306759636

    So we're unsure on how to resolve it. I guess it's trying to find a happy medium across all of NC's use-cases, (e.g. standard use + inside a DTGE + inside a Vorto + anything else we've not thought of).

    I wish I had more time to investigate and come up with a rock solid solution, alas I currently don't :-( So any help would be hugely appreciated, (not targeting you directly Rasmus, but anyone reading this) :-)

    Cheers,
    - Lee

  • Rasmus Fjord 675 posts 1566 karma points c-trib
    Jul 11, 2017 @ 12:01
    Rasmus Fjord
    2

    Hello Lee

    Awesome that you got back so fast ;)

    hmm I tested your fix, and for me it worked, only thing i did different was also removing these 3 lines from the JS:

      // Position off screen till we are visible and can calculate offset
            $scope.overlayMenu.style.top = -1000;
            $scope.overlayMenu.style.left = -1000;
    

    And

         var offset = el.offsetRelative("#contentwrapper");
    
                $scope.overlayMenu.style.top = (Math.round(wrapper.height() / 2) + offset.top) - Math.round(el.height() / 2);
                $scope.overlayMenu.style.left = (Math.round(wrapper.width() / 2) + offset.left) - Math.round(el.width() / 2);
    

    And it works both inside the grid with DTGE and as a standalone datatype without being put into the grid

    I dont have vorto but here it seems to be good, with all mentioned use cases!

Please Sign in or register to post replies

Write your reply to:

Draft