Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Rodrigo 27 posts 100 karma points
    Apr 27, 2017 @ 16:50
    Rodrigo
    1

    Terratype on a scroll page

    Hi Jonathan,

    This a great package. I have one issue using the terratype datatype on a scrolling page,

    When i scroll to the map on the page and when i click on the mapicon to open the label, nothing happens. The label don't appear.

    If i reload the page scroll to the map and drag the map to another position , the map seems to reposition on center and now the label appears on click.

    I'm using Google Maps V3

    Best Regards,

  • Jonathan Richards 288 posts 1742 karma points MVP
    Apr 28, 2017 @ 08:14
    Jonathan Richards
    0

    Hi Rodrigo,

    I can only apologise, but I think a bug has crept into Terratype, I think I noticed this bug when I was demoing Terratype to 30 odd people the other day at umBristol, and you're the second person to mention it here. I have scheduled to look at this bug this weekend, and I really hope to release a new version with a fix for next week.

    Sorry for this and thank you for reporting it, because it only confirms my growing suspicions.

    Cheers

    Jonathan

  • Rodrigo 27 posts 100 karma points
    Apr 28, 2017 @ 08:49
    Rodrigo
    1

    Ok, Thanks Jonathan

  • Jonathan Richards 288 posts 1742 karma points MVP
    Apr 30, 2017 @ 18:18
    Jonathan Richards
    0

    Terratype 1.0.12 has been released to fix this issue

  • Rodrigo 27 posts 100 karma points
    May 01, 2017 @ 23:27
    Rodrigo
    1

    Hi Jonathan,

    One question, Can i install this package over the last version 1.0.11.? Or do ihave to do anything else.

    Best Regards,

  • Jonathan Richards 288 posts 1742 karma points MVP
    May 02, 2017 @ 08:07
    Jonathan Richards
    0

    Hi Rodrigo,

    Nope, nothing else needs to be done other than install the new package over the old one. Enjoy.

    Cheers

    Jonathan

  • Rodrigo 27 posts 100 karma points
    May 02, 2017 @ 13:35
    Rodrigo
    0

    Hi Jonathan,

    I already updated the package, but the problem still occurs. I also changed clientDependency version to update css and js in app_plugins. Even with the browser in anonymous mode.

    I don´t know if i´m doing something wrong!

    Best Regards,

    Rodrigo

  • Jonathan Richards 288 posts 1742 karma points MVP
    May 02, 2017 @ 13:47
    Jonathan Richards
    0

    Hi Rodrigo,

    The fix for the labels was on line 318 of /App_Plugins/Terratype.GoogleMapsV3/Scripts/Terratype.GoogleMapsV3.Renderer.js and consisted of changing the variable m to mm, as in

    mm.ignoreEvents--;

    I guess you can take a look at this file in your environment and check that you have the fix, otherwise, sadly I'm gonna need some way to recreate your environment to see what is happening. (See here for screenshot)

    • The json of your Terratype map. You get the json by switching on debug mode in Terratype (Its the last option when you are creating a new Terratype Map) and copying the contents of the json textbox.
    • The razor code you are using to render the map. I just need the @Html.Terratype() command you are using with any options.

    Cheers

    Jonathan

  • Rodrigo 27 posts 100 karma points
    May 02, 2017 @ 15:47
    Rodrigo
    0

    Hi Jonathan,

    We solved the question by commenting the line 309 //m.ignoreEvents++;

    Can you tell me how this will effect the plugin.

    Best Regards, Rodrigo

  • Jonathan Richards 288 posts 1742 karma points MVP
    May 02, 2017 @ 16:21
    Jonathan Richards
    0

    It will do superfluous refreshes. eg. will start a second refresh while the first one is still executing. I doubt it will do actual harm, though this is really depends on how Google Maps handles lots of requests to refresh one after another, but might make the map flash if someone is

    • Actively resizing a browser window
    • The map is sitting on a div that is used as a tab or accordion element and it has some sort of animation for smooth transition. eg the Div changes size repetitively over half a second or so.

    I suspect if you want to test the worse case scenario, fire up IE, throw a map on an accordion element from jQuery that has some sort of horizontal animation and see how slow it goes.

    There is a very obscure edge case where they are clicking the map marker to see the label and resizing the browser windows simultaneously, and the label might not appear, but honest who would do that.

    Cheers

Please Sign in or register to post replies

Write your reply to:

Draft