Sign in Register
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Damiaan 442 posts 1302 karma points MVP 6x c-trib
    Nov 05, 2018 @ 22:21
    Damiaan
    0

    Replace UmbracoTemplatePage with UmbracoViewPage

    We had a issue with a PR to the Umbraco Docs.

    The guy, changed an example from

    @Model.GetPropertyValue() to @Model.Content.GetPropertyvalue()

    his edit was wrong because the example started with @inherits UmbracoViewPage (and he did not changed the inherits).

    So a few questions

    1. What should the example use: UmbracoViewPage or UmbracoTemplatePage
    2. If UmbracoTemplatePage will disappear in v8, isn't it better to change the code generation so new Umbraco users (who create views from the backend) get the UmbracoViewPage instaed of UmbracoTemplatePage?
    Copy Link
  • Lars-Erik Aabech 349 posts 1100 karma points MVP 8x c-trib
    Nov 05, 2018 @ 22:58
    Lars-Erik Aabech
    0

    I'd go with UmbracoViewPage<T> 10 out of 10 times in all cases. ;)

    Copy Link
  • Chriztian Steinmeier 2798 posts 8788 karma points MVP 8x admin c-trib
    Nov 06, 2018 @ 00:08
    Chriztian Steinmeier
    1

    1. I'd say it needs to use UmbracoTemplatePage until v8, because that's what Umbraco generates for you. (Even though I prefer UmbracoViewPage myself too)

    2. I think I've asked the same question, but I also seem to remember hearing words like "breaking change"... :)

    /Chriztian

    Copy Link
  • Lars-Erik Aabech 349 posts 1100 karma points MVP 8x c-trib
    Nov 06, 2018 @ 09:29
    Lars-Erik Aabech
    1

    I dunno which page we're talking about, but maybe it's an idea to show both methods on that page, explaining the differences?

    Copy Link
Please Sign in or register to post replies

Write your reply to:

Draft