I have inherited a site which I've had to upgrade as the title suggests. I've resolved most issues, now encrypted all passwords but I continuing to have issues with membership which I seem unable to resolve.

Web.config relevant parts look as follows:

    <authentication mode="Forms">
      <forms name="cpAuthCookie" loginUrl="~/login.aspx" protection="All" path="/" />
    </authentication>

    <!-- Membership Provider -->
    <membership defaultProvider="UmbracoMembershipProvider" userIsOnlineTimeWindow="15">
      <providers>
        <clear />
        <add name="UmbracoMembershipProvider" type="umbraco.providers.members.UmbracoMembershipProvider" enablePasswordRetrieval="false" enablePasswordReset="false" requiresQuestionAndAnswer="false" defaultMemberTypeAlias="RegisteredMember" passwordFormat="Hashed" />
        <add name="UsersMembershipProvider" type="umbraco.providers.UsersMembershipProvider" enablePasswordRetrieval="false" enablePasswordReset="false" requiresQuestionAndAnswer="false" passwordFormat="Hashed" />
      </providers>
    </membership>
    <!-- added by NH to support membership providers in access layer -->
    <roleManager enabled="true" defaultProvider="UmbracoRoleProvider">
      <providers>
        <clear />
        <add name="UmbracoRoleProvider" type="umbraco.providers.members.UmbracoRoleProvider" />
      </providers>
    </roleManager>
    <profile defaultProvider="UmbracoMemberProfileProvider" enabled="true">
      <providers>
        <clear />
        <add name="UmbracoMemberProfileProvider" type="umbraco.providers.members.UmbracoProfileProvider, umbraco.providers" />
      </providers>
      <properties>
        <clear />
        <add name="firstName" allowAnonymous ="false" provider="UmbracoMemberProfileProvider" type="System.String" />
        <add name="lastName" allowAnonymous ="false" provider="UmbracoMemberProfileProvider" type="System.String" />
        <add name="emailPreferences" allowAnonymous ="false" provider="UmbracoMemberProfileProvider" type="System.String" />
        <add name="mobile" allowAnonymous ="false" provider="UmbracoMemberProfileProvider" type="System.String" />
        <add name="companyName" allowAnonymous ="false" provider="UmbracoMemberProfileProvider" type="System.String" />
      </properties>
    </profile>

var m = Membership.CreateUser(txtEmail.Text, txtPassword.Text, txtEmail.Text);
var profile = ProfileBase.Create(m.UserName);

profile["firstName"] = txtFirstName.Text;
profile["lastName"] = txtLastName.Text;
profile["emailPreferences"] = ddlEmailPreferences.SelectedItem.Value;
profile["mobile"] = txtMobile.Text;
profile.Save();

Roles.AddUserToRole(m.UserName, "careerplayer Employer");

However trying to login the user with the following after registration doesn't work:

FormsAuthentication.SetAuthCookie(m.UserName, true);

I'm sure it's related but also changing the password via the member profile in Umbraco does not save the change in the database - no password is changed. Changing member profile properties save fine.

Any ideas or pointers would be much appreciated as this is the only thing holding this project up right now and may be the case that I am missing something obvious.

Cheers, Simon