Thanks Matt,

This is useful, and when I manually strip this out the image renders. I am not sure if this is a bug, or I am trying to use it in the wrong way (am fairly new to Umbraco), so will have a play and log it as a request to fix if I can't find a way of dealing with it!

Cheers

Chris

Hey Man,

I just started using a DFS path for our media items save url, and serving them up from a site in IIS, and came across this issue too, so thought i'd log how we fixed it. The PhysicalFileSystem provider expects a local file so it can use the File.IO to get the dates. This obviously wont work with remote files.

public DateTimeOffset GetLastModified(string path)
    {
        return DirectoryExists(path) 
            ? new DirectoryInfo(GetFullPath(path)).LastWriteTimeUtc 
            : new FileInfo(GetFullPath(path)).LastWriteTimeUtc;
    }

If you create your own FileSystem provider and just use the PhysicalFileSystem to implement everything as usual with the exception of the GetLastModified method, that should work. See below implementation.

public class YomegoFileSystemProvider : IFileSystem
{
    private IFileSystem _provider { get; set; }

    public YomegoFileSystemProvider(string virtualRoot)
    {
        _provider = new PhysicalFileSystem(virtualRoot);
    }

    public YomegoFileSystemProvider(string rootPath, string rootUrl)
    {
        _provider = new PhysicalFileSystem(rootPath, rootUrl);
    }

    #region physicalfilesystem

    public IEnumerable<string> GetDirectories(string path)
    {
        return _provider.GetDirectories(path);
    }

    public void DeleteDirectory(string path)
    {
        _provider.DeleteDirectory(path);
    }

    public void DeleteDirectory(string path, bool recursive)
    {
        _provider.DeleteDirectory(path, recursive);
    }

    public bool DirectoryExists(string path)
    {
        return _provider.DirectoryExists(GetFullPath(path));
    }

    public void AddFile(string path, Stream stream)
    {
        _provider.AddFile(path, stream);
    }

    public void AddFile(string path, Stream stream, bool overrideIfExists)
    {
        _provider.AddFile(path, stream, overrideIfExists);
    }

    public IEnumerable<string> GetFiles(string path)
    {
        return _provider.GetFiles(path, path);
    }

    public IEnumerable<string> GetFiles(string path, string filter)
    {
        return _provider.GetFiles(path, filter);
    }

    public Stream OpenFile(string path)
    {
        return _provider.OpenFile(path);
    }

    public void DeleteFile(string path)
    {
        _provider.DeleteFile(path);
    }

    public bool FileExists(string path)
    {
        return _provider.FileExists(path);
    }

    public string GetRelativePath(string fullPathOrUrl)
    {
        return _provider.GetRelativePath(fullPathOrUrl);
    }

    public string GetFullPath(string path)
    {
        return _provider.GetFullPath(path);
    }

    public string GetUrl(string path)
    {
        return _provider.GetUrl(path);
    }

    public DateTimeOffset GetCreated(string path)
    {
        return _provider.GetCreated(path);
    }

    #endregion physicalfilesystem

    #region ours

    public DateTimeOffset GetLastModified(string path)
    {
        // ML - Work around for using a UNC DFS path

        if (Regex.IsMatch(path, "^(http|https)://.*$"))
        {
            var request = WebRequest.Create(path) as HttpWebRequest;

            if (request != null)
            {
                request.Method = "HEAD";

                var response = request.GetResponse() as HttpWebResponse;

                if (response != null)
                {
                    if (response.StatusCode == HttpStatusCode.OK)
                    {
                        return response.LastModified;
                    }
                }
            }
        }

        return _provider.GetLastModified(path);
    }

    #endregion ours
}

What would be much nicer if the methods on the PhysicalFileSystem were marked as virtual so we could just override the ones we want after making our class inherit from PhysicalFileSystem, but suppose we cant have everything. You could just use the 'new' keyword before your implementation of GetLastModified but that's not a very transparent pattern i suppose.

Our FileSystemPRoviders config looks like this

<FileSystemProviders>

  <!-- Media -->

  <Provider alias="media" type="Website.Core.Plugins.Umbraco.Providers.YomegoFileSystemProvider, Website.Core.Plugins.Umbraco">

    <Parameters>

      <add key="rootPath" value="\\[unc]\[client]\[project]\[environment]\media\" />

      <add key="rootUrl" value="http://our.image.url/[client]/[project]/[environment]/media/" />

    </Parameters>

  </Provider>

</FileSystemProviders>

is working on a reply...