Hello,

I'm writing some code in which I want to create a member. The problem is I don't know what is the best way to create a member. You can use Member.MakeNew or System.Web.Security.Membership.CreateUser. In CreateUser the UmbracoMembershipProvider is called which uses the following code:

///
 
 <summary>
 
/// Adds a new membership user to the data source.
 
/// </summary>
 
/// <param name="username">The user name for the new user.</param>
 
/// <param name="password">The password for the new user.</param>
 
/// <param name="email">The e-mail address for the new user.</param>
 
/// <param name="passwordQuestion">The password question for the new user.</param>
 
/// <param name="passwordAnswer">The password answer for the new user</param>
 
/// <param name="isApproved">Whether or not the new user is approved to be validated.</param>
 
/// <param name="providerUserKey">The unique identifier from the membership data source for the user.</param>
 
/// <param name="status">A <see cref="T:System.Web.Security.MembershipCreateStatus"></see> enumeration value indicating whether the user was created successfully.</param>
 
/// <returns>
 
/// A <see cref="T:System.Web.Security.MembershipUser"></see> object populated with the information for the newly created user.
 
/// </returns>
 
public override MembershipUser CreateUser(string username, string password, string email, string passwordQuestion,
 
string passwordAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status)
{
 
if (Member.GetMemberFromLoginName(username) != null)
status = 
MembershipCreateStatus.DuplicateUserName;
 
else if (Member.GetMemberFromEmail(email) != null)
status = 
MembershipCreateStatus.DuplicateEmail;
 
else
{
 
Member m = Member.MakeNew(username, email, MemberType.GetByAlias(m_DefaultMemberTypeAlias), User.GetUser(0));
m.Password = password;
 
MembershipUser mUser =
ConvertToMembershipUser(m);
 
// custom fields
 
if (!String.IsNullOrEmpty(m_PasswordRetrievalQuestionPropertyTypeAlias))
updateMemberProperty(m, m_PasswordRetrievalQuestionPropertyTypeAlias, passwordQuestion);
 
 
if (!String.IsNullOrEmpty(m_PasswordRetrievalAnswerPropertyTypeAlias))
updateMemberProperty(m, m_PasswordRetrievalAnswerPropertyTypeAlias, passwordAnswer);
 
 
if (!String.IsNullOrEmpty(m_ApprovedPropertyTypeAlias))
updateMemberProperty(m, m_ApprovedPropertyTypeAlias, isApproved);
 
 
if (!String.IsNullOrEmpty(m_LastLoginPropertyTypeAlias)) {
mUser.LastActivityDate = 
DateTime.Now;
updateMemberProperty(m, m_LastLoginPropertyTypeAlias, mUser.LastActivityDate);
}
 
// save
m.Save();
status = 
MembershipCreateStatus.Success;
 
return mUser;
}
 
return null;
}

Now this code still creates an Umbraco Member using Member.MakeNew, but you can't choose your member type for instance. It uses m_DefaultMemberTypeAlias which is set using the following code:

// test for membertype (if not specified, choose the first member type available)
 
if (config["defaultMemberTypeAlias"] != null)
m_DefaultMemberTypeAlias = config[
"defaultMemberTypeAlias"];
 
else if (MemberType.GetAll.Length == 1)
m_DefaultMemberTypeAlias = 
MemberType.GetAll[0].Alias;
 
else
 
throw new ProviderException("No default MemberType alias is specified in the web.config string. Please add a 'defaultMemberTypeAlias' to the add element in the provider declaration in web.config");

Since I'd like to have the option to choose the MemberType I guess using Member.MakeNew is the best option, but on the wiki it says the member class will be obsoleted in Umbraco 4.1. What should I do?