Hi Kris,

I actually prefer the current implementation wherein web security is seperated from content. For partial actions you would also be using User.IsInRole() rather than IPublishedContent.HasAccess().

The option to hide or show content in navigation ("Visible") is unrelated to security imo (and correctly so a property on content).

And if that means writing an extra IF statement within a FOREACH.. I really don't mind :)

Grtz

L

PS: you could also use an extension method for filtering secured content

Here's an example for strongly typed content:

    public static IEnumerable<IPublishedContent> AndHasAccess(this IEnumerable<IPublishedContent> content)
    {
        var helper = new UmbracoHelper(UmbracoContext.Current);
        foreach (var c in content)
        {
            if (helper.IsProtected(c.Id, c.Path) && helper.MemberHasAccess(c.Id, c.Path))
                yield return c;
        }
    }

Usage:

CurrentPage.Children.Where("Visible").AndHasAccess()

I'm sure you can do the same for dynamic types.

Grtz

L

Hi Lennart,

I hadn' t looked at it in that way and I have to say it seems to make sense.

Your proposed extension method also seems like an elegant solution...

One more thing I currently do not fully grasp: would you have any idea why the Where on DynamicPublishedContent does not accept lambdas as arguments instead of strings needing parsing by ExpressionParser? Currently, my understanding of dynamics, lambdas and such does not reach much further than being able to use existing stuff so this might be a stupid question...

Hi Kris,

That's a tough question. I don't really have much experience with dynamic types as in most of our projects we have full control over model and content and I really prefer strongly typed models because I'm a monkey without intellisense :)

I do believe much of the confusion is caused by the quick pace at which dynamic types have changed over time (from Razor scripts in Umbraco 4.x to Umbraco 6 and 7) and the documentation still mentions the dynamic query parser has its merits when it comes to complex querying (i.e. lambdas)

The best advice I can give is to code by example and poke around and to keep reporting issues when you're stuck.

@Lennart, what a great extension method, I will be adding that one to my collection!

@Kris, you cannot use Lambda expressions with dynamics, that's why we have the Expression Parser instead. However if you want to do a Lambda you could either use a fully typed .Where or if you really want to you can used typed for your query and get it to return dynamic, here is how:

@{
    var myCollection = Model.Content.Children.Where(x => x.IsVisible()).Select(x => x.AsDynamic());
    foreach (var page in myCollection)
    {
        <p>dynamic property title: @page.title</p>
    }
}

Jeavon

is working on a reply...