Might be some typing mistakes...

<img src="{$textImage/umbracoFile}"/>

should be

<img src="{$estImage/umbracoFile}"/>

and what's your 

sportsIconImageLeft

variable, seems not be declared in the code?

Also, check out Lee's article on using GetMedia() (altho still uses the old pre 4.5 syntax)

Hope this helps.

Regards,

/Dirk

Dirk, thank you for your reply.

The sportsIconImageLeft is a media picker in the Document Type for the page.

Have made the changes you suggested without luck.

Have used this technique on other pages, but always with other code around (see below), which works.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE 
xsl:stylesheet [ <!ENTITY nbsp "&#x00A0;">
<!ENTITY node "*[@isDoc]">
<!ENTITY hidden 
"*[@isDoc and string(umbracoNaviHide)=true()]">
]>
<xsl:stylesheet 
  version="1.0" 
  xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
  xmlns:msxml="urn:schemas-microsoft-com:xslt"
  xmlns:umbraco.library="urn:umbraco.library"
 xmlns:Exslt.ExsltCommon="urn:Exslt.ExsltCommon"
 xmlns:Exslt.ExsltDatesAndTimes="urn:Exslt.ExsltDatesAndTimes"
 xmlns:Exslt.ExsltMath="urn:Exslt.ExsltMath"
 xmlns:Exslt.ExsltRegularExpressions="urn:Exslt.ExsltRegularExpressions"
 xmlns:Exslt.ExsltStrings="urn:Exslt.ExsltStrings"
 xmlns:Exslt.ExsltSets="urn:Exslt.ExsltSets"
 
  exclude-result-prefixes="msxml 
umbraco.library Exslt.ExsltCommon Exslt.ExsltDatesAndTimes 
Exslt.ExsltMath Exslt.ExsltRegularExpressions Exslt.ExsltStrings 
Exslt.ExsltSets ">


<xsl:output
 method="xml" omit-xml-declaration="yes"/>

<xsl:param name="currentPage"/>

<xsl:template
 match="/">

<xsl:variable
 name="sportsFolder"
 select="umbraco.library:GetXmlNodeById(1104)"/>
<ul>
  <xsl:for-each select="$sportsFolder/&node;">
    <xsl:sort select="sportActive" order="ascending"/>
<xsl:if  test="position()
 &lt;4">
<li class="sportsButton">
 <a href="{umbraco.library:NiceUrl(@id)}">
   <xsl:variable
 name="smallIcon" select="umbraco.library:GetMedia(sportsSmallIcons, 
0)/Image"/>
   <xsl:variable name="largeIcon"
 select="umbraco.library:GetMedia(sportsLargeIcons,
 0)/Image"/>
   <img class="smallicons"
 src="{$smallIcon/umbracoFile}"
 alt="{$smallIcon/@nodeName}"/>
   <img class="hide" src="{$largeIcon/umbracoFile}"
 alt="{$largeIcon/@nodeName}"/>
   <p class="hidetext"><xsl:value-of
 select="sportName"/></p>
  </a>
   </li>
   </xsl:if>
</xsl:for-each>
<xsl:for-each select="$sportsFolder/&node;">
    <xsl:sort select="sportActive" order="descending"/>
<xsl:if  test="position()
 &lt;=5">
<li class="sportsButton">
 <a href="{umbraco.library:NiceUrl(@id)}">
   <xsl:variable
 name="smallIcon" select="umbraco.library:GetMedia(sportsSmallIcons, 
0)/Image"/>
   <xsl:variable name="largeIcon"
 select="umbraco.library:GetMedia(sportsLargeIcons,
 0)/Image"/>
   <img class="smallicons"
 src="{$smallIcon/umbracoFile}"
 alt="{$smallIcon/@nodeName}"/>
   <img class="hide" src="{$largeIcon/umbracoFile}"
 alt="{$largeIcon/@nodeName}"/>
   <p class="hidetext"><xsl:value-of
 select="sportName"/></p>
  </a>     
    </li>
    </xsl:if>
</xsl:for-each>
<xsl:for-each select="$sportsFolder/&node;">
    <xsl:sort select="sportActive" order="descending"/>
<xsl:if  test="position()
 &gt;=8 and position() &lt; 11">
<li class="sportsButton">
 <a href="{umbraco.library:NiceUrl(@id)}">
   <xsl:variable
 name="smallIcon" select="umbraco.library:GetMedia(sportsSmallIcons, 
0)/Image"/>
   <xsl:variable name="largeIcon"
 select="umbraco.library:GetMedia(sportsLargeIcons,
 0)/Image"/>
   <img class="smallicons"
 src="{$smallIcon/umbracoFile}"
 alt="{$smallIcon/@nodeName}"/>
   <img class="hide" src="{$largeIcon/umbracoFile}"
 alt="{$largeIcon/@nodeName}"/>
   <p class="hidetext"><xsl:value-of
 select="sportName"/></p>
  </a>     
    </li>
    </xsl:if>
</xsl:for-each>
  </ul>
</xsl:template>
</xsl:stylesheet>

Should I re-create the Document Type property?

Have just had the same thing happen with another version of the same code.

The exact error I am seeing (on save) is:

System.OverflowException: Value was either too large or too small for an Int32.
at System.Convert.ToInt32(Double value)
at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
at System.Xml.Xsl.Runtime.XmlQueryRuntime.ChangeTypeXsltArgument(XmlQueryType xmlType, Object value, Type destinationType)
at System.Xml.Xsl.Runtime.XmlQueryContext.InvokeXsltLateBoundFunction(String name, String namespaceUri, IList`1[] args)
at (XmlQueryRuntime {urn:schemas-microsoft-com:xslt-debug}runtime)
at Root(XmlQueryRuntime {urn:schemas-microsoft-com:xslt-debug}runtime)
at System.Xml.Xsl.XmlILCommand.Execute(Object defaultDocument, XmlResolver dataSources, XsltArgumentList argumentList, XmlWriter writer)
at System.Xml.Xsl.XslCompiledTransform.Transform(IXPathNavigable input, XsltArgumentList arguments, TextWriter results)
at umbraco.presentation.webservices.codeEditorSave.SaveXslt(String fileName, String oldName, String fileContents, Boolean ignoreDebugging)

If this is ignored the code works!

 The code I am using has change to the following:

 <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE 
xsl:stylesheet [ <!ENTITY nbsp "&#x00A0;">
<!ENTITY node "*[@isDoc]">
<!ENTITY hidden 
"*[@isDoc and string(umbracoNaviHide)=true()]">
]>
<xsl:stylesheet 
  version="1.0" 
  xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
  xmlns:msxml="urn:schemas-microsoft-com:xslt"
  xmlns:umbraco.library="urn:umbraco.library"
 xmlns:Exslt.ExsltCommon="urn:Exslt.ExsltCommon"
 xmlns:Exslt.ExsltDatesAndTimes="urn:Exslt.ExsltDatesAndTimes"
 xmlns:Exslt.ExsltMath="urn:Exslt.ExsltMath"
 xmlns:Exslt.ExsltRegularExpressions="urn:Exslt.ExsltRegularExpressions"
 xmlns:Exslt.ExsltStrings="urn:Exslt.ExsltStrings"
 xmlns:Exslt.ExsltSets="urn:Exslt.ExsltSets"
 
  exclude-result-prefixes="msxml 
umbraco.library Exslt.ExsltCommon Exslt.ExsltDatesAndTimes 
Exslt.ExsltMath Exslt.ExsltRegularExpressions Exslt.ExsltStrings 
Exslt.ExsltSets ">


<xsl:output
 method="xml" omit-xml-declaration="yes"/>

<xsl:param name="currentPage"/>

<xsl:template
 match="/">
  <xsl:variable
 name="sportIcon" select="umbraco.library:GetMedia($currentPage/sportsPageImageLeft,
 0)/Image"/>
  <img src="{$sportIcon/umbracoFile}"/>
</xsl:template>

</xsl:stylesheet>

Why the error, but works on the page?

Before making the call to GetMedia, you should check if the value is not empty.

<xsl:if select="sportsSmallIcons != '' ">

When saving the xslt, umbraco tries to validate it against the root node. If that node does not have a property sportsSmallIcons, then GetMedia will fail because it does not get an integer passed.

HTH,

Peter

Peter, many thanks.

When I added the if statement, the file saved without any problems, but no images were shown on the website. Changing the statement to include $currentPage solved this and it is now all up and running.

Thanks for the explanation as to why the error, this makes everything much clearer.

 Peter I would vote your answer as corrent, but I do not have enough Karma points yet.

My final code is:

version="1.0" encoding="UTF-8"?>
DOCTYPE 
xsl:stylesheet [ ENTITY nbsp " ">
             
               ENTITY node "*[@isDoc]">
                            ENTITY hidden 
"*[@isDoc and string(umbracoNaviHide)=true()">
]>
<xsl:stylesheet 
  version="1.0" 
  xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
  xmlns:msxml="urn:schemas-microsoft-com:xslt"
  xmlns:umbraco.library="urn:umbraco.library"
 xmlns:Exslt.ExsltCommon="urn:Exslt.ExsltCommon"
 xmlns:Exslt.ExsltDatesAndTimes="urn:Exslt.ExsltDatesAndTimes"
 xmlns:Exslt.ExsltMath="urn:Exslt.ExsltMath"
 xmlns:Exslt.ExsltRegularExpressions="urn:Exslt.ExsltRegularExpressions"
 xmlns:Exslt.ExsltStrings="urn:Exslt.ExsltStrings"
 xmlns:Exslt.ExsltSets="urn:Exslt.ExsltSets"
 
  exclude-result-prefixes="msxml 
umbraco.library Exslt.ExsltCommon Exslt.ExsltDatesAndTimes 
Exslt.ExsltMath Exslt.ExsltRegularExpressions Exslt.ExsltStrings 
Exslt.ExsltSets ">


<xsl:output
 method="xml" omit-xml-declaration="yes"/>

<xsl:param name="currentPage"/>

<xsl:template
 match="/">
  <xsl:if test="$currentPage/sportsNameBar !=''">
  <xsl:variable
 name="sportsPageName"
 select="umbraco.library:GetMedia($currentPage/sportsNameBar,
 0)/Image"/>
  <img src="{$sportsPageName/umbracoFile}"/>
  xsl:if>
xsl:template>

xsl:stylesheet> 

Hi TaoistTotty,

I have to just mention that the 'hidden' entity you've declared is not going to do what you think it does (it returns true whether umbracoNaviHide is 0 or 1). You should do something like this instead:

<!ENTITY hidden "*[@isDoc and umbracoNaviHide = 1]">

Just so you don't copy&paste this one from file to file and it suddenly bites you... :-) 

/Chriztian

Chriztian

Thank you very much for this.

Is there a good book etc. on all of this.

TT

Chriztian

Have tried the hidden you suggested and this did not work (the full code is below), but the one I had does.

Do you know why - this has worried me as I know your know your XSLT.

Any advice gratefully received.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE xsl:stylesheet [ <!ENTITY nbsp "&#x00A0;">
<!ENTITY hidden "*[@isDoc and string(umbracoNaviHide)=true()]">
<!ENTITY node "*[@isDoc]">
]>
<xsl:stylesheet 
  version="1.0" 
  xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
  xmlns:msxml="urn:schemas-microsoft-com:xslt"
  xmlns:umbraco.library="urn:umbraco.library" xmlns:Exslt.ExsltCommon="urn:Exslt.ExsltCommon" xmlns:Exslt.ExsltDatesAndTimes="urn:Exslt.ExsltDatesAndTimes" xmlns:Exslt.ExsltMath="urn:Exslt.ExsltMath" xmlns:Exslt.ExsltRegularExpressions="urn:Exslt.ExsltRegularExpressions" xmlns:Exslt.ExsltStrings="urn:Exslt.ExsltStrings" xmlns:Exslt.ExsltSets="urn:Exslt.ExsltSets" 
  exclude-result-prefixes="msxml umbraco.library Exslt.ExsltCommon Exslt.ExsltDatesAndTimes Exslt.ExsltMath Exslt.ExsltRegularExpressions Exslt.ExsltStrings Exslt.ExsltSets ">


<xsl:output method="xml" omit-xml-declaration="yes"/>

<xsl:param name="currentPage"/>

<xsl:template match="/">

<xsl:variable name="homeMenu" select="1095"/>
<xsl:variable name="homePage" select="umbraco.library:GetXmlNodeById($homeMenu)"/>

  <ul>
    <xsl:choose>
      <xsl:when test="$currentPage/@id = 1095">
        <li>
          <a class="selected" href="{umbraco.library:NiceUrl(1095)}">
            <xsl:value-of select="$homePage/pageTitle"/>
          </a>
        </li>
      </xsl:when>
      <xsl:otherwise>
        <li>
          <a href="{umbraco.library:NiceUrl(1095)}">
            <xsl:value-of select="$homePage/pageTitle"/>
          </a>
        </li>
      </xsl:otherwise>
    </xsl:choose>
    <xsl:apply-templates select="$homePage/&node;"/>
  </ul>

</xsl:template>
<xsl:template match="&node;">
  <xsl:choose>
    <xsl:when test="$currentPage/@id = current()/@id">
      <li>
        <a class="selected" href="{umbraco.library:NiceUrl(@id)}">
          <xsl:value-of select="pageTitle"/>
        </a>  
      </li>
    </xsl:when>
    <xsl:otherwise>
      <li>
        <a href="{umbraco.library:NiceUrl(@id)}">
          <xsl:value-of select="pageTitle"/>
        </a>  
      </li>
    </xsl:otherwise>
  </xsl:choose>
</xsl:template>
<xsl:template match="&node;[&hidden;]"/>


</xsl:stylesheet>

Hi TT,

First, lets get rid of all the duplication and use a simple pattern: Provide a single template for the Document Type, and in the root (/) template you select the Documents you want to output - the last template handles the hidden nodes:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE xsl:stylesheet [
    <!ENTITY nbsp "&#x00A0;">
    <!ENTITY node "*[@isDoc]">
    <!ENTITY hidden "umbracoNaviHide = 1">
]>
<xsl:stylesheet 
    version="1.0" 
    xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
    xmlns:umbraco.library="urn:umbraco.library" 
    exclude-result-prefixes="umbraco.library">

    <xsl:output method="xml" omit-xml-declaration="yes" />

    <xsl:param name="currentPage" />

    <xsl:variable name="homeMenu" select="1095" />
    <xsl:variable name="homePage" select="umbraco.library:GetXmlNodeById($homeMenu)" />

    <xsl:template match="/">
        <ul>
            <xsl:apply-templates select="$homePage | $homePage/&node;" />
        </ul>
    </xsl:template>

    <xsl:template match="&node;">
        <li>
            <a href="{umbraco.library:NiceUrl(@id)}">
                <xsl:if test="@id = $currentPage/@id"><xsl:attribute name="class">selected</xsl:attribute></xsl:if>
                <xsl:value-of select="pageTitle"/>
            </a>  
        </li>
    </xsl:template>

    <xsl:template match="&node;[&hidden;]"/>

</xsl:stylesheet>

Now, I don't know the exact structure of your site, but the way you had set up for the hidden nodes, your template was only set to match documents that had a hidden child page - not documents that were hidden themselves, and I don't know if that was intentional, but I'm guessing not.

Another thing: Is your umbracoNaviHide property defined as a "Boolean (True/False)" property? (This should give 1 and 0 as values).

/Chriztian

Hi Chriztian

Thanks for this, I am just getting my head around this - I am also looking at the article you have produced on you website.

I assume the | means try either one.

Had a problem initially, but looking at the code with a clear head helped (leaving selected in the link will always cause a problem).

Does the xsl:attribute alway alter the preceeding HTML?

Thanks for all the help.

TT

Chriztain

Thanks ever so much, this now makes sense.

Once again thank you for all your help.

Regards

TT

is working on a reply...