Hi Dan,

Just had a quick look thorugh your code and Im not entirley sure about

 <xsl:variable name="linkID" select="$node/data[@alias = concat('box', $index, 'URL')]" />

the variable linkID is then passed to NiceURL which will be expecting a node ID to create a URL with. could this be causeing your issue?

Also this code

 <a href="{url}" title="Click for more information" class="quick-link">

should probably have a $ before the url variable.

Hope this helps

L

Oh no wait my bad, I see what you are doing.

have you tried putting /@id on the end of

 <xsl:variable name="linkID" select="$node/data[@alias = concat('box', $index, 'URL')]" />

L

Thanks Lachlann - good spot on the {url}s - sorted those.  However, the variable linkID should be returning a node ID - to be double sure I hard coded a node id into the line where the niceURL is called, and still same error.

Hmm have you looked at hard coding a media id for the GetMedia funciton, that is hte other one i know tends to throw the int32 errors

Also have you tried turning off error reporting and saving it anyway, I find that sometime even though it throws an error when you save it runs fine when its actually on the page.

L

I'm getting somewhere, but there appears to be a weird issue whereby the data on the node is only returned in the first iteration of the loop - even though the $index variable is incrementing okay.  I've stripped out most of my HTML and hard-coded one of the field aliases just to demonstrate the issue:

<xsl:param name="currentPage"/>

        <xsl:variable name="maxImageListImages" select="5" />
        
        <xsl:template match="/">
       <ul id="products">
                  <xsl:call-template name="outputImageListImage">
                         <xsl:with-param name="node" select="$currentPage" />
                    </xsl:call-template>
        </ul>
        </xsl:template>

        <xsl:template name="outputImageListImage">
        <xsl:param name="node" select="." />
        <xsl:param name="index" select="1" />
       <xsl:variable name="boxTitle" select="$node/data[@alias = concat('box', $index, 'Title')]" />
       <xsl:variable name="mediaID" select="$node/data[@alias = concat('box', $index, 'Image1')]" />
       <xsl:variable name="linkID" select="$node/data[@alias = concat('box', $index, 'URL')]" />
       <xsl:variable name="url" select="$linkID" />

**<xsl:value-of select="$index"/> / <xsl:value-of select="$node/data[@alias = 'box1Title']"/>**

       <xsl:if test="$index &lt;= $maxImageListImages">
            <xsl:call-template name="outputImageListImage">               
              <xsl:with-param name="index" select="$index + 1" />               
          </xsl:call-template>
        </xsl:if>
   </xsl:template>
</xsl:stylesheet>

I've put asterisks around the output, and here's what's returned:

**1 / First product**
**2 / **
**3 / **
**4 / **
**5 / **
**6 / **

Really, what I'm expecting here, whilst the 'box1Title' is hard-coded is:

**1 / First product**
**2 / First product**
**3 / First product**
**4 / First product**
**5 / First product**
**6 / First product**

When that's working I can then hook up boxXTitle to use the $index value to return the appropriate title for that item in the loop.

Can you see why 'box1Title' is only returned on the first loop, and is blank on the other iterations?  I think this is the crux of my issue.

Got around it by just referencing $currentPage instead of $node, and that's sorted it.

Thanks for your help Lachlann - the check on the mediaID value kind of pointed me in the right direction.

Hi Dan,

Just to help you understand why you didn't get the expected output...

When you first call the outputImageListImage template, you do so from within the root template (match="/") - you pass in $currentPage to the "node" parameter, which gets you the first output because $currentPage has that property (data[@alias = 'box1Title']) - when you call the template again (from within itself) you don't pass an argument to the $node parameter, so it'll take the default which you've specified (select=".").

Now that dot means to use the "current context node" which will actually fall back to the "/" from when you called it the first time (because it hasn't been changed since) and you'll probably be a little surprised if you try to examine that one, 'coz it'll hold only a <macro> element (possibly with some childnodes if the macro has parameters). 

To fix the template at that stage, you could send the existing $node parameter on to the next iteration: 

<xsl:if test="$index &lt;= $maxImageListImages">
    <xsl:call-template name="outputImageListImage">                         
        <xsl:with-param name="node" select="$node" />
        <xsl:with-param name="index" select="$index + 1" />                             
    </xsl:call-template>
</xsl:if>

Hope that helps you understand why it failed...

/Chriztian

Ace, thanks Chriztian!

is working on a reply...