Hi Dwayne,

I think the problem is that your test

<xsl:variable name="isCurrent" select="@id = $currentPage/ancestor-or-self::* /@id" />

Will retuen true for "cousins" also. See this post related to a similar problem: http://our.umbraco.org/forum/developers/xslt/18434-Syntax-question-ancestor-or-self-but-not-%27cousins%27

From what I read there, I think changing your test to someting like

<xsl:variable name="isCurrent" select="@id = $currentPage/ancestor-or-self::* [@id=$currentPage/@id or umbraco.library:GetXmlNodeById(@id)/@level &lt; $currentPage/@level] /@id" />

I am not an XSLT expert so there might be a cleaner way, but I hope this helps you.

Cheers,

Michael.

Hey Michael,

I've looked at it the thread you mention, but it appears uncertain they arrived at a valid solution. I tried to toy with it, but still no luck. Not at all certain what they are addressing there with "Site/Link". A very different approach than I want to go with. It seems hardwired to me and I like flexibility.

You are most certainly correct that the select statement needs tweaking, but wouldn't it be the latter, which tests level 2 URLs?

<xsl:variable name="subPages" select="./ *[@isDoc and string(umbracoNaviHide) != '1']" />
<xsl:if test="$isCurrent and $subPages">

Have tried. Same results as before.

    <xsl:template match="/">
      <xsl:variable name="siteRoot" select="$currentPage/ancestor-or-self::* [@level=1]" />
        <xsl:variable name="mainMenuItems" select="$siteRoot /*[@isDoc and string(umbracoNaviHide) != '1']" />
          <ul class="nav" id="nav-level1">
            <xsl:apply-templates select="$mainMenuItems" />
          </ul>
    </xsl:template>

    <xsl:template name="ShowMenuItem" match="*">
      <xsl:variable name="isCurrent" select="@id
 = $currentPage/ancestor-or-self::* [@id=$currentPage/@id or 
umbraco.library:GetXmlNodeById(@id)/@level &lt; $currentPage/@level]
 /@id" />
      <li style="background:#f1f1f1;">
          <xsl:if test="$isCurrent">
            <xsl:attribute name="class">
              <xsl:text>current</xsl:text>
            </xsl:attribute>
            </xsl:if>
            <a href="{umbraco.library:NiceUrl(@id)}">
                <xsl:value-of select="@nodeName"/>
            </a>
          <xsl:variable name="subPages" select="./ *[@isDoc and umbraco.library:GetXmlNodeById(@parentID)/@level &lt; $currentPage/@level]" />
            <xsl:if test="$isCurrent and $subPages">
              <ul class="nav" id="nav-level2" style="padding-left:10px;">
                <xsl:apply-templates select="$subPages" />
              </ul>
          </xsl:if>
        </li>
      </xsl:template>
</xsl:stylesheet>

By the way. I'm controlling styles with

<xsl:attribute name="class">
 <xsl:text>current</xsl:text>
</xsl:attribute>

The class .current sets the selected pages <a> styles.

Hi Dwayne,

The post I mentioned was indeed not a perfect match, but I thought the test on the level like I proposed would work. Apparently not, damn ;-)

I may be wrong but I don't think the problem resides in the subPages. I think it comes from the fact that the ancestor-or-self statement, as it is writen, gets cousins of the last level as well.

Anyway, another option would be to add an extra check on the place where you test if you need to use the "current" class or not. Could you maybe try with this:

<xsl:template match="/">
      <xsl:variable name="siteRoot" select="$currentPage/ancestor-or-self::* [@level=1]" />
        <xsl:variable name="mainMenuItems" select="$siteRoot /*[@isDoc and string(umbracoNaviHide) != '1']" />
          <ul class="nav" id="nav-level1">
            <xsl:apply-templates select="$mainMenuItems" />
          </ul>
    </xsl:template>

    <xsl:template name="ShowMenuItem" match="*">
      <xsl:variable name="isCurrent" select="@id = $currentPage/ancestor-or-self::* /@id" />
      <li style="background:#f1f1f1;">
          <xsl:if test="$isCurrent and (@id = $currentPage/@id or @level &lt; $currentPage/@level)">
            <xsl:attribute name="class">
              <xsl:text>current</xsl:text>
            </xsl:attribute>
            </xsl:if>
            <a href="{umbraco.library:NiceUrl(@id)}">
                <xsl:value-of select="@nodeName"/>
            </a>
          <xsl:variable name="subPages" select="./ *[@isDoc and string(umbracoNaviHide) != '1']" />
            <xsl:if test="$isCurrent and $subPages">
              <ul class="nav" id="nav-level2" style="padding-left:10px;">
                <xsl:apply-templates select="$subPages" />
              </ul>
          </xsl:if>
        </li>
      </xsl:template>

I have put my code change in bold, hope it will remain visible with the formatting...

Hope this one wil work :-)

Cheers,

Michael.

Michael, same results, different method ;-) I see where you are going. Odd that it differentiates level 1 and 2 elements from their respective cousins, but when it comes to level three it does not. Could this have any thing to do with the fact there is a style id for 1 and 2 but stops there? That was my initial thinking.

However, the styles seem to apply to level three in most cases, just not thye selected color attribute.

We seem to be on the right track. Changed

<xsl:if test="$isCurrent and (@id = $currentPage/@id or @level &lt; $currentPage/@level)">

to

<xsl:if test="$isCurrent and (@id = $currentPage/@id)">

and get

Hi Dwayne,

I don't think it has to do with the style-id's that stop at level2, because as far as I understand, it is the attribute "class=current" that gets wrongly set on the "cousin" nodes.

The result you get with your last example is indeed a good sign, it actually conforts me in thinking that the issue is only on the value of  $isCurrent, but I must say I don't understand why my proposition with the extra check on levels did not do the trick :-s Because there we should actually exclude nodes on the same level as the currentpage, aka the cousins. Maybe for some reason the "@level" is not available? Maybe you could try to retrieve it explicitely then:

<xsl:if test="$isCurrent and (@id = $currentPage/@id or umbraco.library:GetXmlNodeById(@id)/@level &lt; $currentPage/@level)">

Let's hope ;-)

Cheers,

Michael.

Thanks. I'll try that. Meanwhile, I am looking here at a tree navi solution to see how it was constructed. maybe something here can help.

http://our.umbraco.org/forum/developers/xslt/9894-creating-an-expandable-tree-using-XSLT

Michael, wish I could say that worked, but no dice. It sounds reasonable, what you said just before. It seems for some reason all is well on levels 1 and 2, but at level 3 all nodes on that level become current.

Mmmhhh, very strange indeed :-(

Maybe it is time for some debugging. Maybe at the end of your test on $isCurrent, after you have added the class attribute, you could output the @id, @level, $currentPage/@id and $currentPage/@level.

This might help us understand what is actually happening and why he keeps highlighting cousins.

Cheers,

Michael.

Yeah, sounds reasonable.

is working on a reply...