Hey,

What is the code for you xslt macro and template. Because I just tried appending this querystring to one of my umbraco sites and it works fine.

Dave

Hi,

Thanks for the reply.  I think the problem is with the RenderTemplate function - it doesn't affect every page.

To replicate this create the structure as shown in my first post in the content section.

Each RSS Item should have a template.  The template for RSS Channel should contain a macro calling XSLT which contains the following:

<xsl:for-each select="$currentPage/node">
                <xsl:variable name="currentPageId" select="current()/@id" />
                <xsl:value-of select="umbraco.library:RenderTemplate($currentPageId, current()/@template)" disable-output-escaping="yes"/>
</xsl:for-each>

Now navigate to the RSS Channel item in the content tree and append ?123 to the URL.  The RSS Item nodes will now no longer render correctly and will give the error above.

(I've also tried the single argument version of RenderTemplate and had the same problem).

Any ideas?  I've read that this random number has given other people trouble with PHP based CMSs.

I think the problem lies in the rendertemplate function. Reflector gives me this code for this function :

public static string RenderTemplate(int PageId, int TemplateId)
{
    try
    {
        if (UmbracoSettings.UseAspNetMasterPages)
        {
            if (!UmbracoContext.Current.LiveEditingContext.Enabled)
            {
                HttpContext current = HttpContext.Current;
                StringBuilder builder = new StringBuilder();
                foreach (object obj2 in current.Request.QueryString.Keys)
                {
                    if (!obj2.ToString().ToLower().Equals("umbpageid") && !obj2.ToString().ToLower().Equals("alttemplate"))
                    {
                        builder.Append(string.Format("&{0}={1}", obj2, current.Request.QueryString[obj2.ToString()]));
                    }
                }
                StringWriter writer = new StringWriter();
                current.Server.Execute(string.Format("/default.aspx?umbPageID={0}&alttemplate={1}{2}", PageId, new template(TemplateId).TemplateAlias, builder), writer);
                return writer.ToString();
            }
            return "RenderTemplate not supported in Canvas";
        }
        page page = new page(((IHasXmlNode) GetXmlNodeById(PageId.ToString()).Current).GetNode());
        page.RenderPage(TemplateId);
        Control pageContentControl = page.PageContentControl;
        StringWriter writer2 = new StringWriter();
        HtmlTextWriter writer3 = new HtmlTextWriter(writer2);
        pageContentControl.RenderControl(writer3);
        return writer2.ToString();
    }
    catch (Exception exception)
    {
        return string.Format("<!-- Error generating macroContent: '{0}' -->", exception);
    }
}

As you can see the function makes a call to your "Rss Item" with the given template. It also appends the querystring ("123")

Maybe you can remove this querystring with UrlRewriting but I'm not an expert.

Dave

Hmmm...

So RenderTemplate doesn't like having unpaired things in the query string.

I've not used URL rewriting either - is there anyone out there who could give me some simple instructions how I could rewrite the URL to remove this random number?

Thanks

Ed if this is a bug you should submit it to codeplex.

On codeplex:

http://umbraco.codeplex.com/WorkItem/View.aspx?WorkItemId=24967

Any further suggestions still welcome though.

quite a horibal hack but perhaps you could you create an alt template that does the render template bit in your macro and get the default template to use GetXmlDocumentByUrl to call the same page with the alt template? Or write some also hacky c# to clear the qsring

I can confirm this error.

I used RenderTemplate to render the HTML for a confirmation email at the url "www.blahblah.com?unsubscribe" <- RenderTemplate casts an exception when used on a url like this.

Workaround was to redirect to another url and send the email from there.

/Dennis

Thanks.

Please vote on codeplex if this issue affects you!

http://umbraco.codeplex.com/WorkItem/View.aspx?WorkItemId=24967

is working on a reply...