Hi Robin

What do you see if you write out the content of your $mediaFolder variable? Does it contain anything?

/Jan

Hi Jan,

$mediaFolder does give a value, but $mediaFolderID doesn't

The check should be:

 <xsl:if test="$mediaFolder &gt; 0">
 <p>Yipee</p>
 </xsl:if>

and if I add:

 <xsl:value-of select="$mediaFolder"/>

I get a value, but if I add:

 <xsl:value-of select="$mediaFolderID"/>

Nothing returns

Hi Robin

Ok, well that's probably because you're looking for a /node element, which does not exist in the current schema and is not what you get returned anyway :)

You need to feed the id to the GetMedia extension - Have a look at this http://our.umbraco.org/wiki/reference/umbracolibrary/getmedia

Hope this helps

/Jan

Hi Robin,

It looks to me that you have found some old XSLT that match the old XML schema, from version Umbraco 4.5, and later on there were implemented a new XML schema, which also have influence on how you should write your XSLT.

What if you do something like this:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE xsl:stylesheet [ <!ENTITY nbsp "&#x00A0;"> ]>
<xsl:stylesheet 
    version="1.0" 
    xmlns:xsl="http://www.w3.org/1999/XSL/Transform" 
    xmlns:msxml="urn:schemas-microsoft-com:xslt"
    xmlns:umbraco.library="urn:umbraco.library" xmlns:Exslt.ExsltCommon="urn:Exslt.ExsltCommon" xmlns:Exslt.ExsltDatesAndTimes="urn:Exslt.ExsltDatesAndTimes" xmlns:Exslt.ExsltMath="urn:Exslt.ExsltMath" xmlns:Exslt.ExsltRegularExpressions="urn:Exslt.ExsltRegularExpressions" xmlns:Exslt.ExsltStrings="urn:Exslt.ExsltStrings" xmlns:Exslt.ExsltSets="urn:Exslt.ExsltSets" 
    exclude-result-prefixes="msxml umbraco.library Exslt.ExsltCommon Exslt.ExsltDatesAndTimes Exslt.ExsltMath Exslt.ExsltRegularExpressions Exslt.ExsltStrings Exslt.ExsltSets ">

<xsl:output method="xml" omit-xml-declaration="yes"/>

<xsl:param name="currentPage"/>
<!-- This is our Macro Paramater with the alias of mediaFolder -->
<xsl:param name="mediaFolder" select="/macro/mediaFolder" />

<!-- The value of mediaFolder is an XML snippet, where we need to select the id attribute from the XML node <node> -->
<xsl:param name="mediaFolderID" select="$mediaFolder/@id" />

<xsl:template match="/">
<!-- start writing XSLT -->
    <xsl:if test="$mediaFolderID &gt; 0">
        <p>Yipee</p>
    </xsl:if>
</xsl:template>
</xsl:stylesheet>

Here a some documentation on the difference between the new and the old XML schema.

http://our.umbraco.org/wiki/reference/xslt/45-xml-schema

http://our.umbraco.org/wiki/reference/xslt/45-xml-schema/xslt-examples-updated-to-new-schema

http://our.umbraco.org/wiki/reference/xslt/45-xml-schema/no-more-@nodetypealias

Hope this helps,

/Dennis

Hi,

I just discovered I get nothing returned when I insert the macro in my template (where it should be). In my post above I inserted the Macro in a rich text editor in the 'content' section of the site. (The information I got was something like /media/22323/nameoftjepicture.jp1513211331..4556151jpg so it looked strange to me).

Which I understand from your post above, I should add

<xsl:value-of select="umbraco.library:GetMedia($mediaFolderID,0)/umbracoFile" />

but when saving the XSLT I get 'Error occured System.OverflowException: Value was either too large or too small for an Int32.' When I replace $mediaFolder with a number, I can save. So I think the variable is still empty.

I saw when I insert the macro in the template, a property mediaFolder="1327" is added, 1327 is the ID of the selected folder. Maybe this is what I need to get?

Edit: I saw I didn't paste the code well, so insterted it.

Hi Robin

Yeah, that sounds right :)

Have a look at the link I posted and the example Dennis posted above as well.

The error you got is because the value is not known before runtime so to avoid seeing it (if you're editing the XSLT inside Umbraco) and in general you need to make sure that the variable has a value before passing it the GetMedia extension.

Hope this helps.

/Jan

Hi,

It still doesn't work.

I deleted the /node in my code, but nothing changed. Also when I just copy/paste the code from Dennis it gives nothing. The $mediaFolderID stays empty

Hi Robin

Aaah, well that's because he's doing something that won't work either it seems.

The below is copy pasted from the page I linked to.

<xsl:variable name="media" select="umbraco.library:GetMedia($currentPage/bannerImage, 0)" />

 <xsl:if test="$media">
  <xsl:variable name="url" select="$media/umbracoFile" />
    <xsl:variable name="width" select="$media/umbracoWidth" />
     <xsl:variable name="height" select="$media/umbracoHeight" />
   <img src="{$url}" width="{$width}" height="{$height}" />
 </xsl:if>

In the $media variable the GetMedia extension is being used.

It returns the stuff you need to succeed - in your case it would look like this currently

<xsl:variable name="mediaFolder" select="umbraco.library:GetMedia($currentPage/bannerImage, 0)" />

 <xsl:if test="$mediaFolder">
<p>Yipeee</p>
 </xsl:if>

Hope this works :)

/Jan

:(

I still got the same error, but if I change $currentpage/bannerImage to 7777 I can save.

Argh, sorry!

You need to place the variable inside the if statement. My bad!

 <xsl:if test="$mediaFolder">
<xsl:variable name="mediaFolderId" select="umbraco.library:GetMedia($currentPage/bannerImage, 0)" />
<p>Yipeee</p>
 </xsl:if>

Try this.

/Jan

No problem,

I can save now (and now I understand what you ment with you have to check if it exists, but didn't know xslt was going to check if I checked it). But still I get no 'Yipee'.

Hi Dennis,

Fantastic!! It works like a charm. Thanks a lot. I have a look now why it works :)

Also thanks to Jan for his time and effort!

Hi Robin,

You are welcome, can you please mark this as solved, so other people that came across the post can go directly to the solution that works for you.

/Dennis

Hi Robin

You're welcome :)

/Jan

is working on a reply...