I'm doing a 1:1 multilingual site using Vorto. And while not strictly a question, I'd love to hear comments on how implemented it and also I found a strange behavior with PublishedContentRequest and IContentFinder

Small introduction: my setup has 3 languages (bg, en, fr), the name of each node (thus the URL) is in English only, and content is in Vorto properties.

Vanilla implementation would give me the same /folder/nodeName url for all language versions and I'd have had to differentiate by adding something like ?lang=fr and use the querystring to set the current thread culture in the page.

But this was not a nice solution, not for users with strange URLs and not for the code as was not very clean.

So I decided to dig into Umbraco extensibility and try to make everything more transparent and better-looking.

First step was to make sure URL are automatically generated based on the current culture, so that I don't have to manually add /fr/ or ?lang=fr everytime I needed to write a URL.

For this I created a IUrlProvider by extending the default DefaultUrlProvider. Here is the code:

    public class UrlWithLanguage : DefaultUrlProvider
    {

        public UrlWithLanguage()
        : base(UmbracoConfig.For.UmbracoSettings().RequestHandler){ }


        public override string GetUrl(UmbracoContext umbracoContext, int id, Uri current, UrlProviderMode mode)
        {
            var currentCulture = System.Globalization.CultureInfo.CurrentUICulture;
            var currentCultureName = currentCulture.TwoLetterISOLanguageName;
            var original = base.GetUrl(umbracoContext, id, current, mode);
            return "/" + currentCultureName +  original;
        }
    }

With this in place urls are automatically /en/folder/nodeName/

Then I had to make sure that when the request came back in, the language identifier was removed (otherwise umbraco would look for a node /en/folder/nodeName/ and would find nothing) and that the current culture was set to what was the language identified.

To this I created a IContentFinder, extending the ContentFinderByNiceUrl. Here is the code:

public class LanguageAwareContentFinder : ContentFinderByNiceUrl
{

    public override bool TryFindContent(PublishedContentRequest contentRequest)
    {
        string route;
        if (contentRequest.HasDomain)
            route = contentRequest.Domain.RootNodeId.ToString() + DomainHelper.PathRelativeToDomain(contentRequest.DomainUri, contentRequest.Uri.GetAbsolutePathDecoded());
        else
            route = contentRequest.Uri.GetAbsolutePathDecoded();

        CultureInfo ci = new CultureInfo("en");
        if (contentRequest.Uri.Segments.Length > 1)
        {
            var cultureString = contentRequest.Uri.Segments[1].TrimEnd('/');
            var languages = ApplicationContext.Current.Services.LocalizationService.GetAllLanguages().AsQueryable();
            var language = languages.SingleOrDefault(l => l.IsoCode == cultureString);

            if (language != null)
            {
                ci = language.CultureInfo;
                route = route.Replace("/"+contentRequest.Uri.Segments[1], "/");
            }
        }

        var node = FindContent(contentRequest, route);

        if (node == null) return false;

        contentRequest.PublishedContent = node;
        contentRequest.Culture = ci;

        return true;
    }
}

Basically I copied the code of the ContentFinderByNiceUrl and I remove the language identifier from the route sent to the FindContent. I also set the contentRequest.Culture to the culture identified in the url.

Unfortunately what I set here is overwritten later, and in the pages I always got en, no matter which was the language in the url.

I fixed the problem by handling the PublishedContentRequest.Prepared event, basically running the same code as above:

private void PublishedContentRequest_Prepared(object sender, EventArgs e)
{
    var contentRequest = sender as PublishedContentRequest;
    CultureInfo ci = new CultureInfo("en");
    if (contentRequest.Uri.Segments.Length > 1)
    {
        var cultureString = contentRequest.Uri.Segments[1].TrimEnd('/');
        var languages = ApplicationContext.Current.Services.LocalizationService.GetAllLanguages().AsQueryable();
        var language = languages.SingleOrDefault(l => l.IsoCode == cultureString);

        if (language != null)
        {
            ci = language.CultureInfo;
        }
    }
    contentRequest.Culture = ci;
}

So, back to the question: is this a good approach? Any comments? Do you see any obvious problem I might have not seen?

Then, why is the value of the PublishedContentRequest.Culture reset after the execution of the IContentFinder ends?

Thx Simone