Hi Ismail,

How do you run migrations ? Is it your own code ? Maybe you can post it ?

Dave

Dave,

See below:

using System;

using System.IO; using System.Web; using System.Xml.Linq; using Umbraco.Core.Logging; using Umbraco.Core.Persistence.Migrations; using Umbraco.Core.Persistence.SqlSyntax;

namespace Cogworks.ExamineFileIndexer.Migrations { [Migration("1.0.0", 1, "Cogworks.ExamineFileIndexer")] public class UpdateExamineConfigFiles : MigrationBase {

    private readonly string _confDir = HttpContext.Current.Server.MapPath("/config");

    public UpdateExamineConfigFiles(ISqlSyntaxProvider sqlSyntax, ILogger logger) : base(sqlSyntax, logger)
    {

    }

    public override void Up()
    {
        try
        {
            Logger.Debug<UpdateExamineConfigFiles>("looking at dir " + _confDir);

            UpdateExamineIndexConfig();

            UpdateExamineSettingsIndexProviderConfig();

            UpdateExamineSettingsSearchProviderConfig();
        }
        catch (Exception ex)
        {
            Logger.Error<Exception>("Error updating examine config files", ex);

        }
    }

    private void UpdateExamineIndexConfig()
    {
        var pathToExamineIndexConfig = Path.Combine(_confDir , "ExamineIndex.config");

        var configUpdater = GetConfigXmlToUpdate(pathToExamineIndexConfig);

        var updatedConfig = configUpdater.UpdateXmlFile(Constants.XpathToTestIndexSectionExists,
                                                        Constants.ExamineIndexFragmentXml, 
                                                        Constants.XpathToInsertIndexSectionAfter);

        updatedConfig.Save(pathToExamineIndexConfig);

        Logger.Debug<UpdateExamineConfigFiles>("Updated examine index config");
    }

    private void UpdateExamineSettingsIndexProviderConfig()
    {
        var pathToExamineIndexConfig = Path.Combine(_confDir, "ExamineSettings.config");

        var configUpdater = GetConfigXmlToUpdate(pathToExamineIndexConfig);

        var updatedConfig = configUpdater.UpdateXmlFile(Constants.XpathToTestIndexProviderSectionExists, 
                                                        Constants.ExamineSettingsProviderFragmentXml, 
                                                        Constants.XpathToInsertIndexProviderSectionAfter);

        updatedConfig.Save(pathToExamineIndexConfig);

        Logger.Debug<UpdateExamineConfigFiles>("Updated examine settings config added index provider");

    }

    private void UpdateExamineSettingsSearchProviderConfig()
    {
        var pathToExamineIndexConfig = Path.Combine(_confDir,"ExamineSettings.config");

        var configUpdater = GetConfigXmlToUpdate(pathToExamineIndexConfig);

        var updatedConfig = configUpdater.UpdateXmlFile(Constants.XpathToTestSearchProviderSectionExists,
                                                        Constants.ExamineSearchProviderFragmentXml, 
                                                        Constants.XpathToInsertSearchProviderSectionAfter);

        updatedConfig.Save(pathToExamineIndexConfig);

        Logger.Debug<UpdateExamineConfigFiles>("Updated examine settings config added search provider");

    }


    private ConfigFileUpdater GetConfigXmlToUpdate(string fileToUpdate)
    {

        var indexConfig = XDocument.Load(fileToUpdate);

        var configUpdater = new ConfigFileUpdater(indexConfig);

        return configUpdater;
    }

    public override void Down()
    {

        RemoveConfigItem("ExamineIndex.config", Constants.XpathToTestIndexSectionExists);

        RemoveConfigItem("ExamineSettings.config", Constants.XpathToTestIndexProviderSectionExists);

        RemoveConfigItem("ExamineSettings.config", Constants.XpathToTestSearchProviderSectionExists);
    }

    private void RemoveConfigItem(string file,string xPath)
    {
        var pathToExamineIndexConfig = Path.Combine(_confDir, file);

        var configUpdater = GetConfigXmlToUpdate(pathToExamineIndexConfig);

        var configFile = configUpdater.Remove(xPath);

        configFile.Save(pathToExamineIndexConfig);
    }
}

}

So the up bit fires fine and updates configs. However after package uninstall the down does not fire. I am thinking that this is wrong approach i should use package actions?

Hi Ismail,

I mean the code that actually runs the migrations. Maybe it only performs the upgrade ?

Dave

It runs via applicationeventhandler but I think i know where you are coming from. So it runs once and puts entry in the db. When I uninstall there is no way for the down code to run and there is still entry in the db.

I am just looking at how you do package action in nexu.

For the nuget package it is done using config transforms. For the Umbraco package I use the good old package action.

Dave

Hi Ismail,

what I currently do for this is to run XML Transforms and listinging to UninstallPackage event.

Would also love to use the migrations but I don't know if you can use the down methods there at all.

Also as the Migrations are primarily for doing DB stuff and not related to installing/uninstalling packages the current workflow don't run them automatically.

Maybe you can also try to let them run manually by listening to the uninstall event for packages.

Regards David

Hi Ismail,

not tested yet (but will try to).

Maybe it works when you call the migrations explicitly:

migrationsRunner.OrderedDowngradeMigrations(migrations).Select(x => x.Down());

So you would have to get all migrations with your plugin name give them to the method and then call the Down method on all of them.

Will see if I can setup a little test for that. Not sure how to get all migrations thought.

Regards David

David,

Aha that's interesting will try that.

This would make a nice open space topic coming CG. How to use the migrations as a package dev.

Dave

Dave,

Awesome work mate I will give it a go when I have a moment. The other dave yes it looks like a good way of doing package actions.

Regards

Ismail

Dave,

Partial success. On uninstall of package the down migration is run and config entries are removed. However the entry in the migrations db table is not removed so then next time you install package the up migration is not run as it thinks its already been run.

Regards

Ismail

Hi guys!

I have a similar challenge with a Umbraco 8-package that I want to install using both Nuget and as a umb-package.

As far as I can tell from this, the uninstalling from the backoffice is something that I would be able to support, either with the event handler that Rune posted or using a package action (if they still works =D).

But as far as I can understand it, if someone installs from nuget, the migration runs and then they decide to uninstall the nuget package - there is really no way for me to execute code to remove the db-tables right? As my dlls would be removed from the project at that point.

Or have anyone managed to find a solution for this?

Update: Turns out Umbraco 8 have a similar event that we can use during uninstall. I was a little afraid that the fact that the event runs after the uninstallation would mean that my dll's was removed and that this would not work. But I just tried with a uninstaller that removes the package (including its dlls) but still runs the event handler at the same time.

public class MyPackageComponent : IComponent
{
    private readonly IContentService _contentService;

    public MyPackageComponent(IContentService contentService)
    {
        _contentService = contentService;
    }

    public void Initialize()
    {

        PackagingService.UninstalledPackage += (sender, args) =>
        {
            // Do some magic here
        };

    }

    public void Terminate()
    {

    }
}

At the moment I can only see that one would have to recommend people who installs via nuget to uninstall the package in Umbraco before removing the nuget package?

is working on a reply...