Umbraco Version: 7.12.3

I have a few static methods that I use to convert IPublishedContent to something that can be returned as json, but for some reason, one of the methods loses the umbracoContext. I know they start out with it, as ToFeedData doesn't ever throw an error (it's called from beneath an UmbracoApiController). See the below code

public static Dictionary<string, object> ToFeedData(this IPublishedContent content) {
    var data = new Dictionary<string, object> {
        { "id", content.Id },
        { "name", content.Name },
        { "url", content.Url },
        { "urlName", content.UrlName },
        { "createDate", content.CreateDate },
        { "updateDate", content.UpdateDate }
    };
    foreach (var prop in content.Properties) {
        if (prop.HasValue && prop.PropertyTypeAlias != "seoSettings") {
            data.Add(prop.PropertyTypeAlias, ConvertType(prop.Value));
        }
    }
    return data;
}

public static object ConvertType(Object value) {
    if (value == null) {
        return null;
    }

    if (value is JObject) {
        return null;
    }

    if (value is IEnumerable<IPublishedContent>) {
        var item = (IEnumerable<IPublishedContent>)value;
        return item.Where(x => x != null).Select(val => val.ToJson());
    }
    if (value is IPublishedContent) {
        var node = (IPublishedContent)value;
        return node.ToJson();
    }
    return value;
}

public static object ToJson(this IPublishedContent content) {
    if (content is Image) {
        if (UmbracoContext.Current == null) {
            return null;
        }
        return content.ToImageModel();
    }
    else {
        var data = new JObject();
        data["id"] = content.Id;
        data["name"] = content.Name;
        --> data["url"] = content.Url;
        data["urlName"] = content.UrlName;
        data["createDate"] = content.CreateDate;
        data["updateDate"] = content.UpdateDate;

        foreach (var prop in content.Properties) {
            if (prop.HasValue && prop.PropertyTypeAlias != "seoSettings") {
                --> var result = ConvertType(prop.Value);
                if (result != null) {
                    var alias = prop.PropertyTypeAlias;
                    var type = result.GetType();
                    if (type.IsPrimitive || type == typeof(string)) {
                        data[prop.PropertyTypeAlias] = (dynamic)result;
                    }
                    else if (result is IEnumerable<dynamic>) {
                        data[prop.PropertyTypeAlias] = JArray.FromObject(result);
                    }
                    else {
                        data[prop.PropertyTypeAlias] = JObject.FromObject(result);
                    }
                }
            }
        }
        return data;
    }
}

The ToFeedData method is what is the entry point for this and it works fine. However, when it calls ToJson, the UmbracoContext isn't always passed down, which causes content.Url to throw an error about the missing context.

I added arrows at the two points where I encountered errors. The first arrow is where a null reference error sometimes happens complaining that UmbracoContext.Current is null. The second also complains about a null value, and I'm pretty sure the reason is the same. It's triggering the TextValueConverter, which calls ParseInternalLinks, which encounters the same issue generating urls as the first error.

This didn't used to be an issue. I believe it happened around the time I added hostnames to the root nodes (the site has multiple root nodes). I tried removing them, but unfortunately it didn't help.

Any ideas on how to resolve this? I know it's not because of nested content, as the node that throws the error is tied to an actual node.