macro parameters don't appear to be working juno stable - bugs

Go to solution

Press Ctrl / CMD + C to copy this to your clipboard.

Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at

Paul Blair 466 posts 731 karma points

Jan 11, 2011 @ 23:51

0

Macro parameters don't appear to be working Juno (Stable)

Hi,

Just playing around with the RC for Juno today and it appears macro parameters aren't getting passed through to the XSLT.

I.e.

masterpage:

<umbraco:Macro ID="Macro1" Alias="ahProductBox" runat="server" ShowInLeftCol="0"></umbraco:Macro>

XSLT:

<xsl:variable name="ShowInLeftCol" select="/macro/ShowInLeftCol"/>

<xsl:template match="/">
<xsl:value-of select="$ShowInLeftCol"/>

No value is displayed. The macro has the parameter included.

I have also tried this with the business skins by changing the numberOfItems to 1 and it was also not picked up there:

<umbraco:macro id="Macro1" numberofitems="1" excerptlength="90" alias="umbBusinessFrontpageNews" runat="server"></umbraco:macro>

Cheers

Paul

Copy Link
Chad 66 posts 130 karma points c-trib

Jan 12, 2011 @ 05:51

0

Same issue for me here. Have created a bug on codeplex

http://umbraco.codeplex.com/workitem/29860

Copy Link
Aaron Powell 1708 posts 3046 karma points c-trib

Jan 12, 2011 @ 07:30

0

I've put some questions into the bug you raised, but in the future can you please try and include more detail, not just pointing to a forum post.

Here's the guide to submitting bugs - http://our.umbraco.org/wiki/how-tos/submitting-bug-reports

Copy Link
Chad 66 posts 130 karma points c-trib

Jan 12, 2011 @ 07:52

0

Fair point, and of course.. I can't replicate now... will keep digging.

Copy Link
Arnold Visser 418 posts 778 karma points hq c-trib

Jan 12, 2011 @ 08:17

0

I've got the same issue.

@slace commented on Codeplex issue.

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 08:37

1

Looking into it right now - fix coming ASAP.

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 08:59

1

Confirmed and fixed. New build coming within the hour!

Copy Link
Chad 66 posts 130 karma points c-trib

Jan 12, 2011 @ 09:05

0

Hey Niels, I'd maybe hold off on that for a bit, finding more issues with caching with regard to razor templates (after haxing a fix in for those as well).

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 09:06

0

Could you please post more details?

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 09:09

2

@Chad: Found the bug - after editing the razor file the old compiled script doesn't get released - will fix!

Copy Link
Chad 66 posts 130 karma points c-trib

Jan 12, 2011 @ 09:11

0

That sounds like it. Updated codeplex already with more details (http://umbraco.codeplex.com/workitem/29858)

Copy Link
Daniel Bardi 927 posts 2562 karma points

Jan 12, 2011 @ 10:23

0

Any updates on when fixes will be released?

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 10:28

1

Today - they're already committed and we're testing them now...

Copy Link
Niels Hartvig 1951 posts 2391 karma points c-trib

Jan 12, 2011 @ 13:49

0

We believe we've fixed all the bugs reported since the release. Could you help us test with this nightly build: http://bit.ly/gtoyV1

Copy Link
Arnold Visser 418 posts 778 karma points hq c-trib

Jan 12, 2011 @ 14:10

0

Tested with fresh install: works now!

Copy Link
Árni Gunnar Ragnarsson 31 posts 51 karma points

Jan 12, 2011 @ 18:06

0

Are you going to push out a new release anytime soon ?

Copy Link
Daniel Bardi 927 posts 2562 karma points

Jan 12, 2011 @ 19:50

0

Params are now passing to macros, but doesn't appar that NiceUrl nor GetMedia are returning anything.

These don't work now:

<xsl:value-of select="umbraco.library:NiceUrl($nodeId)"/>
<xsl:value-of select="umbraco.library:GetMedia($media/@id, 'false')/umbracoFile" />

Copy Link
Daniel Bardi 927 posts 2562 karma points

Jan 12, 2011 @ 23:14

0

All is working now!

Copy Link

Árni Gunnar Ragnarsson 31 posts 51 karma points

Jan 13, 2011 @ 01:05

Well, for me, not ALL is working ...

parameters are being passed to the macro all right (an ascx control), but when I push them out to an XSLT file, they are lost, see code below:

XsltArgumentList arguments = umbraco.macro.AddXsltExtensions();
arguments.AddExtensionObject("urn:umbraco.library", new umbraco.library());
arguments.AddExtensionObject("urn:odin.xslext", new Odin.Modules.Extensions.Xslt());
arguments.AddExtensionObject("target-page-id", this.TargetUrlID.ToString());
arguments.AddExtensionObject("target-url", umbraco.library.NiceUrl(this.TargetUrlID));
arguments.AddExtensionObject("culture", this.Culture);

None of these arguments show up in my XSLT file, and they all did in the 4.6 Beta ...

Copy Link

Paul Blair 466 posts 731 karma points

Jan 13, 2011 @ 22:08

0

all appears to working as expected now in 4.6.1

Copy Link
Ben Martin 7 posts 27 karma points

Jan 25, 2011 @ 03:30
0
I am having a issue with passing a value of the current node to a ascx control.
```
<umbraco:Macro Alias="YourMacroAlias" runat="server" 
YourPropertyName="[#pageID]"></umbraco:Macro>
```
The value is not passed the .NET control.

Using 4.6.1.

See http://our.umbraco.org/wiki/reference/templates/umbracomacro-element
Copy Link
is working on a reply...

Please Sign in or register to post replies

Flag this post as spam?

Macro parameters don't appear to be working Juno (Stable)