I believe GetPassword() should, if possible, return the unencrypted password. However, as currently written it returns whatever's in the Member system, which can be encrypted.
This could be fixed by changing the lines:
if (m == null) { throw new MembershipPasswordException("The supplied user is not found"); } else { return m.Password; }
to:
if (m == null) { throw new MembershipPasswordException("The supplied user is not found"); } else { return UnEncodePassword(m.Password); }
UnEncodePassword is an existing helper method in the provider.
I would be happy to submit a patch. However, I've never done that before. Are there instructions on how to do that?
You should register on Codeplex, download latest source (install turtoise/subversion) and create a patch from within vs.net. Patch can be uploaded on Codeplex. Make sure to make lots of noise so core people get to review and approve quickly
Thanks for the efforts in finding/patching/coding/...
UmbracoMembershipProvider: GetPassword() Bug
I believe GetPassword() should, if possible, return the unencrypted password. However, as currently written it returns whatever's in the Member system, which can be encrypted.
This could be fixed by changing the lines:
if (m == null)
{
throw new MembershipPasswordException("The supplied user is not found");
}
else
{
return m.Password;
}
to:
if (m == null)
{
throw new MembershipPasswordException("The supplied user is not found");
}
else
{
return UnEncodePassword(m.Password);
}
UnEncodePassword is an existing helper method in the provider.
I would be happy to submit a patch. However, I've never done that before. Are there instructions on how to do that?
- Mark
Mark,
You should register on Codeplex, download latest source (install turtoise/subversion) and create a patch from within vs.net. Patch can be uploaded on Codeplex. Make sure to make lots of noise so core people get to review and approve quickly
Thanks for the efforts in finding/patching/coding/...
Cheers,
/Dirk
is working on a reply...