I am not sure if this is deliberate and I apologise in advanced if this is not formatted to the sites conventions (if not please point me in the direction of the info and I will update) however...
In the sendToTranslation.aspx.cs:73, the permissions for what is a translator is hard coded to the alias instead of getting the configuration from the user permissions making it impossible to use any other usertype to translate and making the permission a little redundant.
I have never submitted bug fixes to the core before and I am happy to make the change, could anyone point me in the direction of the process please.
Amazing, thank you. I keep meaning to contribute but this is the first thing I have found that seemed small enough for a first time contribution. I have raised an issue I will read the links you have provided over the weekend and submit the amendment in accordance with them.
Translator permissions hard coded? v7.2.1
I am not sure if this is deliberate and I apologise in advanced if this is not formatted to the sites conventions (if not please point me in the direction of the info and I will update) however...
In the sendToTranslation.aspx.cs:73, the permissions for what is a translator is hard coded to the alias instead of getting the configuration from the user permissions making it impossible to use any other usertype to translate and making the permission a little redundant.
I have never submitted bug fixes to the core before and I am happy to make the change, could anyone point me in the direction of the process please.
Hi Brian
Cool that you want to contribute with a PR - In order to do a PR for the source please read Sebastiaans article on the annual xmas calendar here http://24days.in/umbraco/2014/your-first-pull-request/
Maybe Andy Butlands article can be helpful as well even though it's more an overview of the code base http://24days.in/umbraco/2014/traveller-guide/
Following Sebastiaans guide you should be ready to submit the PR.
It may be a good idea to create an issue on the issue tracker here http://issues.umbraco.org/issues in order to keep track on the fix etc.
Be aware that it may take some time for HQ to review and accept your PR.
h5yr for wanting to contribute :)
/Jan
Amazing, thank you. I keep meaning to contribute but this is the first thing I have found that seemed small enough for a first time contribution. I have raised an issue I will read the links you have provided over the weekend and submit the amendment in accordance with them.
http://issues.umbraco.org/issue/U4-6094
Kind Regards
Brian
Hi Brian
Awesome - Hope your PR will be accepted - Keep us posted :)
Have a nice weekend.
/Jan
is working on a reply...