Hi Jason

Can you look at Umbraco Log what row cause the problem?

Look here - /AppData/Logs

Can you debug this site?

Thanks

Alex

I would like to rewrite your macro to this code:

@inherits Umbraco.Web.Macros.PartialViewMacroPage

@{
    var root = Umbraco.AssignedContentItem.AncestorOrSelf();
    var blog = root.Descendants("Blog").Take(1);

    int lastX = Convert.ToInt32(Model.MacroParameters["LastX"]);
    lastX = lastX > 0 ? lastX : 1;  // Default 1

    bool promotePost1 = Convert.ToBoolean(Model.MacroParameters["promotePost1"]);

    // Most recent post with an image
    var posts = root.Descendants("BlogPost").Where("MetaThumb != \"\"").OrderBy("PostDate desc").Take(lastX).ToList();

    //var blogUrl = Library.NodeById(blog.Id).Url;

    var firstPost = posts[0];
    var firstPostUrl = ProxyRequest.NormalizeLocalUrl(firstPost.Url);

}

@* Set 1st post to be prominant if shrink false *@
@if (promotePost1)
{
    <article class="post hentry">
        <a href="@firstPostUrl" class="image photo"><img src="@AppData.StaticServeUrl@firstPost.MetaThumb" @*width="340" height="289" *@ alt="image description"></a>
        @*<a href="@postUrl" class="alignleft photo"><img src="~/Assets/images/side-hustle-1.jpg" width="340" height="235" alt="image description"></a>*@

        @*<a href="@firstPostUrl" class="image photo"><img src="" width="340" height="289" alt="image description"></a>*@

        <div class="box">
            @*<span class="category">from the <a href="@blogUrl">blog</a></span>*@
            <h2 class="entry-title"><a href="@firstPostUrl">@firstPost.Name</a>
            </h2>
            @*<span class="meta"><span class="updated published">@firstPost.PostDate.ToString("M/dd/yyyy")</span> | By <span class="fn">@firstPost.Author</span></span>*@
            <div class="blog-teaser">
                @firstPost.GetPropertyValue("Teaser")
            </div>

            <a href="@firstPostUrl" class="btn">read more</a>
        </div>
    </article>
}

Do not use "Parameter" helper and "@inherits umbraco.MacroEngines.DynamicNodeContext"

Alex

Jason, it's hard to help you when I know so less about your solution.

Lets look at 'GetMetaTags.xslt' together :)

Hi Jason,

Have you tried completing deleting the cache and regenerating it?

Cache file can be found @ "/AppData/umbraco.config"

Delete it and then just do a full re-publish, see if it helps...

Regards

Craig

Jason

It looks like we need to fix all code in your site.

From which version did you upgrade?

Alex

Is there anything noticeable in the Log file that may aid us? I.e any errors related to Macros etc.

Hi Jason

Did you look at breaking changes?

Important if you are upgrading an existing site: for the best results:

In web.config do NOT change useLegacyEncoding to false if it is currently set to true - changing the password encoding will cause you not being able to log in any more In umbracoSettings.config leave EnablePropertyValueConverters set to false - this will help your existing content queries to still work

https://our.umbraco.org/documentation/Getting-Started/Setup/Upgrading/760-breaking-changes

Alex

So I think I figured out where the problem is. But I am unsure how to fix it.
I went into Umbraco Settings and changed the

 var firstPost = posts[0];

and I was able to debug it to the .where in this:

var posts = root.Descendants("BlogPost").Where("MetaThumb != \"\"").OrderBy("PostDate desc").Take(lastX);

So I am not sure if it is the .Where or the ("MetaThumb..") and I am not sure how to go about fixing it.

Hi Jason,

What is "MetaThumb" ?

Looks like your passing it as a string. Have you used Lambada Expressions before?

You could do something like this:

var posts = root.Descendants("BlogPost").Where(x => x.MetaThumb != "").OrderBy("PostDate desc").Take(lastX);

x.MetaThumb - being a strongly-typed property of a node (IPublishedContent)

OR

var posts = root.Descendants("BlogPost").Where(x => x.GetPropertyValue("MetaThumb") != "").OrderBy("PostDate desc").Take(lastX);

is working on a reply...