Hi Sebastiaan,

Thanks for the XSLT code-- yes, I could use this but it would be a lot more convenient if the htmlEncode feature worked.  I'm wondering if this is a bug and if so, how I should report it?

The resulting '&' rather than '&amp;' results in invalid HTML, according to the W3C validator.  I'm using it as part of a <title></title> section in the header.  I also tried urlEncode="true" and that also did not work.

Thanks,

-NorthK

Hey NorthK,

That is weird, looking in reflector, it definatley gets passed through HtmlEncode, so not sure why it wouldn't be encoded correctly

As an alternative, you could try setting the header to:

<umbraco:Item field="pageTitle" textIfEmpty="alternative title &amp;amp; text" htmlEncode="true" runat="server" />

Matt

Hey Matt,

You are super-clever-- your suggestion worked great!  The resulting generated code is correct. However, if Umbraco fixes this in the future, having the double ampersand in there will once again produce invalid HTML which I'd like to avoid.

For that reason it might be a better idea to write an XSLT macro that properly encodes the editible page field for HTML entities.  However, how do I do this in XSLT?  Anyone know?

Thanks a lot,

-NorthK

Hey NorthK,

You should be able to use the HtmlEncode library method within XSL to HTML encode a string

umbraco.library:HtmlEncode(...)

I've tried a few things with the umbraco:Item, but nothing seems to be working. Best I could suggest would be to create a Macro as you say, or maybe just a user control that you include in your master page and just do it via .NET.

Matt

All,

As it turned out I didn't need to use HtmlEncode(), since I was storing the page field as a textstring and apparently textstrings are automatically encoded into HTML entities if they need to be.  For some reason I thought textstrings would not do the encoding automatically.  So I did use an XSLT macro which in the end, looks alot like Sebastiaan's code :)  I did get the HtmlEncode() function working so I'll post my code here in case someone needs it (or I need it!).

<!-- if an SEO page title exists, use it.  If not, use a standard title -->
<xsl:choose>
    <xsl:when test="$currentPage/data [@alias='pageTitle'] != ''">
        <xsl:value-of select="$currentPage/data [@alias='pageTitle']/text()"/>
    </xsl:when>
    <xsl:otherwise>
        <xsl:text disable-output-escaping="yes"><![CDATA[my page title here with &amp; embedded in it.]]></xsl:text>
    </xsl:otherwise>
</xsl:choose>

</xsl:template>
</xsl:stylesheet>

<!-- preserving sample code here on how to HTML encode into entities, in case I need it later -->
<!--        <xsl:variable name="title" select="$currentPage/data [@alias='pageTitle']/text()"/> -->
<!--        <xsl:value-of select="umbraco.library:HtmlEncode($title)"/> -->

Thanks a lot guys!

-NorthK

is working on a reply...