Hi Jeavon,

The first line is:

@inherits Umbraco.Web.Mvc.UmbracoTemplatePage

and adding the <int> does get it going perfectly, so thanks much for that.

Is this something I need to learn about declaring variables properly or is it about learning how to use @inherits?

Or both...

Thanks again!

Hi Matthew,

Actually it might be a bug, one way or the other, I will have a closer look.

However generally it is useful to specify the return type when using the GetPropertyValue method but not always necessary.

Jeavon

Well, if it helps, what I'm doing is going through my mock-up and replacing spots where I used static image references with (hopefully) umbraco/razor queried images, and I just tried another spot where it didn't work even with the <int>, this one in another partial view but also in a foreach:

The view:

@inherits Umbraco.Web.Mvc.UmbracoTemplatePage
@{ Layout = "SectionPages.cshtml"; }

@section Breadcrumb{ @Html.Partial("SiteBreadcrumb") }

@{ var page = Model.Content; }

<div class="row">
    <div class="col-xs-12 bkg-top-img" style="background-image: url(@page.GetCropUrl("topImage", "FullSizeBanner")); background-repeat: no-repeat;">
        <div class="bkg-top-img-text">
            <h1>@page.Name</h1>
        </div>
    </div>
    <div class="clearfix"></div>
</div>
<div class="row">
    <div class="col-xs-12">
        <h1>@page.GetPropertyValue("title")</h1>
        @page.GetPropertyValue("bodyText")
    </div>
</div>

@Html.Partial("DisplaySectorChildPages")

The partial, with the offending var and GPV() additions commented out:

@inherits Umbraco.Web.Mvc.UmbracoTemplatePage
@{ var nodes = Model.Content.Children.Where(x => x.IsVisible());

@* IF I ADD THESE VARS HERE: *@
var page = Model.Content;
var mediaItem = Umbraco.TypedMedia(page.GetPropertyValue<int>("featureImage"));

    if (nodes.Any()){
        <ul class="list-unstyled page-list">
            @foreach (var childPage in nodes){
            <div class="row">
                    <li>
                        <div class="col-lg-4 col-md-6 col-sm-6 col-xs-12">
                            <div class="panel panel-default feature-box">
                                <div class="panel-heading">
                                    <a href="@childPage.Url"><h4>@childPage.GetPropertyValue("Title")</h4></a>
                                </div>
                                <div class="panel-img">
                                    <a href="@childPage.Url">

                                    @*<img src ="/images/780ff.jpg" alt="" />*@
                                    @* AND REPLACE THE ABOVE WITH THE BELOW *@
                                    <img src="@mediaItem.GetPropertyValue("umbracoFile")" alt="" />

                                    </a>
                                </div>
                            </div><!--/featuer box-->
                        </div><!--/col-->
                        <div class="col-lg-8 col-md-6 col-sm-6 col-xs-12">
                            <div class="panel-body">
                                <a href="@childPage.Url">
                                    <h4>@childPage.GetPropertyValue("Title")</h4>
                                </a>
                                @childPage.GetPropertyValue("lead")
                            </div>
                        </div>
                    </li>
                </div><!-- end row -->
            }
        </ul>
    }
}

I get an error: 'Object reference not set to an instance of an object.'

By which I mean, in the above, that when I put those commented out bits in, I get that error, otherwise, it runs fine.

I also tried putting them down in the foreach loop, and when in there, either omitting the page var, or leaving it and renaming the TypedMedia from (page. to (childPage.

Also just tried renaming the 'page' var to 'thisPage' as I noticed it was also in the view so maybe was coming into the partial with some baggage.

If I do: @childPage.GetPropertyValue("featureImage") , just using the existing variable 'childPage' in the foreach, it returns the media id.

Ok, trial and error with the Media section of the UmbracoHelper docs lead me to put this in the foreach:

var mediaID = childPage.GetPropertyValue("featureImage");
var mediaTyped = Umbraco.TypedMedia(mediaID);

<a href="@childPage.Url">

It works so for now I can move on but I still wish I knew why those other TypedMedia didn't.

And now, on another partial that is functionally identical, that last bit that worked, doesn't. Just shoot me...

'Object reference not set to an instance of an object. '

This time referring to a 'Title' property, not an image.

Hi Matthew,

I've had a good look and the reason is this is that when you pass in the value of object like this

var a = Umbraco.TypedMedia(Model.Content.GetPropertyValue("thing"));

and "thing" doesn't exist it causes the exception, doing a check should stop this, e.g.

if (Model.Content.HasValue("thing"))
{
    var a = Umbraco.TypedMedia(Model.Content.GetPropertyValue("thing"));
}

When you pass in the int, if the conversion failed, you are passing a null which TypedMedia will accept which is why it doesn't cause the exception.

Generally, make sure you check for HasValue before passing that into TypedMedia.

Hope that make sense?

Jeavon

Hmm, yes, it makes sense, sort of.  I don't get why it would have anything to do with that last case, with two identical partials (the only differences being the view they were called from and the size of the layout divs) but I confess I purposely left out if's thinking it'd save time during dev.  But maybe not.  I'll go put this to work and see.  Thanks again.

Well, aside from seeing that my code may now become more 'if's than div's, that actually helps quite a bit, as it pointed out that there was an offending child content page that didn't even have a featureImage property, by design. So it turns out to be an ID10T error. Doh! I wondered why all you guys put so many 'if's in your sample code...

Thank you so much for taking the time to enlighten me.

No problem, glad it's making sense now

is working on a reply...