Hi Dan

Do you have some caching enabled, which could be the cause? Is the macro mapped correctly to the view file?

/Jan

Hi Jan I have no caching enabled and yes the macro is mapped correctly I can even use the macro in the grid elsewhere and it works fine it only when its in the rte in the grid it have this behaviour. Its like its not rendering the macro when its in the rte.

Hi Dan,

Have you checked the checkboxes on the macro definition called :

Use in Rich Text Editor

Render in Rich Text Editor

Dave

I deleted the macro from the editor inserted it agian and now I cant get it to do it agian ?... Last I did this nothing happend. if this happend to the editor/customer of the site I can't just rely on them deleting the macro and hoping it will not do it again, I have had many of this small thinks with umbraco 7.. Im at this point that every time i save a node im hoping nothing will fuck up, maybe its because I started with umbraco 7.0.0 I would say it getting better but it still have alot of work to be done in my opinion.

Hi Dave I have tried render in Rich Text Editor and that worked fine it was just when I saw it on the site it didn't render the macro. Umbraco sometimes have its own life :P

Hi Dan

Hmm, weird - Think it may be the cache not being updated properly when the client deletes the macro.

Could you try to setup a test-page where you re-create the issue where it just shows the macro message and then try right clicking the "CONTENT" node and then choose "Repulish entire site" - Does it then disappear? And does it then work if you insert the macro you just removed again?

If so then there at least is an easier workaround - And then I think it should be reported as a bug on the issue tracker since Umbraco should not do this. It should of course not happen and Umbraco should not have it's own life. It should just work :)

/Jan

Just made a new page made the macro in the rte inside the grid system and agian it will not render the macro and it make no difference if i Repulish entire site.

I went in to the macro and selected the render file again and save, I don't think this changed anything, but after this I just inserted two more macros under the first one, on the test page and know there was nothing with the two new ones ?

so all I make after the first one works fine? then I wrote in the first rte where the one that didn't work was, then after I saved it worked ?

This is very confusing as its like it only get rendered if you have more than one first time you save and after that it doesn't matter ?

Cant really figure out the pattern for when it work and when it doesn't work, but for me I can get it to work with making a line break under the macro and it will make it work ?

This must be a bug with the macro if you insert it in the rte in the grid

Hi Dan

Yeah that does not sound right - Perhaps it's a good idea to report a bug on the issue tracker at http://issues.umbraco.org/issues

/Jan

Hi Dan Did you get this solved? I have the same problem (being able to render macro directly into template but not via RTE)

Best regards /Tove

I have the same problem.. I just did the surface control tutorial on Umbraco TV. The Contact form created there works fine in a page by itself. But If I put it in a grid it fails.

Yet it looks perfect in the back office.

So next I took the advice above and added a carriage return under the macro. Absurd that this should make any difference, but it did.

Almost a contact form. Have a look what Firebug reports behind this.

There is suppose to be inputs between those Divs. Umbraco has decided they are not important. :)

Joking aside, what is going on here?

How do you render the text field in your template ?

Dave

Dave

I don't 'render the text field'. The grid handles that. I just put the grid in the template like this.

@CurrentPage.GetGridHtml("sitePage", "fanoe")

Yes, RTE doesn't render macros, it has been reported and is due in 7.3. Whether it will be resolved or not I don't know. :)

http://issues.umbraco.org/issue/U4-6206

I have the same problem. Followed the video series on Surface Controllers, but it seems not everything works the same way in the latest version of Umbraco.

In the videos, the macro is inserted in the RTE on a normal text page, not a grid page, which is the standard of the new Fanoe starter kit (and for a good reason!) But, when you enable macros in the Grid TextPage editor, the macros will only render in the RTE, not on the frontend.

I see a "macro grid editor" is mentioned, but I can't find it, any clues?

Hi,

They changed issue U4-6206 to be resolved in 7.3.1

So for the moment I made this simple/ugly extension to UmbracoHelper and as a static method, until they add a better solution. :)

public static class MacroUtilities
{
    private static readonly Regex marcoFormat = new Regex(@"(<\?UMBRACO_MACRO (?:.+?)?macroAlias=[""']([^""\'\n\r]+?)[""'].+?)(?:/>|>.*?</\?UMBRACO_MACRO>)", RegexOptions.Compiled | RegexOptions.IgnoreCase);

    public static string RenderContentMacro(string content)
    {
        if (UmbracoContext.Current == null)
            return content;


        return RenderContentMacro(new UmbracoHelper(UmbracoContext.Current), content);
    }


    public static string RenderContentMacro(this UmbracoHelper UmbracoHelper, string content)
    {
        if (string.IsNullOrWhiteSpace(content))
            return string.Empty;

        if (content.IndexOf("UMBRACO_MACRO", StringComparison.InvariantCultureIgnoreCase) == -1)
            return content;

        var html = new HtmlDocument();
        html.LoadHtml(content);

        var macroNodes = html.DocumentNode.SelectNodes("//comment()[contains(., '<?UMBRACO_MACRO')]");
        if (macroNodes == null || !macroNodes.Any())
            return content;

        foreach (var c in macroNodes)
        {
            var macroMatch = marcoFormat.Match(c.InnerHtml);

            if(macroMatch.Value.IndexOf("macroalias", StringComparison.InvariantCultureIgnoreCase) == -1)
                continue;

            var attributes = helper.ReturnAttributes(macroMatch.Value.ToString()).Cast<DictionaryEntry>().ToDictionary(x => x.Key.ToString(), y => (object)y.Value);

            content = content.Replace(c.ParentNode.OuterHtml, UmbracoHelper.RenderMacro(attributes["macroalias"].ToString(), attributes).ToString());
        }

        return content;

    }

}

I had a few issues with the class above, mainly that:

• The content markup wasn't autoclosed where the parent node outer html was, so the replacement didn't work.
• That the helper.ReturnAttributes was deprecated.

I tweaked things this:

public static class MacroUtilities
{
    private static readonly Regex macroFormat = new Regex(@"(<\?UMBRACO_MACRO (?:.+?)?macroAlias=[""']([^""\'\n\r]+?)[""'].+?)(?:/>|>.*?</\?UMBRACO_MACRO>)", RegexOptions.Compiled | RegexOptions.IgnoreCase);

    public static string RenderContentMacro(string content)
    {
        if (UmbracoContext.Current == null)
        {
            return content;
        }

        return RenderContentMacro(new UmbracoHelper(UmbracoContext.Current), content);
    }


    public static string RenderContentMacro(this UmbracoHelper UmbracoHelper, string content)
    {
        if (string.IsNullOrWhiteSpace(content))
        {
            return string.Empty;
        }

        if (content.IndexOf("UMBRACO_MACRO", StringComparison.InvariantCultureIgnoreCase) == -1)
        {
            return content;
        }

        var html = new HtmlDocument();
        html.LoadHtml(content);
        content = html.DocumentNode.InnerHtml;

        var macroNodes = html.DocumentNode.SelectNodes("//comment()[contains(., '<?UMBRACO_MACRO')]");
        if (macroNodes == null || !macroNodes.Any())
        {
            return content;
        }

        foreach (var c in macroNodes)
        {
            var macroMatch = macroFormat.Match(c.InnerHtml);

            if (macroMatch.Value.IndexOf("macroalias", StringComparison.InvariantCultureIgnoreCase) == -1)
            {
                continue;
            }

            var attributes = Umbraco.Core.XmlHelper.GetAttributesFromElement(macroMatch.Value.ToString()).ToDictionary(x => x.Key, y => (object)y.Value);
            content = content.Replace(c.ParentNode.OuterHtml, UmbracoHelper.RenderMacro(attributes["macroalias"].ToString(), attributes).ToString());
        }

        return content;

    }

}

Thanks, it was a big help.

Hi Matt,

Thanks for your solution. Its working fine for me :)

Actually, I'm using u7dtg plugin for editor into my custom property editor, not the rte. So, it was showing 'Macro alias: AliasName' at fronend. But, now its rendering a perfect Macro.

is working on a reply...