Hi all,

I have been using Warren Buckley's Umbraco validation attributes plugin for as long as I remember and it is an awesome tool that should be part of the Umbraco core as Umbraco isn't truly multi-lingual at the moment without it. However, I have been having nothing but issues trying to get it to work in recent versions of Umbraco.

I am currently using version 7.2.4 and in this version it would appear that the plugin in general, even after some bug fixes (https://github.com/warrenbuckley/Umbraco-Validation-Attributes/issues/25) just does not work.

Part of the issues I am encountering may be because my model itself if overly complex but really this shouldn't be an issue.

My form overall is based upon the following tutorial by Sebastiaan Janssen which aims to create a multi-stage booking process:

http://umbraco.com/follow-us/blog-archive/2015/2/13/creating-multi-step-forms-using-a-surfacecontroller

My model is as follows:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.ComponentModel.DataAnnotations;
using Umbraco.Web.Models;
using Umbraco.Web;
using UmbracoValidationAttributes;

namespace My_Project.Models
{
    public class TourBookingModel : RenderModel
    {
        public TourBookingModel() : base(UmbracoContext.Current.PublishedContentRequest.PublishedContent) { }

        public bool Previous { get; set; }
        public bool Next { get; set; }
        public int StepIndex { get; set; }

        public TourInstanceSelection TourInstanceSelection { get; set; }
        public PassengerCountSelection PassengerCountSelection {get; set;}
    }

    public class TourInstanceSelection
    {
        [UmbracoRequired("Validation.Required")]
        public int? InstanceId { get; set; }
    }

    public class PassengerCountSelection
    {
        public int Adults { get; set; }
        public int Children { get; set; }
        public string Pickup { get; set; }
    }
}

I then have the following SurfaceController that uses this model:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.Mvc;
using Umbraco.Web.Mvc;
using My_Project.Models;
using System.Configuration;
using Newtonsoft.Json.Linq;

namespace My_Project.Controllers
{
    public class TourBookingController : SurfaceController
    {
        [ChildActionOnly]
        public ActionResult ShowBookingForm(TourBookingModel model)
        {
            model = model ?? new TourBookingModel();

            if (model.Previous)
                model.StepIndex--;

            if (model.Next && ModelState.IsValid)
                model.StepIndex++;

            return View(model);
        }

        [HttpPost]
        public ActionResult FormSubmit(TourBookingModel model)
        {
            //ignore validation or saving data when going backwards
            if (model.Previous)
                return CurrentUmbracoPage();

            var validationStep = string.Empty;
            switch (model.StepIndex)
            {
                case 0:
                    validationStep = "TourInstanceSelection";
                    break;
                case 1:
                    validationStep = "PassengerCountSelection";
                    break;
                case 2:
                    validationStep = "TermsAgreementStep";
                    break;
            }

            // remove all errors except for the current step
            foreach (var key in ModelState.Keys.Where(k => k.StartsWith(string.Format("{0}.", validationStep)) == false))
            {
                ModelState[key].Errors.Clear();
            }

            if (!ModelState.IsValid)
            {

                return CurrentUmbracoPage();
            }

            // It's the final step, do some saving
            if (model.StepIndex == 2)
            {
                TempData.Add("CustomMessage", "Your booking was successfuly submitted at " + DateTime.Now);
                return RedirectToCurrentUmbracoPage();
            }

            return CurrentUmbracoPage();
        }
    }
}

Finally, my form is rendered in the following view:

@using My_Project.Controllers
@using My_Project.Bespoke_Classes
@using Newtonsoft.Json
@using System.Configuration;
@using My_Project.GroupTourWebService
@model My_Project.Models.TourBookingModel
@{
    string instances = Model.Content.GetPropertyValue<string>("instances");
    string jsonInstances = string.Format("[{0}]", instances);

    List<string> availableDates = new List<string>();

    List<JSONTourInstance> tourInstances = JsonConvert.DeserializeObject<List<JSONTourInstance>>(jsonInstances);
    foreach (JSONTourInstance item in tourInstances)
    {
        availableDates.Add(item.Date);
    }

    string jsonDates = JsonConvert.SerializeObject(availableDates); 

    /* Group tour web service request information */   
    ManagedUserHeader managedUserHeader = new ManagedUserHeader();
    managedUserHeader.CompanyName = ConfigurationManager.AppSettings["name"];
    managedUserHeader.RegistrationKey = new Guid(ConfigurationManager.AppSettings["guid"]);

    CompressionSoapHeader compressionSoapHeader = new CompressionSoapHeader();
    compressionSoapHeader.CompressionMethodUsed = CompressionMethods.None;
}

@if (TempData.ContainsKey("CustomMessage"))
{
    <div>Hooray! - @TempData["CustomMessage"]</div>
}
else
{
    using (Html.BeginUmbracoForm<TourBookingController>("FormSubmit"))
    {
        <div class="panel panel-default clearfix">
            @switch (Model.StepIndex)
            {

                /* 
                * Tour Instance Selection Stage
                * The user selects a date and then a time that is linked to the date selected. The time itself is an instance which is then passed 
                * to the next stage when the user clicks the next button
                */

                case 0:
                    <div class="col-md-6">
                        <h3>1. Veldu dagsettningu</h3>
                        <div class="departureDate"></div>
                    </div>
                    <div class="col-md-6" id="TourInstanceSelection_Container">
                        @Html.ValidationMessageFor(x => Model.TourInstanceSelection.InstanceId)
                        <div class="hidden control">
                            <h3>2. Veldu brottfarartima</h3>
                            <div class="selectHolder">
                                <select id="BKG_tourInstanceSelect" name="TourInstanceSelection.InstanceId" class="btn-block">
                                    <option value="">-- Please select and option --</option>
                                    @foreach (JSONTourInstance tourInstance in tourInstances)
                                    {
                                        <option data-date="@tourInstance.Date" value="@tourInstance.Code">@tourInstance.Date @tourInstance.Time</option>
                                    }
                                </select>
                            </div>
                        </div>     
                    </div>
                                    break;

                /*
                * Tour Availability Stage
                * A request is sent to our web services to check the availability for the instance in question
                * The availabilty of the tour is returned.
                */

                case 1:
                    /* Case 1 goes here */
                break;
            }

            <div class="row">
                <div class="col-md-12">
                    <div class="col-md-6">
                        @if (Model.StepIndex > 0)
                        {
                            <button type="submit" class="btn btn-img-blue btn-block" name="Previous" id="BKG_Previous" value="true">Previous</button>
                        }
                    </div>
                    <div class="col-md-6">
                        <button type="submit" class="btn btn-img-blue btn-block hidden" id="BKG_Next" name="Next" value="true">Next</button>
                    </div>
                </div>
            </div>
            <input type="hidden" name="StepIndex" value="@Model.StepIndex" />
        </div>
    }
}

I have a dictionary value setup in the back office of "Validation.Required" that should fire on stage 1 of the booking process being invalid. This does fire successfully but the message displayed is not what I entered as a value in my dictionary. It appears it is completely ignore the Umbraco Validation attributes plugin and just using the default value. Does anyone have any ideas how to solve this as I am completely at a loss and this essentially means that implementing a proper multi-lingual Umbraco site is essentially impossible if this plugin does not work.

Any help or advice would be greatly appreciated.