Hi,

There seems to be an bug in the v6.0.1 release of the Umbraco Forms module.

Previously if you enabled moderation on form submissions, when a user submitted a new record, the forms admin could review the record and use the approval command in the Umbraco back office to approve the record.

The approval command seems to be broken in v6.0.1. It looks like the SQL command to update the form record is sent to the database, however the transaction is aborted so the change is never committed.

It looks like the problem lies in the following method: Umbraco.Forms.Data.Storage.RecordStorage.UpdateRecord

The method uses the ScopeProvider to create a new scope which is used to execute the SQL commands. However the IScope.Complete method is never called, so the transaction is always aborted.

Is there a patch for this bug. Has anyone else come across this issue? If there is a way to override the Umbraco.Forms.Data.Storage.RecordStorage.UpdateRecord, please let me know so I can resolve the issue.

If further information is required, please let me know.

    public Record UpdateRecord(Record record, Form form)
{
  using (ApplicationContext.Current.ProfilingLogger.DebugDuration<RecordStorage>(string.Format("Update Record '{0}' for the Form '{1}' with id '{2}'", (object) record.UniqueId, (object) form.Name, (object) form.Id)))
  {
    using (IScope scope = ApplicationContext.Current.ScopeProvider.CreateScope(IsolationLevel.Unspecified, RepositoryCacheMode.Unspecified, (IEventDispatcher) null, new bool?(), false))
    {
      record.Updated = DateTime.Now;
      scope.Events.Dispatch<RecordEventArgs>(RecordStorage.RecordUpdating, (object) this, new RecordEventArgs(record.State, form, record), "RecordUpdating");
      scope.Database.Update((object) record);
      Dictionary<Guid, RecordField> dictionary = new Dictionary<Guid, RecordField>();
      this._fieldValueStorage.DeleteAllRecordFieldValues(record);
      foreach (KeyValuePair<Guid, RecordField> recordField in record.RecordFields)
      {
        if (recordField.Value.Key == Guid.Empty)
          dictionary.Add(recordField.Key, this._storage.InsertRecordField(recordField.Value));
        else
          dictionary.Add(recordField.Key, this._storage.UpdateRecordField(recordField.Value));
      }
      record.RecordFields = dictionary;
      // scope.Complete() is missing here
      return record;
    }
  }
}