Hi guys

I have been busy creating a 'member content management' type setup with Contour, and one of the key things is to keep the created node in sync with the record (using workflows in record > node & events/action handlers in node > record). I have written this as I cannot seem to update the record in an action handler (that is called on unpublish action- required so I can implement expire at date on the node).

Full Action hanlder: (runs as expected, but the commented lines in meat of it cause it to fail):

using System;
using System.Collections.Generic;
using System.Text;
using umbraco.cms.businesslogic.web;
using umbraco.BusinessLogic;
using Umbraco.Forms.Core;
using Umbraco.Forms.Core.Services;
using Umbraco.Forms.Data;
using Umbraco.Forms.Data.Storage;

namespace AdvertPublishing
{

    /// <summary>
    /// Helps us with housekeeping - deleting node after (auto) unpublishing;
    /// </summary>
    public class UnPublishActionHandler : umbraco.BusinessLogic.Actions.IActionHandler
    {
        #region IActionHandler RemoveAdHandler

        public bool Execute(Document sender, umbraco.interfaces.IAction action) {
            /// <summary>
            /// have to use the action handler rather than unpublish event because the event doesn't get called when a document
            /// is being automatically expired (unpublished)
            /// </summary>
            if (action.Alias == umbraco.BusinessLogic.Actions.ActionUnPublish.Instance.Alias) {
                
                //Only applies for Advert
                if (sender.ContentType.Alias == "Advert")
                {
                    Log.Add(LogTypes.Custom, 0, "UnPublishActionHandler Executed in RemoveAdHandler");

                    //Check if content has recordGuid
                    if (!String.IsNullOrEmpty(sender.getProperty("recordGuid").Value.ToString()))
                    {

                        var storage = new RecordStorage();
                        Record record = storage.GetRecord(new Guid(sender.getProperty("recordGuid").Value.ToString()));
                        RecordService rs = new RecordService(record);
                        Form form = new FormStorage().GetFormFromRecordId(record.Id);

                        // Clear node from record
                        record.GetRecordField("Node").Values.Clear();
                        record.GetRecordField("Duration").Values.Clear();
                        storage.UpdateRecord(record, form);
                        //storage.UpdateRecordXml(record, form);
                        //storage.Dispose();
                        //rs.Submit();
                        //rs.Dispose();

                        Log.Add(LogTypes.Custom, 0, "record updated");

                        // Delete node
                        //sender.delete();
                        umbraco.library.RefreshContent();

                        Log.Add(LogTypes.Custom, 0, "node updated");
                    }
                }

            }
            return true;
        }

        public string HandlerName()
        {
            return "AdvertPublishing.UnPublishActionHandler";
        }

        public umbraco.interfaces.IAction[] ReturnActions() {
            return new umbraco.interfaces.IAction[] { umbraco.BusinessLogic.Actions.ActionUnPublish.Instance };
        }

        #endregion
    }

}

Relevant lines and why would these not work:

                        //storage.UpdateRecordXml(record, form);
                        //storage.Dispose();
                        //rs.Submit();
                        //rs.Dispose();

Any thoughts, have I missed something (seemingly) obvious, or is there something with the context of an action handler that the contour record stoage etc won't work.

Also while here, can you not delete a node from an upublish action? As that doesn't work either :(

Thanks!
Josh