I've tried to replicate the issue again:

Received an error from the server An error occured Cannot return the IPublishedContent because the UmbracoHelper was not constructed with an IPublishedContent. Exception Details System.InvalidOperationException: Cannot return the IPublishedContent because the UmbracoHelper was not constructed with an IPublishedContent.

And it fails in the following GetCurrentPage method:

public class UmbracoHelperWrapper : IUmbracoHelper
{
    private readonly UmbracoHelper _umbracoHelper;

    public UmbracoHelperWrapper(UmbracoHelper helper)
    {
        _umbracoHelper = helper ?? throw new ArgumentNullException(nameof(helper));
    }

    public IPublishedContent GetCurrentPage()
    {
        return _umbracoHelper.AssignedContentItem;
    }
}

This happens whenever I call the macro into a page

Hi Alex,

Correct me if I'm wrong, but I do believe it has been injected?

In the UmbracoHelperWrapper class, UmbracoHelper is injected as the following:

public class UmbracoHelperWrapper : IUmbracoHelper
{
    private readonly UmbracoHelper _umbracoHelper;

    public UmbracoHelperWrapper(UmbracoHelper umbracoHelper)
    {
        _umbracoHelper = umbracoHelper ?? throw new ArgumentNullException(nameof(umbracoHelper));
    }

    public IPublishedContent GetCurrentPage()
    {
        return _umbracoHelper.AssignedContentItem;
    }
}

And this then is then injected into the service class as:

    private readonly IUmbracoHelper _umbracoHelper;
    public Service(IUmbracoHelper umbracoHelper)
    {
        _umbracoHelper = umbracoHelper ?? throw new ArgumentNullException(nameof(umbracoHelper));
    }

DI was not set up properly for the UmbracoHelper. In V7 I could do the following:

builder.Register(x => new UmbracoHelperWrapper(new UmbracoHelper(UmbracoContext.Current))).As<IUmbracoHelper>().InstancePerRequest();

But with V8, it seems like I would need to populate all the values?

Any pointers in the correct direction?

Thanks