Hi all,

I have a problem with dynamically-generated xml sitemap in an Umbraco 8.6.1 multilingual site (French and English Languages).

I have adopted the new Umbraco 8.x multilanguage feature, as explained here: https://our.umbraco.com/documentation/Getting-Started/Backoffice/Variants/

But, when I have developed the dynamically-generated xml sitemap, I noticed that, when a content was not published in all languages (e.g., in English but not in French), in sitemap xml nodes I have, e.g. for French contents, a link with a trailing "#" (like this, for example: https://www.mysite.com/fr/#).

Here is the code:

@inherits Umbraco.Web.Mvc.UmbracoViewPage
@using System.Configuration;
@using Utility;
@{Layout = null;
    var rootNode = Model.AncestorOrSelf(1);
    var language = UtilityProperty.GetCultureFromRequestUrl(Request.RawUrl);
    var rootNodeUrl = ConfigurationManager.AppSettings["UrlDomain"] + rootNode.Url(language);
}<?xml version="1.0" encoding="UTF-8" ?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
        xmlns:image="http://www.google.com/schemas/sitemap-image/1.1"
        xmlns:video="http://www.google.com/schemas/sitemap-video/1.1">
    @if(rootNode.IsPublished() && !rootNode.GetProperty("hideFromSitemap").Value<bool>())
    {
        <url>
            <loc>@rootNodeUrl</loc>
            <lastmod>@rootNode.UpdateDate.ToString("s")+00:00</lastmod>
            <changefreq>daily</changefreq>
            <priority>0.8</priority>
        </url>
    }
    @ListChildNodes(Model.AncestorOrSelf(1), language)
</urlset>

@helper ListChildNodes(IPublishedContent startNode, string language)
{
    Response.ContentType = "text/xml";
    const int maxLevelForSiteMap = 100;
    string urlDomain = ConfigurationManager.AppSettings["UrlDomain"];

    string[] ignoredAliases = new string[] { "robots", "sitemapxml" };

    foreach (var node in startNode.Children
        .Where(n =>
            n.TemplateId > 0 && n.IsPublished()
            && (!n.HasProperty("hideFromSitemap") || !n.GetProperty("hideFromSitemap").Value<bool>()))
        .Select(n => n))
    {
        //excluding some contents, because they must not appear in XML
        if( !ignoredAliases.Contains(((IPublishedContent)node).ContentType.Alias.ToLower()) )
        {
            var nodeUrl = ((IPublishedContent)node).Url(language);
            if (nodeUrl != null && nodeUrl.Contains("http"))
            {
                nodeUrl = nodeUrl.Replace("http://", "").Replace("https://", "");
                nodeUrl = nodeUrl.Substring(nodeUrl.IndexOf("/"));
            }
                var url = urlDomain + nodeUrl;

                        <url>
                            <loc>@url</loc>
                            <lastmod>@node.UpdateDate.ToString("s")+00:00</lastmod>
                            <changefreq>daily</changefreq>
                            <priority>0.8</priority>
                        </url>

            }
            if (node.Level <= maxLevelForSiteMap)
             {
                    @ListChildNodes(node, language)
             }
     }
}

How can I solve this problem?

Thanks, Paco