OMG! You are an absolute hero!!! I will have a go with these instructions first thing in the morning thank you so much! Once I have done mine I'll see how it goes then mark as resolved if it works. Fingers crossed!

I feel I'm falling down at the very first hurdle!! :(

I have placed the "Methods in the surface controller" code inside my App_Code/Controllers/MemberControllers.cs code but I am getting the following error:

I tried VS suggestions to fix the code but I still get the same error. Am I placing this in the wrong place?

I have added the parts to the member and created a new Template (I didn't create a new documentType I added this into my Igloo Theme)

I'm fairly new with controllers so I'm sorry for all the questions!

could you post the content of your membercontroller? something must be amiss in the controller somewhere, or at least the definition of your controller. and maybe the code around the method in case it has something wrong around it.

mine looks like

using System;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.IO;
using System.Linq;
using System.Net;
using System.Web;
using System.Web.Mvc;
using System.Web.Security;
using System.Web.UI;
using Umbraco.Web.Models;
using Umbraco.Web.Mvc;


namespace Vantage.Controllers
{
    public class MemberSurfaceController : SurfaceController
    {
         .......
    }
}

Ah yes so first of all I didn't wrap a public class around the code. Secondly it was pasted inside another controller used for Members with the Igloo Theme so I created a separate controller called MemberResetController.cs with the following code:

using System; using System.Collections.Generic; using System.Collections.Specialized; using System.IO; using System.Linq; using System.Net; using System.Web; using System.Web.Mvc; using System.Web.Security; using System.Web.UI; using Umbraco.Web.Models; using Umbraco.Web.Mvc;

namespace Vantage.Controllers { public class MemberSurfaceController : SurfaceController {

    #region Password reset
    /// <summary>
    /// Display the password reset View
    /// </summary>
    /// <returns>~/Views/Partials/_SetPasswordPartial</returns>
    public ActionResult RenderLoginReset()
        {
            return PartialView("~/Views/Partials/_SetPasswordPartial");
        }

        /// <summary>
        /// Passsword reset callback, processes the link that was sent via email
        /// </summary>
        /// <param name="id">UMBRACO Member Id</param>
        /// <param name="token">Confirmation Token</param>
        /// <returns></returns>
        public ActionResult ResetPassword(int id, string token)
        {
            try
            {
                if (String.IsNullOrWhiteSpace(token) || id < 1)
                {
                    return CurrentUmbracoPage();
                }

                var memberService = Services.MemberService;
                var member = memberService.GetById(id);

                TempData["Change"] = true;
                TempData["Message"] = "Change password";
                TempData["Token"] = token;
                TempData["UserId"] = id;

                return PartialView("~/Views/Partials/_SetPasswordPartial");
            }
            catch { }
            return CurrentUmbracoPage();
        }

        /// <summary>
        /// Process the password reset forms
        /// </summary>
        /// <param name="form">Posted form collection (Password change or Send email)</param>
        /// <returns></returns>
        [HttpPost]
        [ValidateAntiForgeryToken]
        public ActionResult ResetPasswordForm(FormCollection form)
        {
            //check for a password field
            bool isPasswordForm = form.AllKeys.Contains("NewPassword");
            var memberService = Services.MemberService;

            if (isPasswordForm)
            {
                var member = memberService.GetById(Convert.ToInt32(form["userid"]));
                var token = member.GetValue<string>("confirmationToken");
                var tokenexpires = member.GetValue<DateTime>("tokenExpires");

                #region validate the form
                if (string.IsNullOrWhiteSpace(form["NewPassword"]))
                {
                    ModelState.AddModelError("NoPass", "You must enter a password");
                }
                if (form["NewPassword"] != form["ConfirmPassword"])
                {
                    ModelState.AddModelError("NoMatch", "passwords do not match");
                }
                if (form["token"] != token)
                {
                    ModelState.AddModelError("TokenInv", "Reset token is invalid");
                }
                if (DateTime.UtcNow > tokenexpires)
                {
                    ModelState.AddModelError("TokenExp", "Reset token has expired");
                }
                if (!ModelState.IsValid)
                {
                    return CurrentUmbracoPage();
                }
                #endregion

                #region reset the Umbraco password
                //there was a password, so lets do the reset
                memberService.SavePassword(member, form["NewPassword"]);
                member.LastPasswordChangeDate = DateTime.Now;
                Services.MemberService.Save(member);

                //remove the token and expiry
                member.SetValue("confirmationToken", "");
                member.SetValue("tokenExpires", null);
                Services.MemberService.Save(member);
                #endregion

                return RedirectToUmbracoPage(2390); //portal login
            }

            //not the new password form, so generate a token and send email
            var user = memberService.GetByUsername(form["email"]);

            if (user == null || user.Id < 0)
            {
                ModelState.AddModelError("ResetError", "Could not find an account that matches.");
                return CurrentUmbracoPage();
            }
            else
            {
                var token = CMSUtils.GenerateUniqueCode(24);
                user.SetValue("confirmationToken", token);
                user.SetValue("tokenExpires", DateTime.UtcNow.AddHours(48));
                memberService.Save(user);

                EmailHelper.SendResetPasswordConfirmation(ControllerContext, user, token);
                TempData["Change"] = false;
                TempData["Message"] = "<p>An email has been sent to your registered email address containing a password reset token. <br />Please follow the instructions in the email to reset your password.</p><p>The token will expire in 48 hours.</p>";
            }
            return CurrentUmbracoPage();
        }

        #endregion

}

}

I then get the following error regarding CMSUtils:

I gather this is a plugin that generates tokens for Umbraco? I am on Umbraco 8+ and couldn't find any reference to this on the internet.

So I generated a unique code in another way just to clear the error: var token = Guid.NewGuid().ToString().Replace("-", string.Empty);

but now get the following about EmailHelper (I assume this is a controller I do not have)

If I remove that line: EmailHelper.SendResetPasswordConfirmation(ControllerContext, user, token);

...then I can render the form! But it doesn't send anything (Probably because EmailHelper above is missing)

brilliant. I added this into my MemberResetController.cs and referenced this direct and seems to work however I am now stuck on the EmailHelper part now (I mentioned this above as I think I posted the exact time you replied about the token but here is the screen again...

If I remove that line the form now renders (But will not do anything I assume because the EmailHelper line is escaped out)

Is EmailHelper another controller I'm guessing I do not have?

I think I must be near the light at the end of the tunnel and I'm so sorry I have hassled you the last few days!! If this works you really deserve a beer or 2 wherever you are!!

Hi Huw, that would be amazing if it's not any trouble? I was currently trying to look at the code on CMS import as we use that to email the members their passwords initially but as it's an external plugin it may not work for me.

Great thanks!

and where does this sit? Inside the Member controller or as a new controller Emailhelper.cs?

At the moment I have escaped out :

EmailHelper.SendResetPasswordConfirmation(ControllerContext, user, token);

Just so I can continue to build

OK I added that under a new class called Emailhelper but now I am getting the following error (IMember could not be found):

To make it easier here is my full MemberSurface.cs (with email and passwords XXX out)

using System;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.IO;
using System.Linq;
using System.Net;
using System.Web;
using System.Web.Mvc;
using System.Web.Security;
using System.Web.UI;
using Umbraco.Web.Models;
using Umbraco.Web.Mvc;
using System.Configuration;
using System.Security.Cryptography;
using System.Text;



namespace Vantage.Controllers
{
    public class Emailhelper
    {
        public static void SendResetPasswordConfirmation(ControllerContext controllerContext, IMember member, string token)
        {
            var requesturl = controllerContext.HttpContext.Request.Url;
            string msgBody = "";

            var reseturl = $@"{requesturl.Authority}/ResetPassword/?id={member.Id}&val={token}";

            //You will probably want to replace this next part, I have an RTE on my Reset page that holds the template for my email
            int pageId = 2390; // Page Id of Password reset, to get the email template

            UmbracoHelper helper = Umbraco.Web.Composing.Current.UmbracoHelper;
            var content = helper.Content(pageId).Value<string>("emailTemplate");
            if (!string.IsNullOrWhiteSpace(content))
            {
                msgBody = content.Replace("[MEMBERNAME]", member.Name).Replace("[RESETLINK]", reseturl).Replace("\n", "");
            }

            //end if retreive template

            var body = "<p>Email From: {0} ({1})</p><p>Message:</p><p>{2}</p>";
            var message = new MailMessage();
            message.To.Add(new MailAddress(member.Username));  // replace with valid value 
            message.From = new MailAddress("[email protected]");  // replace with your from address
            message.Subject = "IN-SYNC Van Portal password reset request";
            message.Body = string.Format(body, "Name", "noreply@XXXX", msgBody);
            message.IsBodyHtml = true;

            using (var smtp = new SmtpClient())
            {
                var credential = new NetworkCredential
                {
                    UserName = "xxxxx",  // replace with valid value
                    Password = "XXXX"  // replace with valid value
                };
                smtp.Credentials = credential;
                smtp.Host = "smtp.sendgrid.net";
                smtp.Port = 587;
                smtp.EnableSsl = true;
                await smtp.SendMailAsync(message);
                return RedirectToAction("Sent");
            }

        }
    }

    public class MemberSurfaceController : SurfaceController
    {

        #region Password reset
        /// <summary>
        /// Display the password reset View
        /// </summary>
        /// <returns>~/Views/Partials/_SetPasswordPartial.cshtml</returns>
        public ActionResult RenderLoginReset()
            {
                return PartialView("~/Views/Partials/_SetPasswordPartial.cshtml");
            }

            /// <summary>
            /// Passsword reset callback, processes the link that was sent via email
            /// </summary>
            /// <param name="id">UMBRACO Member Id</param>
            /// <param name="token">Confirmation Token</param>
            /// <returns></returns>
            public ActionResult ResetPassword(int id, string token)
            {
                try
                {
                    if (String.IsNullOrWhiteSpace(token) || id < 1)
                    {
                        return CurrentUmbracoPage();
                    }

                    var memberService = Services.MemberService;
                    var member = memberService.GetById(id);

                    TempData["Change"] = true;
                    TempData["Message"] = "Change password";
                    TempData["Token"] = token;
                    TempData["UserId"] = id;

                    return PartialView("~/Views/Partials/_SetPasswordPartial.cshtml");
                }
                catch { }
                return CurrentUmbracoPage();
            }
        public static string GenerateUniqueCode(int length)
        {
            char[] chars = "ABCDEF0123456789".ToCharArray();
            byte[] data = new byte[1];
            using (RNGCryptoServiceProvider crypto = new RNGCryptoServiceProvider())
            {
                crypto.GetNonZeroBytes(data);
                data = new byte[length];
                crypto.GetNonZeroBytes(data);
            }
            StringBuilder result = new StringBuilder(length);
            foreach (byte b in data)
            {
                result.Append(chars[b % (chars.Length)]);
            }
            return result.ToString();
        }

        /// <summary>
        /// Process the password reset forms
        /// </summary>
        /// <param name="form">Posted form collection (Password change or Send email)</param>
        /// <returns></returns>
        [HttpPost]
            [ValidateAntiForgeryToken]
            public ActionResult ResetPasswordForm(FormCollection form)
            {
                //check for a password field
                bool isPasswordForm = form.AllKeys.Contains("NewPassword");
                var memberService = Services.MemberService;

                if (isPasswordForm)
                {
                    var member = memberService.GetById(Convert.ToInt32(form["userid"]));
                    var token = member.GetValue<string>("confirmationToken");
                    var tokenexpires = member.GetValue<DateTime>("tokenExpires");

                    #region validate the form
                    if (string.IsNullOrWhiteSpace(form["NewPassword"]))
                    {
                        ModelState.AddModelError("NoPass", "You must enter a password");
                    }
                    if (form["NewPassword"] != form["ConfirmPassword"])
                    {
                        ModelState.AddModelError("NoMatch", "passwords do not match");
                    }
                    if (form["token"] != token)
                    {
                        ModelState.AddModelError("TokenInv", "Reset token is invalid");
                    }
                    if (DateTime.UtcNow > tokenexpires)
                    {
                        ModelState.AddModelError("TokenExp", "Reset token has expired");
                    }
                    if (!ModelState.IsValid)
                    {
                        return CurrentUmbracoPage();
                    }
                    #endregion

                    #region reset the Umbraco password
                    //there was a password, so lets do the reset
                    memberService.SavePassword(member, form["NewPassword"]);
                    member.LastPasswordChangeDate = DateTime.Now;
                    Services.MemberService.Save(member);

                    //remove the token and expiry
                    member.SetValue("confirmationToken", "");
                    member.SetValue("tokenExpires", null);
                    Services.MemberService.Save(member);
                    #endregion

                    return RedirectToUmbracoPage(2390); //portal login
                }

                //not the new password form, so generate a token and send email
                var user = memberService.GetByUsername(form["email"]);

                if (user == null || user.Id < 0)
                {
                    ModelState.AddModelError("ResetError", "Could not find an account that matches.");
                    return CurrentUmbracoPage();
                }
                else
                {
                //var token = Guid.NewGuid().ToString().Replace("-", string.Empty);
                var token = GenerateUniqueCode(24);
                user.SetValue("confirmationToken", token);
                    user.SetValue("tokenExpires", DateTime.UtcNow.AddHours(48));
                    memberService.Save(user);

                //Below line is not referenced
                Emailhelper.SendResetPasswordConfirmation(ControllerContext, user, token);
                TempData["Change"] = false;
                    TempData["Message"] = "<p>An email has been sent to your registered email address containing a password reset token. <br />Please follow the instructions in the email to reset your password.</p><p>The token will expire in 48 hours.</p>";
                }
                return CurrentUmbracoPage();
            }

            #endregion

    }
}

I tried adding using Umbraco.Core at the top but it still didn't work after a rebuild.

By the way I think I am going to add my email template via RTE within the page too as it means we can edit the email via the umbraco backend. I assume you have the email html code inside the RTE and the id of the RTE is "emailTemplate"?

Getting more errors now regarding UmbracoHelper.

I tried adding "using Umbraco.Web;" which cleared the IMember error but adding various Umbraco.Web.XXX cannot clear this one.

What references do have in your controller for your EmailHelper?

EDIT: I fixed the above by adding :

using Umbraco.Web.Composing;

and changing this to:

 UmbracoHelper helper = Current.UmbracoHelper;

Now have an error on

Line 103:            var message = new MailMessage();

So I guess I'm missing more references :S You've probably gathered by now I haven't built a controller before! It's been a steep learning curve but in the last couple days I have learned so so much!!