Hi Peter,

Can you post some more code ?

Dave

Hi Dave,

Here I have my default controller.

 public DefaultController(
        ILogger<DefaultController> logger,
        IPublishedContentQuery publishedContentQuery,
        ICompositeViewEngine compositeViewEngine, 
        IUmbracoContextAccessor umbracoContextAccessor,
        ILayoutFactory layoutFactory) 
        : base(logger, compositeViewEngine, umbracoContextAccessor)
    {
        _logger = logger;
        _publishedContentQuery = publishedContentQuery;
        _layoutFactory = layoutFactory;

        SetLayoutViewModelAsync();
    }

    //public override IActionResult Index()
    //{
    //    SetLayoutViewModelAsync();

    //    return CurrentTemplate(CurrentPage);
    //}

    private async Task SetLayoutViewModelAsync()
    {
        if (ViewData[LayoutViewModelKey] == null)
        {
            var publishedContent = TryGetPublishedContent();

            if (publishedContent != null)
            {
                ViewData[LayoutViewModelKey] = await _layoutFactory?.ConstructAsync(publishedContent);
            }
        }
    }

In the constructor there is the SetLayoutViewModelAsync() method, this is responsible for nothing more then collecting usefull properties,settings etc.

public async Task<Layout> ConstructAsync(IPublishedContent content)
    {
        var website = content.GetHome(); //Umbraco's root node
        var currentUser = _backofficeUserAccessor.BackofficeUser;
        var currentMember = await _memberManager.GetCurrentMemberAsync();

        return new Layout
        {
            Content = content,
            User = currentUser.IsAuthenticated 
            ? new Models.Structs.BackOfficeUser()
                {
                    Id = currentUser.FindFirstValue(ClaimTypes.NameIdentifier).TryParse(null),
                    UserName = currentUser?.Name ?? string.Empty,
                    Roles = _backofficeUserAccessor.GetAllRoles(),
                    IsAuthenticated = currentUser.IsAuthenticated,
                    IsAdmin = _backofficeUserAccessor.UserIsAdmin(),
                } : null,
            Member = currentMember,
        };
    }

Now I have another controller, for example LoginController, where I use access the ViewData in Razor.

 var Model = (Layout)ViewData[DefaultController.LayoutViewModelKey];

But this is always null.

In case I call the method in base from Index, its working as expected. But I do not want to think about that.

[HttpGet]
    public IActionResult Index()
    {
        base.SetLayoutViewModelAsync(); }

Why ViewData is null even when I call base.SetLayoutViewModelAsync() in the LoginControlle ctor?

Long strory, short; This concept is running fine in U8 and took it in a just setten up U9 project and cannot get it work jet. 👍

Hi Peter,

Is your login controller inheriting from your DefaultController ?

Dave

Inherting from RenderController is what you need to do. Mixing Surface and RenderControllers is not a good idea. See https://our.umbraco.com/forum/umbraco-7/using-umbraco-7/73791-getting-an-error-with-custom-routes-could-not-find-a-surface-controller-route-in-the-routetable-for-controller-name-authorization#comment-236516 for some more background.

Do you have a doctype called Login ?

Dave

In that case I will keep the RenderController, good point!

I have the Login doctype, debugging in LoginController is also working well.

Do you call the base constructor from the constructor of your login controller ?

Dave

Yes, here is the Login controller:

public class LoginController : DefaultController
{
    public LoginController(
        ILogger<LoginController> logger,
        IPublishedContentQuery publishedContentQuery,
        ICompositeViewEngine compositeViewEngine,
        IUmbracoContextAccessor umbracoContextAccessor,
        ILayoutFactory layoutFactory)
        : base(logger, publishedContentQuery, compositeViewEngine, umbracoContextAccessor, layoutFactory)
    {

    }

    [HttpGet]
    public override IActionResult Index()
    {
        return base.Index();
    }
}

If you put a debugger in the defaultController constructor. Does that hit when you call the login controller ?

Dave

Yes, that is working well as expected.

Hi Peter,

That is strange. I will try to reproduce this today.

Dave

Hi Dave,

I just created an new solution and created the same state. https://github.com/PetervandenDungen/Umbraco9.LayoutFactory

Peter

Thanks for the confirmation. 👍

Peter

is working on a reply...