Hi Joe,

I have been doing this since "forever" (i.e. essentially using the crop definition for the aspect-ratio), so I'd say it's a bug if it's indeed giving you the same image, regardless of the width/height params.

However - and I'm not too familiar with the new engine (ImageSharp) but - I know that the one used in v7—v9 (ImageProcessor) did have some config options that could be affecting this (e.g. there's a way to prevent generating images above a maximum size and that could be the problem you're having, as your 2x image is quite large (4000+ px).

Could you maybe try generating a couple of smaller images (e.g. 500px and 1000px) and see what you get there?

Otherwise, I'd suggest you log an issue on the issue tracker on GitHub.

/Chriztian

Thank you Chriztian,

I have parked this temporarily in favour of getting more of the core of this site developed, but I will try out some smaller resamples and also a smaller source image (in case it's over the limit it feels safe to load in for resampling) and see how it goes.

Reassuring to hear you've also used this technique before as well so I am at least not trying something illogical or unsupported.

Cheers,

Joe

Recently returned to try and resolve this one with a fresh head, unfortunately I still think this is a bug. Just looking to see if anyone has any final 'gotchas' and if not I will raise as a bug against Umbraco CMS via GitHub Issue Tracker.

Firstly, I was noticing some issues when testing with regards to the generated URL params being appended with HTML/URL encoded & as opposed to just &. I have a feeling this might have cause all or at least all but the first URL params from being processed correctly, just to rule this out I have set the final IUrlHelper.GetCropUrl() param to htmlEncode = false.

This has left me with my Media Picker configured to enable focal point and define two crop aliases of landscape (16:9) and portrait (9:16) with the width/heights defined being the largest I will ever need these images:

I then have 4x lines of code making use of GetCropUrl() using the LocalCrops defined on my banner image(s) selected for each page of my site e.g.:

MediaWithCrops bannerImage = Model.Value<MediaWithCrops>("bannerImage");
bannerImageUrlPortrait1x = Url.GetCropUrl(bannerImage.LocalCrops, "portrait", 720, 1280, null, ImageCropMode.Crop, null, false, false, null, null, false);
bannerImageUrlPortrait2x = Url.GetCropUrl(bannerImage.LocalCrops, "portrait", 1440, 2560, null, ImageCropMode.Crop, null, false, false, null, null, false);
bannerImageUrlLandscape1x = Url.GetCropUrl(bannerImage.LocalCrops, "landscape", 2560, 1440, null, ImageCropMode.Crop, null, false, false, null, null, false);
bannerImageUrlLandscape2x = Url.GetCropUrl(bannerImage.LocalCrops, "landscape", 5120, 2880, null, ImageCropMode.Crop, null, false, false, null, null, false);

Note that the 2x versions use the exact same width/heights defined in the crop definitions, the 1x are 50% of the crop definition values (so same orientation and aspect ratio, but half the size).

What I have found, is that this seems to work if and only if, I manually select a non-standard crop preset for each of my crop definitions e.g. opening the 'Landscape 16:9 (Max)' and 'Portrait 9:16 (Max)' presets and dragging the cropped area to anything but the default (even if just a couple of pixels off). I have exaggerated this to be top and right in the below:

In this case, I get the resized images back at both the aspect ratios and width/heights as expected.

However, if I either:

• Leave the focal point in its default, centred, position and do not adjust the crop presets at all; or
• Manually update the focal point, but leave the crop presets in their automatically adjusted position based on this new focal point (e.g. without opening and dragging them at all)

then in both cases my Landscape 16:9 @ 2x resized image fails to resize as requested and instead gives me a square 1:1 image where width and height are both 2880px (the height I requested has been used for both dimensions) e.g.:

Landscape DPI 2x: https://localhost:54302/media/2s4bjzid/6000x6000-banner-test.jpeg?width=5120&height=2880

Returned Dimensions: 2880 x 2880px

Outcome: Ignored specified width and aspect ratio (infered from cropAlias) and made square using specified height for both dimension

Landscape DPI 1x: https://localhost:54302/media/2s4bjzid/6000x6000-banner-test.jpeg?width=2560&height=1440

Returned Dimensions: 2560 x 1440px

Outcome: As expected

Portrait DPI 2x: https://localhost:54302/media/2s4bjzid/6000x6000-banner-test.jpeg?width=1440&height=2560

Returned Dimensions: 1440 x 2560px (correct)

Outcome: As expected

Portrait DPI 1x: https://localhost:54302/media/2s4bjzid/6000x6000-banner-test.jpeg?width=720&height=1280

Returned Dimensions: 720 x 1280px (correct)

Outcome: As expected

I initially thought this might be related to an undocumented maximum resize value of 5000px, as my landscape 2x crop is the only one which breaches that size however, I am able to resize to 5120x2880px successfully as long as I manual select my crop preset (as I mention above), also, I have updated any references in appsettings.json I can find which references max width/height for image resizing, being:

  "umbracoImaging": {
    "Resize": {
      "MaxWidth": 6500,
      "MaxHeight": 6500
    }
  },
  "UmbracoCmsCoreConfigurationModelsImagingResizeSettings": {
    "MaxWidth": 6500,
    "MaxHeight": 6500
  }

I'm not sure if there are others?

Finally, as a bit of an aside, I also find it odd (presumably as per design, but seems wrong to me) that with my large 6000x6000px test image, I am not able to select a partial crop of say the centre of my source image for my 'Portrait 9:16 (Max)' crop alias. Instead, the entire 6000x6000px source image is resized down to the larger of the two crop definitions dimentions (in this case, height at 2560px) and then I can select the slither of this I want e.g.:

Any support or suggestions welcomed. At the moment I am left telling my users "Make sure you manually select a crop preset, even if that's just dragging the default 1px left/right or up/down" which is just going to be forgotten/ignored

is working on a reply...