The docs for custom routes has my head spinning. I am upgrading a V8 site to V10 and trying to add simple parameters to the request for use in a custom controller (route hijacking style). Give this a read and tell me that I am crazy: https://our.umbraco.com/documentation/reference/routing/custom-routes/

In Umbraco 8 I had my code in this component:

public class RegisterCustomRoutesComponent : IComponent
{
    public void Initialize()
    {
        // Custom route to RegistrationPage contoller which will use a node with a specific ID as the
        // IPublishedContent for the current rendering page
        RouteTable.Routes.MapUmbracoRoute("RegistrationRoute", "account/register/{aid}/{rid}", new
        {
            controller = "RegistrationPage", //omitted "controller" suffix
            action ="Index", //Controller action
            aid = UrlParameter.Optional, 
            rid = UrlParameter.Optional, 
        }, new UmbracoVirtualNodeByUdiRouteHandler(new GuidUdi(Constants.UdiEntityType.Document, new Guid("1af61142-46e4-4b18-825b-5f2a7c358433"))));

    }

    public void Terminate()
    {
    }

}

This worked great.

In U9 and 10 no more components. The close as I can get currently is extending the UmbracoApplicationBuilderExtensions with a class that returns IUmbracoEndpointBuilderContext UseCustomRoutes to handle custom routes that is called from startup.cs:

 app.UseUmbraco()
            .WithMiddleware(u =>
            {
                u.UseBackOffice();
                u.UseWebsite();
            })
            .WithEndpoints(u =>
            {
                u.UseInstallerEndpoints();
                u.UseBackOfficeEndpoints();
                u.UseWebsiteEndpoints();
                u.UseCustomRoutes();//JA custom UmbracoApplicationBuilderExtension
            });

Here is the extension class:

using Microsoft.AspNetCore.Builder;
using System.Web.Mvc;
using Umbraco.Cms.Core.Models.PublishedContent;
using Umbraco.Cms.Web.Common.ApplicationBuilder;
using Umbraco.Extensions;
using Microsoft.AspNetCore.Mvc.Filters;
using Umbraco.Cms.Core.Web;
using ActionExecutingContext = Microsoft.AspNetCore.Mvc.Filters.ActionExecutingContext;
using Microsoft.Extensions.DependencyInjection;

namespace Protean.Core.Configuration
{
    public static class UmbracoApplicationBuilderExtensions
    {
        public static IUmbracoEndpointBuilderContext UseCustomRoutes(this IUmbracoEndpointBuilderContext app)
        {
            if (!app.RuntimeState.UmbracoCanBoot())
            {
                return app;
            }

            app.EndpointRouteBuilder.MapControllerRoute(
            "Registration Page Controller",
            "/account/register/{aid}/{rid}",
            new
            {
                Controller = "RegistrationPage",
                Action = "Index",
                aid = UrlParameter.Optional, 
                rid = UrlParameter.Optional, 
            }).ForUmbracoPage(FindRegistrationPage);

            return app;



        }
        private static IPublishedContent FindRegistrationPage(ActionExecutingContext actionExecutingContext)
        {
            var umbracoContextAccessor = actionExecutingContext.HttpContext.RequestServices.GetRequiredService<IUmbracoContextAccessor>();
            var umbracoContext = umbracoContextAccessor.GetRequiredUmbracoContext();
            return umbracoContext.Content.GetById(new Guid("1af61142-46e4-4b18-825b-5f2a7c358433"));
        }
    }
}

Debugging is not telling me anything. It appears that the route is added to the route table, however the controller is never invoked. FYI This is not a vanilla route, just want to add to parameters to the request parameters for a known umbraco page (route hijacking) that can be then digested by the controller...

Any thoughts or suggestions would be really great...thanks in advance!

Jamie