Hi Henrik

I think what you need to create is a 'service', an independent piece of code that does your stuff, that can be called from a SurfaceController or from your Scheduled Task.

It would have a constructor that takes in ONLY the dependencies required to achieve the task - so probably wouldn't need all the dependencies that a SurfaceController needs and so would be easier to create in your Scheduled Task.

There is quite a good article about Services and Helpers here: https://our.umbraco.com/documentation/implementation/Services/ (that is long but has examples!!! - if you look at how the 'SiteService' works in the example, it shows you how to create an Interface, an implementation of the interface and the registration of the service with dependency injection which allows you to 'inject it' into places like your SurfaceController...

eg

  public class DownloadingFeedService : IDownloadingFeedService {
// if your feed needs to query umbraco you'll need the factory to get access to the Umbraco Context
  private readonly IUmbracoContextFactory _umbracoContextFactory;

        public DownloadingFeedService(IUmbracoContextFactory umbracoContextFactory)
        {
            _umbracoContextFactory = umbracoContextFactory;
        }

        public async Task<string> DoStuff(){
// do stuff
}

}

Then in a composer or your StartUp file you can register your service

builder.Services.AddSingleton<IDownloadingFeedService, DownloadingFeedService>();

Then you'll be able to inject into your SurfaceController:

private readonly IDownloadFeedService _downloadFeedService;
public FeedController(IUmbracoContextAccessor umbracoContextAccessor,
         IUmbracoDatabaseFactory databaseFactory,
         ServiceContext services,
         AppCaches appCaches,
         IProfilingLogger profilingLogger,
         IPublishedUrlProvider publishedUrlProvider, IDownloadFeedService downloadFeedService)
         : base(umbracoContextAccessor, databaseFactory, services, appCaches, profilingLogger, publishedUrlProvider)
    {
_downloadFeedService = downloadFeedService;
    }

    public async Task<string> DownloadFeed()
    {
       _return await downloadFeedService.DoStuff();
     }

or at least that is the gist of it!

regards

Marc

Hi Henrik

If it's a scheduled task you need to run, do you need the scheduling aspect to occur 'outside fo Umbraco'?

Because you could use the inbuilt RecurringHostedService functionality?

There is an example here in the docs:

https://our.umbraco.com/documentation/reference/Scheduling/

You can see they've injected the IContentService into the task, you can do the same with IMediaService to be able to perform your CRUD

regards

marc

Hi Henrik

I reckon, that you could inject them too?

SchedulingUpdateCases : RecurringHostedServiceBase

private readonly _MediaFileManager;
private readonly _MediaUrlGeneratorCollection;

 public SchedulingUpdateCases(
           IRuntimeState runtimeState,
           IContentService contentService,
           IMediaService mediaService,
           IServerRoleAccessor serverRoleAccessor,
           IProfilingLogger profilingLogger,
           ILogger<SchedulingUpdateCases> logger,
           IScopeProvider scopeProvider,
           MediaFileManager mediaFileManager, 
           MediaUrlGeneratorCollection mediaUrlGeneratorCollection) : base(logger, HowOftenWeRepeat, DelayBeforeWeStart)
        {
            _runtimeState = runtimeState;
            _contentService = contentService;
            _mediaService = mediaService;
            _serverRoleAccessor = serverRoleAccessor;
            _profilingLogger = profilingLogger;
            _logger = logger;
            _scopeProvider = scopeProvider;
            _mediaFileManager = mediaFileManager;
            _mediaUrlGeneratorCollection = mediaUrlGeneratorCollection;

        }

hopefully...

regards

Marc

is working on a reply...