I believe there's a separate switch case for 2FA that is what you're looking for:

        if (result.Succeeded)
        {
        (…)
        }
        if (result.RequiresTwoFactor)
        {
// complete your 2FA process here
        }

Ah, cheers mate - i misread where you were in the flow and threw out the thought before heading into a meeting. I figured an response might be better than a silent thread! I see that the linked documentation is short of exhaustive.

The last time I implemented 2FA for membership was on v9 so it's been a little while. I don't have a running copy on this machine but do still have code.

Looking at Microsoft.AspNetCore.Identity.SignInResult there are other returns that give additional reasoning as to why false == result.Succeeded What does the debugger say when you attach and step through the code?

Perhaps the genericized snippit (again, for v9 - should that be relevant(?)) that follows will help guide you to success:

public async Task<IActionResult> Verify2FACode([Bind(Prefix = "AwesomePersonGroupVerify2FaCodeModel")]AwesomePersonGroupVerify2FaCodeModel model)
{
    var user = await _memberSignInManagerExternalLogins.GetTwoFactorAuthenticationUserAsync();
    if (null == user)
    {
        _logger.LogWarning("Membership: (Verify2FACode) - Member not logged in");
        Redirect(_siteNodeMappingService.GetAwesomePersonGroupSection().Url());
    }

    if (ModelState.IsValid)
    {
        SignInResult result = await _memberSignInManagerExternalLogins.TwoFactorSignInAsync(model.Provider, model.Code, model.IsPersistent, model.RememberClient);
        var currentMember = await _memberManager.GetCurrentMemberAsync();

        if (result.Succeeded)
        {               
            // Ensure member has 2FA auth established
            var foundMemberResult = await _memberManager.FindByNameAsync(currentMember.UserName);
            if  (foundMemberResult?.TwoFactorEnabled == false)
            {
                var AwesomePersonGroupGroup = _memberService.GetMembersByGroup("AwesomePersonGroup");
                var AwesomePersonGroupGroupList = _memberService.GetMembersByGroup("AwesomePersonGroup").ToList();

                // Ensure this member 
                if (AwesomePersonGroupGroupList.Any(x => x.Key.Equals(foundMemberResult.Key)))
                {
                    _memberService.AssignRole(foundMemberResult.UserName, "AwesomePersonGroup");
                }
            }
            _logger.LogInformation("Membership: (Verify2FACode) - success - {AwesomePersonGroup}", user.UserName);
             RedirectToCurrentUmbracoPage();
        }
        else if (result.IsLockedOut)
        {
            _logger.LogWarning("Membership: (Verify2FACode) - AwesomePersonGroup is locked out  - {AwesomePersonGroup}", user.UserName);
            ModelState.AddModelError(nameof(AwesomePersonGroupVerify2FaCodeModel.Code), "AwesomePersonGroup is locked out");
        }
        else if (result.IsNotAllowed)
        {
            _logger.LogWarning("Membership: (Verify2FACode) - AwesomePersonGroup is not allowed - {AwesomePersonGroup}", user.UserName);
            ModelState.AddModelError(nameof(AwesomePersonGroupVerify2FaCodeModel.Code), "AwesomePersonGroup is not allowed");
        }
        else
        {
            _logger.LogWarning("Membership: (Verify2FACode) - Invalid code - {AwesomePersonGroup}", user.UserName);
            ModelState.AddModelError(nameof(AwesomePersonGroupVerify2FaCodeModel.Code), "Invalid code");
        }
    }
    else
    {
        _logger.LogWarning("Membership: (Verify2FACode) - Invalid ModelState - {AwesomePersonGroup}", user.UserName);
    }

    //We need to set this, to ensure we show the 2fa login page
    var providerNames = await _twoFactorLoginService.GetEnabledTwoFactorProviderNamesAsync(user.Key);
    ViewData.SetTwoFactorProviderNames(providerNames);

    return CurrentUmbracoPage();
}

Looks like I may have jumped the gun.

Yes all is logging in and with Two Facter Authentication and the surgested alternative version of code above works perfect as well

Except:

The member has some critical values

Member Name at the top 1. Login = [email protected] 2. Email = [email protected] 3. Password = ????? 4. Two Factor Authentication = true

Now this logins in fine with Two factor

but if we change the Login value to a say "Joe Bloggs"

we then need to use "Joe Bloggs" in the username field Perfect thats what we want but

SignInResult loginResult = await _memberSignInManager.PasswordSignInAsync(model.Username, model.Password, false, true);

Results in a Succeeded but should be a RequiresTwoFactor

return the Login to "[email protected]" and two factor works again

Anybody come across this

is working on a reply...