Hi Lefteris,

Did you check configs ? Maybe some nuget made some changes in your config.

Thanks

All configs checked and are ok.

Tried all, build rebuild etc. I reverted back to 7.4.1 and hijacked controllers work ok.

Also for the new test project I made starting at 7.4.2 that didn't worked as well, I downgraded it to 7.4.1 and works.

The render models I create are like :

public class TextPageModel : RenderModel
{
    public TextPageModel()
       : base(UmbracoContext.Current.PublishedContentRequest.PublishedContent,UmbracoContext.Current.PublishedContentRequest.Culture)
    {

    }
    public string CustomProperty { get; set; }
}

And the RenderMvcController like:

public class TextPageController : RenderMvcController
{
    // GET: Home
    public ActionResult textPage(TextPageModel model)
    {

        model.CustomProperty="Yeah!";
        return CurrentTemplate(model);
    }
}

of course I user DocType / ViewName auto route. Works nicely in 7.4.1.

Is this a bug of 7.4.2?

Hi, I've got the same problem after upgrading to 7.4.2.

I assume it is a full bug in 7.4.2

Anyone else tested hijacked controllers?

As it turns out i think this is the one scenario we didn't test for: A sub-classed RenderModel type being bound to a controller's action parameter. I'd actually recommend not doing this as it's not quite best practices and relies on Singletons (i.e. not unit testable)

There's a few work around's you can do:

• Leave your controller's action parameter as type: RenderModel and create your custom model inside of your MVC Action
  • this is actually nicer anyways because you don't really want to rely on Singleton's in your models constructor - this makes it near impossible to unit test. You'd be better off using the given RenderModel 's values in the Action parameter to constructor your custom model.
• Create a custom ModelBinder that inherits from DefaultModelBinder and implements IModelBinderProvider then in the IModelBinder GetBinder(Type modelType) method you would be targeting your model type explicitly like: return modelType == typeof (TextPageModel);
  • You can then assign this model binder directly using the [ModelBinder] attribute on your Action parameter, or you can assign it globally during startup.

I'll create an issue on the tracker for 7.4.3 to fix this but these are suitable work-arounds for the time being.

http://issues.umbraco.org/issue/U4-8216

Hey Shannon, thank you for your reply. Is there any possibility to create a quick fix for 7.4.2?

I think many devs have implemented RenderModels such way and would face pain when the try to upgrade to 7.4.2 (most reason of the true/false issue of 7.4.1).

Same problem here, I can confirm that switching from

public ActionResult(CustomRenderModel model) 
{ 
    return View(model)
} 

To

public ActionResult(RenderModel model)
{ 
    var myModel = new CustomRenderModel();
    return View(myModel)
} 

Has fixed it for me. Thanks!

An easy fix for this is to grab the fixed RenderModelBinder from https://raw.githubusercontent.com/umbraco/Umbraco-CMS/cd401f5e37b8517c2a6d39e2746d8295d56ebf92/src/Umbraco.Web/Mvc/RenderModelBinder.cs.

Then rename the class to something unique and give it a different namespace. Then in an ApplicationEventHandler class you remove the faulty RenderModelBinder and add your own instead:

public class Startup : ApplicationEventHandler
{
    protected override void ApplicationStarting(UmbracoApplicationBase umbracoApplication, ApplicationContext applicationContext)
    {
        //Workaround for http://issues.umbraco.org/issue/U4-8216
        var rendermodelbinder = ModelBinderProviders.BinderProviders.FirstOrDefault(x => x.GetType() == typeof(RenderModelBinder));
        ModelBinderProviders.BinderProviders.Remove(rendermodelbinder);
        ModelBinderProviders.BinderProviders.Add(new FixedRenderModelBinder());
    }
}

You can find the nightly build here with the fix: https://ci.appveyor.com/project/Umbraco/umbraco-cms-hs8dx/build/artifacts

We will get 7.4.3 out after the Easter break.

Hi Shannon,

I'm actually in a similar scenario to Asbjørn here, I'm sending form post data to my model, as a result the model is now coming through as null! Changing this to a RenderModel() would obviously lose my custom values passed through...

Any workarounds in this scenario? I'm working more with traditional MVC methods in this scenario.

Thanks for the pointers, Shannon. I shall definitely be changing my code in the future, then - good to know.

Perhaps some docs/tutorials on the interaction of Route Hijacking and SurfaceControllers would be useful? (I knows you guys are busy, of course...)

Have a nice Easter

This is quite an oversight.

Thanks to that blog post by Sebastian, I have no doubt that many people have run into this issue. In order to prevent other developers from the headache I just went through trying to find this thread, this NEEDS to be listed as a breaking change in the release notes for 7.4.2. Especially since what I thought was going to be an easy update turned out to be a pain.

Someone over at Umbraco HQ needs to work on quality control 'cuz this shit is bananas.

Hi there, I wonder if you could help me. I'm new to Umbraco and .net MVC, but was following a tutorial to set up my own route hijacking controller. I ended here up because I was getting the same initial error.

Cannot bind source type Umbraco.Web.Models.RenderModel to model type .....

I reworked my code as Shannon suggested, ie:

public class RSSFeedController : RenderMvcController
{
    // GET: RSSPage
    public ActionResult RssFeed(RenderModel model)
    {
        var rssFeedModel = new RssFeedModel(model.Content);
        rssFeedModel.RssFeed = GetRssFeedItems(model);
        Response.AddHeader("content-type", "text/xml");
        return CurrentTemplate(rssFeedModel);
    }

    private IEnumerable<IPublishedContent> GetRssFeedItems(RenderModel model)
    {
        const int pageSize = 5;
        var posts = model.Content.Children.ToList();
        return posts.OrderByDescending(x => x.CreateDate).Take(pageSize);

    }
}

Except now I get a compilation error in my view:

   CS1061: 'Umbraco.Web.Models.RenderModel' does not contain a definition for 'RssFeed' and no extension method 'RssFeed' accepting a first argument of type 'Umbraco.Web.Models.RenderModel' could be found (are you missing a using directive or an assembly reference?)

at this line:

@foreach (var article in Model.RssFeed)

How do I tell my View to expect an RssFeedModel, and not a standard RenderModel? My RssFeedModel is based on RenderModel:

public class RssFeedModel : RenderModel

    {
        public RssFeedModel(IPublishedContent content) : base(content) { }

        public IEnumerable<IPublishedContent> RssFeed { get; set; }
    }

Thanks in advance for any advice.

Andy

Upgrading to the nightly (v7.4.3build3482) has fixed the issue for me, though it does introduce a ReflectionTypeLoadException in the Developer section of the backoffice. I get this exception on the call for GetNonCoreTypesAssignableFrom.

Hi @Matthew & @Andy,

To fix this you can use the workaround posted above, it will also continue to work after you upgrade because the fix is to ensure that the DefaultModelBinder continues to execute for any sub classes of RenderModel. See above: https://our.umbraco.org/forum/using-umbraco-and-getting-started/75998-update-to-742-all-custom-hijacked-controllers-stopped-working#comment-243220

You can attribute your parameter with the specific model binder:

 public ActionResult Post([ModelBinder(typeof(DefaultModelBinder)]MyViewModel model)

Maybe someone can mark that as fixed so it's obvious what the work around is.

@Matthew if you have steps to reproduce the other error you are getting with the nightly can you please open a ticket with details and steps to reproduce. I haven't seen this error before.

Hi @Shannon, thanks the speedy reply.

My controller now looks like this:

public ActionResult RssFeed([ModelBinder(typeof(DefaultModelBinder))]RssFeedModel model)
{
    /*
    var rssFeedModel = new RssFeedModel(model.Content);
    rssFeedModel.RssFeed = GetRssFeedItems(model);
     * */
    model.RssFeed = GetRssFeedItems(model);
    Response.AddHeader("content-type", "text/xml");
    return CurrentTemplate(model);
}



private IEnumerable<IPublishedContent> GetRssFeedItems(RenderModel model)
{
    const int pageSize = 5;
    var posts = model.Content.Children.ToList();
    return posts.OrderByDescending(x => x.CreateDate).Take(pageSize);

}

But I still get the compile error

Compiler Error Message: CS1061: 'Umbraco.Web.Models.RenderModel' does not contain a definition for 'RssFeed' and no extension method 'RssFeed' accepting a first argument of type 'Umbraco.Web.Models.RenderModel' could be found (are you missing a using directive or an assembly reference?)

Source Error:


Line 16: 
Line 17:      
Line 18:    @foreach (var article in Model.RssFeed)
Line 19:    {
Line 20:       var tease = article.GetPropertyValue<string>("teaserText");

Any thoughts?

Cheers Andy

Hi there,

No this is brand new code - well, new for me, anyway. Actually I was following this tutorial

https://cultiv.nl/blog/whats-this-umbraco-route-hijacking-all-aboutl/

which is by the same guy as that other blog post reference.

I'm going to have to have a sit down with a cup of coffee to work out how I should be using IPublishedContent. Any examples anywhere I can look at?

Thanks again.

Thanks @Shannon and @Sebastiaan. I'll have a look into that.

Sorry, @Sebastiaan I hadn't spotted out you were "the guy" who had written both posts. :-)

I guess if RenderModel is going away in v8 I should look at the IPublishedContent solution anyway, but for the meantime I'll try this. What's the worst that could happen - I build it, it goes live, and we forget all about it...

Cheers Andy

Sorry, meant to come back to this and admit humbly that I'd not spotted that my controller name didn't match with the document type name. Schoolboy error!

@Sebastiaan With your updated code in the blog post and the related gist I fail to see how paging can work

public class BlogOverviewController : RenderMvcController
{
    public ActionResult BlogOverview(RenderModel model)
    {
        var blogOverviewModel = new BlogOverview(model.Content);

        if (blogOverviewModel.Page == 0) // default value for int
            blogOverviewModel.Page = 1;

        // do paging 

        return CurrentTemplate(blogOverviewModel);
    }
}

As you're creating a new BlogOverview, Page is always going to be 0.

The view is passing the page number in the query string and this was previously automatically bound to the model.

Sure, just use Request.Querystring["Page"] for now, I don't know of a better way quickly to fix this some other way.

In MVC & WebApi, query strings are bound to action parameters... that is the very nature of how MVC binds things. You can just add a page parameter to your action. For example, Articulate does paging, it's just a p querystring which gets mapped to an action's parameter:

https://github.com/Shazwazza/Articulate/blob/master/src/Articulate/Controllers/ArticulateTagsController.cs#L47

I always suggest doing some very simple MVC sites and tutorials outside of Umbraco since all of this stuff is covered and is quite a fundamental part of MVC.

Thanks Shannon, I was pointing out that the updated blog post / gist are not correct as stated above.

Ideally they need updated again so that paging still works i.e. something like :-

public ActionResult BlogOverview(RenderModel model, int? page)
    {
        var blogOverviewModel = new BlogOverview(model.Content);
        if (page.HasValue) blogOverviewModel.Page = page.Value;

        blogOverviewModel.BlogPosts = GetPagedBlogPosts(blogOverviewModel);

        return CurrentTemplate(blogOverviewModel);
    }

I'm glad I stumbled on this as I was fumbling around for hours trying to figure out what should be relatively simple.

Coming from a vanilla MVC world, it's very common:

1. Design your model
2. Create a GET controller method that returns a new() instance of that model
3. Write a view that renders an appropriate form template using Razor helpers like @Html.TextBoxFor() etc
4. Post that data to a POST controller method (often with the same name, just the [HttpPost] attribute) that accepts an object of type (model). MVC ModelBinding takes care of the magic.

So given that the Umbraco docs tell us to subclass RenderModel for returning custom views, why wouldn't we then proceed to just post data back and rely on modelbinding to do the heavy lifting?

And yes, the example posted is clearly wrong because there's no model binding going on anywhere in there and so it never actually reads the page parameter. Having to manually bind model parameters is just... ew.

Now that I see we're supposed to use Surface controllers for posting data, and there's a whole Html.BeginUmbracoForm, I will have to adjust all my code, but man, if the documentation and all the code examples for RenderModel would just say "GET ONLY, NOT FOR POSTING, SEE ..." you might be able to avoid some of this confusion in the future.

On https://umbraco.com/follow-us/blog-archive/2014/1/27/a-practical-example-of-route-hijacking-in-umbraco/

The last code block has a controller. This controller method never binds the input search parameter. A possible fix is this (changed method signature, added line to assign page; although I'd probably make a new constructor for the model if I was doing this from scratch). I also then removed the assignment that checks for page 0, since the default parameter handles it.

public ActionResult BlogOverview(RenderModel model, int page = 1)
{
    var blogOverviewModel = new BlogOverview(model.Content) { Page = page };

     // do paging 
     return CurrentTemplate(blogOverviewModel);
    }

If I have time later, I'll submit a bug on the documentation, but as is, I'm behind several hours from trying to figure out how to make a simple GET-POST-REDIRECT custom search form.

I saw it eventually; it just wasn't the first things I found in a search.

What I really want to see is documentation on how to use a custom model with model binding in a GET scenario. I shouldn't have to POST for a search form (read operations should use GET); and I shouldn't have to manually wire up all the complex search parameters that I have.

I just finished writing some very basic code, and I'm running into trouble where something is not model binding correctly.

I took a simple

public class SearchModel: RenderModel {
   [Required]
   public string Keyword { get; set; }
}


public class SearchSurfaceController : SurfaceController
{
    public ActionResult DoSearch(SearchModel m)
    {
    ... 
    } 
}

View (called correctly on GET)

  @using (Html.BeginUmbracoForm<SearchSurfaceController>("DoSearch", null, new { @class="form-horizontal"}))
{
        <div class="form-group">
            <div class="col-sm-4 text-right">
                @Html.LabelFor(x => x.SearchTerm, new { @class = "control-label" })
            </div>
            <div class="col-sm-8">
                @Html.TextBoxFor(x => x.SearchTerm, new { @class = "form-control" })
            </div>
</div>
        <div class="form-group">
            <div class="col-sm-offset-4"><button type="submit" class="btn btn-default">Search</button></div>
</div> 
 }

And I can put a breakpoint on DoSearch(); it does get routed there, but the search term is not bound correctly. It's always null, so ModelState.IsValid is false. Request.Form["SearchTerm"] has the correct value; so it's just model binding that's failing. Aggravating.

The keyword/searchTerm was just copy & paste laziness; I was trying to abstract out my code and make it as simple as possible, forgot to change one example.

I know how to write basic HTML forms and MVC forms; I have 6+ years of MVC development, so it's not my first rodeo. I don't want to have to put in 10 extra parameters to a method. That's why we have models and model binding!

If I want to make a search form with 10 different ways to search, I should be able to just model-bind, and to write a good Razor form, I want to use Razor helpers like LabelFor and TextBoxFor, so that I have proper intellisense and so that they will model-bind when I submit the form to my handler (which should be agnostic whether it's GET or POST).

Yes, you can add 10 different parameters to the ActionMethod, but that's very bad MVC practice! What if you add a new parameter to your model? Now you have to update the ActionMethod. Normally you'd just update the service layer / function call that's doing something with the data, but now you have to tell the controller to expect new data... ugly.

Hi, Sorry about posting on that again. I just need to have a custom Model to fill up the page with more data. Not for passing data back to the controller. I try to be "more umbraco way" and follow Shannon post.

I finally get: Controller:

public class StoreController : RenderMvcController
{
    public ActionResult Store(RenderModel model)
    {
        var storeModel = new StoreModel(model.Content);

        // adding some stuff

        return CurrentTemplate(storeModel);
    }
}

Model

public class StoreModel: RenderModel
{
    public StoreModel(IPublishedContent content) : base(content) { }


    public int Page { get; set; }
}

And in my page:

@using umbLVC2.models @inherits Umbraco.Web.Mvc.UmbracoViewPage

My umbraco version is at 7.3.1, but I still get the error: Cannot bind source type Umbraco.Web.Models.RenderModel to model type umbLVC2.models.StoreModel

I am lost... ;-) Any suggestion?

Hello,

I've been stuck the entire day on the same problem. I get that this isn't the correct way of using RenderModel, all I want to do is to insert dynamic data from my model into the view.

ATM I have thos code:

Model:

public class VerzoekIndienenModel : RenderModel
{
    public IEnumerable<string> Project { get; set; }
    public IEnumerable<string> Categorie { get; set; }
    public List<string> Test { get; set; }
    public string TestString { get; set; }

    public VerzoekIndienenModel(IPublishedContent content, CultureInfo culture) 
        : base(content, culture)
    {}
}

Controller:

 public class VerzoekIndienenController : RenderMvcController
{
public override ActionResult Index(RenderModel model)
    {
        //throw new Exception("bang");
        var vmodel = new VerzoekIndienenModel(model.Content, model.CurrentCulture);
        vmodel.TestString = "test";
        return CurrentTemplate(vmodel);
    }
}

View:

     @inherits UmbracoViewPage<VerzoekIndienenModel>
@{
    Layout = "Master.cshtml";
}
@{
}

<body>
HTML STUFF
</body>

Can anyone help me? Thanks in advance.

Hey, I have the problem that I'm calling a partial view

@inherits Umbraco.Web.Mvc.UmbracoViewPage<UmbracoGitHubReportViewer.Models.ReportSettingsModel>

and additionally I have a hijacked controller

public class SSRSReportController : RenderMvcController
{
    public override ActionResult Index(Umbraco.Web.Models.RenderModel model)
    { ..

and I call it like this

switch (docTypeAlias)
        {
            case "ssrsreport":
                <h1>Textpage for Reports</h1>                                
                @Html.Partial("SSRSReport", new UmbracoGitHubReportViewer.Models.ReportSettingsModel(@component));

            break;
        }

The Controller is never called !!!

So Route hijacking is not possible for Partial Views ?

is working on a reply...