Hi Guys,

My Problem is that when I am trying to use custom Routes, when trying to access the CurrentPage it is throwing the above error.

For some reason, when using custom Routes, when goes back to the surface controller, the CurrentPage is not accessible.

Any help would be much appreciated.

Thank you

Kind Regards

Hi Guys,

I essentially have the same problem as Simon, that when I use custom routes, the current page property throws an invalid operation exception. Is there a way to set the current page when routing to the custom page by using the code below.

Here is my custom route:

public class CustomRoutesApplicationEventHandler : ApplicationEventHandler
{
    protected override void ApplicationStarted(UmbracoApplicationBase umbracoApplication,
        ApplicationContext applicationContext)
    {
        RouteTable.Routes.MapUmbracoRoute
            (
                DatabaseConstantValues.PropertiesSearchCustomRouteName,
                "properties/{" + DatabaseConstantValues.PropertyCategoryRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyRegionRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyLocalityRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyTypeRouteParamName + "}/",
                new
                {
                    controller = "Properties",
                    action = "PropertiesSearch"
                },
                new UmbracoVirtualNodeByIdRouteHandler(ConstantValues.PropertiesPageId)

            );
    }
}

Thanks for any help in advance.

Kind Regards

What are you trying to acomplish?

We have a service routing for the methods we want available outside umbraco but for all other stuff we use route hijacking. Both ways work, but it looks like you want to combine these two?

Frans

You can check this out. If you want to create Custom Routes in Umbraco. Here is the link of article http://maffrigby.com/using-custom-routes-in-umbraco/. May be by this way you can short out your problem.

Hi Simon,

Is your controller inheriting from SurfaceController or RenderMvcController.

Virtual routes don't work for Surface controllers.

Maybe you paste the code of your controller as well ? We use virtual routes quite often and never have issues with it.

Dave

Why Don't you Hijack the route on the page by having a controller inheriting the RenderMvcController with the name of the document type and use that to get the content you need? This leaves the routing intact and you can append all the info you want to the model.

https://our.umbraco.org/documentation/reference/routing/custom-controllers

Hi Dave,

Sorry for the long wait. Here is a detailed process of what I am trying to accomplish:

This code used to route to the properties page:

public class CustomRoutesApplicationEventHandler : ApplicationEventHandler
{
    protected override void ApplicationStarted(UmbracoApplicationBase umbracoApplication,
        ApplicationContext applicationContext)
    {
        RouteTable.Routes.MapUmbracoRoute
            (
                DatabaseConstantValues.PropertiesSearchCustomRouteName,
                "properties/{" + DatabaseConstantValues.PropertyCategoryRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyRegionRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyLocalityRouteParamName + "}/{" +
                DatabaseConstantValues.PropertyTypeRouteParamName + "}/",
                new
                {
                    controller = "Properties",
                    action = "PropertiesSearch"
                },
                new UmbracoVirtualNodeByIdRouteHandler(ConstantValues.PropertiesPageId)

            );
    }
}

This is the controller which is used to handle the routed page, it is only creating a master page model and returning it to the view:

public partial class PropertiesController : RenderMvcController
{
    private readonly IUmbracoControllerWrapperService _umbracoControllerWrapperService;
    private readonly IMasterModelService _masterModelService;

    public PropertiesController(
        IUmbracoControllerWrapperService umbracoControllerWrapperService,
        IMasterModelService masterModelService)
    {

        _masterModelService = masterModelService;
        _umbracoControllerWrapperService = umbracoControllerWrapperService;
    }

    public virtual ActionResult PropertiesSearch(
        RenderModel model,
        string category,
        string type,
        string region,
        string locality,
        decimal? priceFrom,
        decimal? priceTo,
        int? amountOfBedrooms,
        string interval,
        string propertyFeatures,
        int? page,
        int? show,
        int? sort,
        int? popularSearchId)
    {
        var umbraco = _umbracoControllerWrapperService.GetUmbracoHelperForUmbracoController(this);
        var mastermodel = _masterModelService.CreateMasterModel(umbraco, model.Content);
        return View(MVC.Properties.Views.PropertiesListingPage, mastermodel);
    }
}

This is the view used. The problem occurs in the layout which makes use of a child action method that requires the current page:

@inherits Umbraco.Web.Mvc.UmbracoViewPage<RemaxLettings.Code.Models.MasterModel<RemaxLettings.Code.Models.Property.PropertyListingPageModel>> @{
Layout = "/Views/umbPagesLayout.cshtml";}

I am using this action which is called in the layout umbPagesLayout.cshtml:

@Html.Action("RenderStyles", "ScriptsAndStyles", true)

This is the method which is causing the invalid operation exception when referencing the current page:

    public virtual PartialViewResult RenderScripts()
    {
        var scriptAndStylesModel = new ScriptsAndStyles()
        {
            CurrentPageId =  CurrentPage.Id,
            DocumentTypeAlias = CurrentPage.DocumentTypeAlias
        };

        return PartialView(MVC.Partials.Views.Common._scripts, scriptAndStylesModel);
    }

Thanks for your help,

Alex

Dave -- you d'man.

Although the solution from Dave works, changing the code to use AssignedContentItem instead of CurrentPage might not always be possible...

You can also just define the missing Umbraco route definition in the UmbracoVirtualNodeRouteHandler:

protected override void PreparePublishedContentRequest(PublishedContentRequest publishedContentRequest)
{
    // Add route definition (required in SurfaceController to get the current page)
    var requestContext = publishedContentRequest.RoutingContext.UmbracoContext.HttpContext.Request.RequestContext;
    requestContext.RouteData.DataTokens[global::Umbraco.Core.Constants.Web.UmbracoRouteDefinitionDataToken] = new RouteDefinition()
    {
        ActionName = requestContext.RouteData.GetRequiredString("action"),
        ControllerName = requestContext.RouteData.GetRequiredString("controller"),
        PublishedContentRequest = publishedContentRequest
    };

    base.PreparePublishedContentRequest(publishedContentRequest);
}

is working on a reply...