Changes in umbraco.controllers.js doesn't get reflected in Umbraco
Hi,
I wanted to start to contribute to Umbraco.
I followed the Quick Start guide successfully. Then I looked at the opened issues, found one i want to fix, repro it, found the code responsible, fixed it, built, ran and... the changes I've made are not reflected in the running app. It seems that app is still running the old code. Is there something I'm missing?
P.S.
I've only changed the code in the umbraco.controllers.js, maybe I need to change something, somewhere else?
There's a couple of things that you need to do slightly differently I believe Jakub.
Firstly you've made a change by the sounds of it within Umbraco.Web.UI.Client\build\ - and you shouldn't change these files. They are copies of the ones that get built and copied to the running website. Instead you need to be working within Umbraco.Web.UI.Client\src\.
Then, when you've made the changes there, you need to build the front-end code. The way I do this is to open a command prompt on the Umbraco.Web.UI.Client folder and from there run grunt build. That'll build and copy the files to the running website (under Umbraco.Web.UI).
If you then reload the site (probably making sure you aren't getting cached content - works for me in Chrome if I refresh with the dev tools open and the browser cache disabled) you should see your changes.
Changes in umbraco.controllers.js doesn't get reflected in Umbraco
Hi,
I wanted to start to contribute to Umbraco. I followed the Quick Start guide successfully. Then I looked at the opened issues, found one i want to fix, repro it, found the code responsible, fixed it, built, ran and... the changes I've made are not reflected in the running app. It seems that app is still running the old code. Is there something I'm missing?
P.S. I've only changed the code in the umbraco.controllers.js, maybe I need to change something, somewhere else?
Regards, Jakub
There's a couple of things that you need to do slightly differently I believe Jakub.
Firstly you've made a change by the sounds of it within
Umbraco.Web.UI.Client\build\- and you shouldn't change these files. They are copies of the ones that get built and copied to the running website. Instead you need to be working withinUmbraco.Web.UI.Client\src\.Then, when you've made the changes there, you need to build the front-end code. The way I do this is to open a command prompt on the
Umbraco.Web.UI.Clientfolder and from there rungrunt build. That'll build and copy the files to the running website (underUmbraco.Web.UI).If you then reload the site (probably making sure you aren't getting cached content - works for me in Chrome if I refresh with the dev tools open and the browser cache disabled) you should see your changes.
Cheers
Andy
Thanks a lot, that worked like a charm :)
is working on a reply...
This forum is in read-only mode while we transition to the new forum.
You can continue this topic on the new forum by tapping the "Continue discussion" link below.