The problem is in the old project that I got. There are no custom packages in it except one requiring a rewrite but I think this is not it.
After publishing version 7.13.x , I have to log in and click on the Continue button. Query is executed right after clicking.
I found some trace in the code in the MajorVersion7UpgradeReport.cs file that is not currently in the Umbraco Git repository but is available at the address https://searchcode.com/codesearch/view/95375889/ (lines 84-93).
Now I have no time for this but I will investigate it later.
I was able to get past this by adding controlId to cmsDataType table.
[controlId] [uniqueidentifier] NOT NULL,
It then complained about the mappings
Clearly we missed a major version where this field and whatever mappings were introduced. Since I have no idea what they are used for, or why they were introduced ( I assume because this table lacked a GUID), I attempted to map them manually to the cmsPropertyType table's UniqueID Column which appeared to work momentarily on the installer..
Then the installer told me it was finished and then kicked me back into the installer Step 1. Vicious circle.
Giving up for now, seems we all might be in trouble with this one unless a Core team member can tell us when controlID was introduced, how it's mapped, the intent of it, and then we could maybe script our way through this.
Only other solution I see is to install fresh and attempt to make a package of entire site. Not feasible for us, far too complex of a site.
I have the same problem (https://our.umbraco.com/forum/using-umbraco-and-getting-started/96302-upgrading-7123-to-714-getting-error-during-installation) and others reported it in the forums too. Was hoping by now there would be a solution. Really surprised no-one from Umbraco can be bothered to fix this :(
Yeah I've spent quite a bit of time trying to get around this, had to settle with v7.12.4
I haven't been able to copy the site and database to a local dev environment (which I've seen as a solution in other threads) as the client has strict security policies, so I'm stuck with working remotely on their prod environment which is frustrating too.
Hopefully somebody at Umbraco sees this and has a look.
Not sure if this'll help anyone, but I had this exact problem, and the reason was I was trying to upgrade against a hosted SQL server DB where I didn't have full rights/permissions to the master DB, etc.
SO, what I did was:
Backup the umbraco DB on the hosted server
Restore the umbraco DB on a SQL server I had full admin rights to.
Change the web.config connection string to the newly restored DB.
@Chris Thwaites - Great suggestion about DB permissions. Thank you!
We've been battling several Umbraco sites (Hosted on a Windows Plesk instance), since the Member Registration security issue required CMS version updates to 7.15.1. ControlId issues with all of them.
Once I read your post I took a look, and sure enough, the Umbraco installs that were failing to upgrade were all assigned to [dbo] schema. We changed the schema on all tables to match the authorised DB account and the installs all went through.
Problem with upgrade 7.12.4 to 7.13: Invalid column name 'controlId'
I'm trying to upgrade a project from 7.12.4 to 7.13.3 or 7.13.0, but I keep getting error:
I tried all described solutions but nothing worked. I used SQL Server Profiler and located the problem in query:
I don't have column controlId in table cmsDataType:
I upgraded Umbraco from 7.4.3 to 7.12.4 without major problem. Can I fix this in any simple way?
Hi Amag
Did you upgrade from 7.4.3 directly to 7.12.4?
I think you had to upgrade to 7.6 first.
Alex
Hi Alex.
My current Umbraco is 7.12.4. I got project in old version and I try upgrade it.
Amag
Hi Amag
Did you solve the issue?
Alex
Hi Alex.
Unfortunately not but I have plan to do this :-)
Amag
Hi Amag,
I checked my Umbraco installations. I none of them if see a column controlId on the cmsDataType table.
Also had a look at the migrations (db changes) that are run on umbraco upgrades. I don't see anything that would remove this column.
So my question is? Do you have any custom packages installed. And can you figure out when this query is executed.
Dave
Hi Dave.
The problem is in the old project that I got. There are no custom packages in it except one requiring a rewrite but I think this is not it.
After publishing version 7.13.x , I have to log in and click on the Continue button. Query is executed right after clicking.
I found some trace in the code in the MajorVersion7UpgradeReport.cs file that is not currently in the Umbraco Git repository but is available at the address https://searchcode.com/codesearch/view/95375889/ (lines 84-93).
Now I have no time for this but I will investigate it later.
Amag
I have just tried to upgrade a 7.3.0 to 7.14 and got this error too - Invalid column name 'controlId'.
For those interested here is the full error
2019-04-30 12:27:34,076 [P374600/D3/T33] ERROR Umbraco.Web.Install.Controllers.InstallApiController - An error occurred during installation step Upgrade System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Data.SqlClient.SqlException: Invalid column name 'controlId'. at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action
1 wrapCloseInAction) at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData() at System.Data.SqlClient.SqlDataReader.getMetaData() at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted) at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry) at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method) at System.Data.SqlClient.SqlCommand.ExecuteDbDataReader(CommandBehavior behavior) at System.Data.Common.DbCommand.ExecuteReader(CommandBehavior behavior) at StackExchange.Profiling.Data.ProfiledDbCommand.ExecuteDbDataReader(CommandBehavior behavior) at System.Data.Common.DbCommand.System.Data.IDbCommand.ExecuteReader() at Umbraco.Core.Persistence.PetaPocoCommandExtensions.<>c__DisplayClass5_0.<ExecuteReaderWithRetry>b__0() at Umbraco.Core.Persistence.FaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func) at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteReaderWithRetry(IDbCommand command, RetryPolicy cmdRetryPolicy, RetryPolicy conRetryPolicy) at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteReaderWithRetry(IDbCommand command, RetryPolicy retryPolicy) at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteReaderWithRetry(IDbCommand command) at Umbraco.Core.Persistence.Database._741.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source) at Umbraco.Core.Persistence.Database.Fetch[T](String sql, Object[] args) at Umbraco.Core.Persistence.Database.Fetch[T](Sql sql) at Umbraco.Web.Install.InstallSteps.MajorVersion7UpgradeReport.CreateReport() at Umbraco.Web.Install.InstallSteps.MajorVersion7UpgradeReport.RequiresExecution(Object model) --- End of inner exception stack trace --- at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at Umbraco.Web.Install.Controllers.InstallApiController.StepRequiresExecution(InstallSetupStep step, JToken instruction) at Umbraco.Web.Install.Controllers.InstallApiController.IterateNextRequiredStep(InstallSetupStep current, Queue`1 queue, Guid installId, InstallInstructions installModel) at Umbraco.Web.Install.Controllers.InstallApiController.PostPerformInstall(InstallInstructions installModel)This is incorrect. I upgraded to 7.6 from 7.3 without issue and then tried to upgrade to 7.14 and got the same error message.
I have restarted app pool, cleared temp folder and cache before doing each one.
I shall try and upgrade from 7.6 to each one down from 7.14 to see where this issue arises.
It appears v7.12 doesn't have this issue. Just sorting breaking coding issues from 7.6 to 7.12.
We've been stuck on 7.12 for a while now.
I was able to get past this by adding controlId to cmsDataType table. [controlId] [uniqueidentifier] NOT NULL,
It then complained about the mappings
Clearly we missed a major version where this field and whatever mappings were introduced. Since I have no idea what they are used for, or why they were introduced ( I assume because this table lacked a GUID), I attempted to map them manually to the cmsPropertyType table's UniqueID Column which appeared to work momentarily on the installer..
Then the installer told me it was finished and then kicked me back into the installer Step 1. Vicious circle.
Giving up for now, seems we all might be in trouble with this one unless a Core team member can tell us when controlID was introduced, how it's mapped, the intent of it, and then we could maybe script our way through this.
Only other solution I see is to install fresh and attempt to make a package of entire site. Not feasible for us, far too complex of a site.
Hope that helps anyone.
I have the same problem (https://our.umbraco.com/forum/using-umbraco-and-getting-started/96302-upgrading-7123-to-714-getting-error-during-installation) and others reported it in the forums too. Was hoping by now there would be a solution. Really surprised no-one from Umbraco can be bothered to fix this :(
Yeah I've spent quite a bit of time trying to get around this, had to settle with v7.12.4
I haven't been able to copy the site and database to a local dev environment (which I've seen as a solution in other threads) as the client has strict security policies, so I'm stuck with working remotely on their prod environment which is frustrating too.
Hopefully somebody at Umbraco sees this and has a look.
Not sure if this'll help anyone, but I had this exact problem, and the reason was I was trying to upgrade against a hosted SQL server DB where I didn't have full rights/permissions to the master DB, etc.
SO, what I did was:
All good.
@Chris Thwaites - Great suggestion about DB permissions. Thank you!
We've been battling several Umbraco sites (Hosted on a Windows Plesk instance), since the Member Registration security issue required CMS version updates to 7.15.1. ControlId issues with all of them.
Once I read your post I took a look, and sure enough, the Umbraco installs that were failing to upgrade were all assigned to [dbo] schema. We changed the schema on all tables to match the authorised DB account and the installs all went through.
Thanks and good work.
Hey
Just for the record - the solution with DB permissions worked for me also.
Good job!
(Unfortunately I found this post after hours of crying and nailbiting)
Adding the db user role "sysadmin" worked for me
is working on a reply...