Constructor is asking for concrete type, request the interface instead

Thanks for your reply Paul. I changed as you suggested, still same issue:

  public class HomeController : RenderMvcController
    {
        private readonly IStateRepository _stateRepository;
        public HomeController(IStateRepository stateRepository)
        {
           _stateRepository = stateRepository;
        }
    }

Hi kapil,

Can you remove this line from your autofac config :

 builder.RegisterType<HomeController>();

Your controller are normally picked up by the line after that

builder.RegisterControllers(Assembly.GetExecutingAssembly()).PropertiesAutowired();

But this requires the controller to be in the same assembly as the autofac registration

Dave

Hi, I'm having the same issue.

Unresolved dependency [Target Type: UmbracoResumeWebsite.Web.Controllers.SiteLayoutController], [Parameter: navigation(UmbracoResumeWebsite.Helpers.INavigation)], [Requested dependency: ServiceType:UmbracoResumeWebsite.Helpers.INavigation, ServiceName:]

AutofacComponent.cs

public class AutofacComponent : IComponent
{
    public void Initialize()
    {
        var builder = new ContainerBuilder();
        builder.RegisterControllers(typeof(UmbracoApplication).Assembly);

        var container = builder.Build();
        DependencyResolver.SetResolver(new AutofacDependencyResolver(container));
    }
}

ApplicationComposer.cs

public class ApplicationComposer : IUserComposer
{
    public void Compose(Composition composition)
    {
        composition.Components().Append<AutofacComponent>();
    }
}

SiteLayoutController.cs

public class SiteLayoutController : SurfaceController
{
    private INavigation _navigation;

    public SiteLayoutController(INavigation navigation)
    {
        _navigation = navigation;
    }

    public ActionResult RenderMainNavigation()
    {
        var root = Umbraco.ContentAtRoot().First();
        return PartialView("Layout/_Navigation", _navigation.GetItems(root, false));
    }
}

then presumably no concrete classes that implement INavigation are registered in the ioc container.

Hi Paul, my Navigation class got no constructor.

public class Navigation : INavigation
{
    private IPublishedContent Content = null;
    private NavigationList NavigationList = null;
    private const string CACHE_KEY_PREFIX = "umbracoNavigationItems_";
    private double CacheExpiration = 5.0;

    /// <summary>
    /// Get all navigation items
    /// </summary>
    /// <param name="publishedContent">The content object</param>
    /// <param name="getFromCache">Whether to get items from cache or not. Default is true.</param>
    public NavigationList GetItems(IPublishedContent publishedContent, bool getFromCache = true)
    {
        NavigationList = new NavigationList();

        if (getFromCache)
        {
            var cacheKey = CACHE_KEY_PREFIX + Content.Key;
            NavigationList = GetItemsFromCache(cacheKey);
        }
        else
        {
            NavigationList = GetChildItems(publishedContent);
        }

        return NavigationList;
    }

    public void SetCacheExpiration(double cacheExpiration)
    {
        CacheExpiration = cacheExpiration;
    }

    private NavigationList GetChildItems(IPublishedContent parentContent)
    {
        var childItems = new NavigationList();
        childItems.Items = new List<NavigationListItem>();

        foreach (var childContent in parentContent.Children.Where(x => x.IsVisible()))
        {
            childItems.Items.Add(new NavigationListItem
            {
                Id = childContent.Id,
                Name = childContent.Name,
                Url = childContent.Url,
                Content = childContent,
                List = childContent.Children.Any() ? GetChildItems(childContent) : new NavigationList()
            });
        }

        return childItems;
    }

    private NavigationList GetItemsFromCache(string cacheKey)
    {
        ObjectCache cache = MemoryCache.Default;
        var cachedObject = new NavigationList();

        if (cache.Contains(cacheKey))
        {
            cachedObject = (NavigationList)cache[cacheKey];
        }
        else
        {
            cachedObject = GetChildItems(Content);
            SetItemsToCache(cacheKey, cachedObject, CacheExpiration);
        }

        return cachedObject;
    }

    private void SetItemsToCache(string cacheKey, NavigationList cachedObject, double cacheExpiration)
    {
        ObjectCache cache = MemoryCache.Default;
        CacheItemPolicy policy = new CacheItemPolicy();

        policy.AbsoluteExpiration = DateTimeOffset.Now.AddMinutes(cacheExpiration);
        cache.Set(cacheKey, cachedObject, policy);
    }
}

is working on a reply...