I'm having a problems making changes to the datatype (also prevents me from creating a new one). So I click to edit one of items in the datatype. (This is one I already had that got upgraded) Click Update.
When I go back into edit, I find junk filling the Validation field. This only happened AFTER I clicked update on the field.
IF I click update after it fills the validation with the trash, I get this.
if I try to save the datatype after these changes are
made. I assume because of the junk in the validation field, it is
causing this error.
I'm lucky that I have datatypes created already. The only problems I had editing on the content page is the required fields. It seems to require field even if you don't have required checked for that item.
and here is the datatype view showing required=false on all of them.
thanks again for your testing and detailed feedback, that is absolutely awesome. And glad you like the buttons. :)
If I had to make a careful guess I'd say that something went unfortunately wrong while upgrading your existing types, so that everything is now shifted by one (or missing one entry in between), so that the validation field now contains the edit button html. If you save that then the frontend will go crazy as well as it finds this crazy regex entry '<a href="...>' which leads to all your fields not being able to validate correctly.
I've tried it out on a couple of test machines, upgrading from different previous versions, can't get the error like you have. So we have to fumble around a bit I'm afraid until we go that solved.
First of all you're saying that you can't add a new data type. Does that mean you can't add another entry to the list in your existing Embedded Content data type, or does it mean that you can't create a new Embedded Content data type? If the latter then something is seriously wrong, if the latter then I'd say something is wrong with the prevalue in the database.
Can you do me a favour and create a new Embedded Contentn data type (completely new) and see how that behaves? Does it throw up the same anomalies as you've outlined above?
If you have database access it would be cool to have a look at the prevalues that you currently have in there. If you do have access can you please run this script on your Umbraco database:
SELECT dtpv.value FROM cmsDataType dt LEFT JOIN cmsDataTypePreValues dtpv ON dt.nodeId = dtpv.datatypeNodeId WHERE dt.controlId = '454545AB-1234-4321-ABCD-1234567890AB'
and post the results here, that would be amazing. If you don't have access please let me know and I'll send you a version which does show you the prevalue string on your screen.
One last question: did you uninstall the data type before you installed the new version?
I am NOT able to create a new Embedded Content datatype. I tried creating a StaffTable2 and there seems to be something in the update/add button that is killing it.
Click the Add button and it looks all good
but when I click the "Save" for the datatype, it get this
When I run that query, the entry for the embedded content item I used in my previous screenshots shows as:
||id:1|Name: Name| Alias: staffName| Type: Textstring| Description: | Show in title? true| Required? false| Validation: ||id:2|Name: Title| Alias: staffTitle| Type: Textstring| Description: | Show in title? true| Required? false| Validation: ||id:3|Name: Description| Alias: staffDesc| Type: Textbox multiple| Description: | Show in title? false| Required? false| Validation: ||id:4|Name: Image| Alias: staffImage| Type: Media picker| Description: | Show in title? false| Required? false| Validation: ||showLabel:1;showType=1,showDescription=0,showTitle=0,showRequired=0,showValidation=0
To answer your question. I did NOT uninstall my previously created datatypes before uninstalling the previous package (ver 1.09 beta1) and installing the new one and running the extra update with it.
And I'm pretty sure those will be the conversion prevalues because I have not made a successful save to any of my datatypes (old or new) since the upgrade.
thanks again for your detailed description. Following Geoff's advice I've encoded all the XML on page, which means you should not get the 'dangerous request' error anymore. When you got the time can you please download 1.1 beta 2 and give it a shot? That would be fantastic, fingers crossed.
btw. I uninstalled the old package, installed the new one and created a completely new datatype and got these results. Still unable to save existing/new datatypes.
that was really helpful. The regex to strip out the DIVs and As was not working correctly because the browser moved the attributes around. Have modified the regexes and uploaded a new beta 3, please give that a try. :)
1.1 beta 1 Testing Results
LOVE the buttons...looks much more professional.
A few errors to tell you about.
I'm having a problems making changes to the datatype (also prevents me from creating a new one). So I click to edit one of items in the datatype. (This is one I already had that got upgraded) Click Update.
When I go back into edit, I find junk filling the Validation field. This only happened AFTER I clicked update on the field.
IF I click update after it fills the validation with the trash, I get this.
if I try to save the datatype after these changes are made. I assume because of the junk in the validation field, it is causing this error.
I'm lucky that I have datatypes created already. The only problems I had editing on the content page is the required fields. It seems to require field even if you don't have required checked for that item.
and here is the datatype view showing required=false on all of them.
I'll be around. (Been snowed in for days)
Let me know if I need to test further.
Hi Michael,
thanks again for your testing and detailed feedback, that is absolutely awesome. And glad you like the buttons. :)
If I had to make a careful guess I'd say that something went unfortunately wrong while upgrading your existing types, so that everything is now shifted by one (or missing one entry in between), so that the validation field now contains the edit button html. If you save that then the frontend will go crazy as well as it finds this crazy regex entry '<a href="...>' which leads to all your fields not being able to validate correctly.
I've tried it out on a couple of test machines, upgrading from different previous versions, can't get the error like you have. So we have to fumble around a bit I'm afraid until we go that solved.
First of all you're saying that you can't add a new data type. Does that mean you can't add another entry to the list in your existing Embedded Content data type, or does it mean that you can't create a new Embedded Content data type? If the latter then something is seriously wrong, if the latter then I'd say something is wrong with the prevalue in the database.
Can you do me a favour and create a new Embedded Contentn data type (completely new) and see how that behaves? Does it throw up the same anomalies as you've outlined above?
If you have database access it would be cool to have a look at the prevalues that you currently have in there. If you do have access can you please run this script on your Umbraco database:
SELECT dtpv.value
FROM cmsDataType dt
LEFT JOIN cmsDataTypePreValues dtpv ON dt.nodeId = dtpv.datatypeNodeId
WHERE dt.controlId = '454545AB-1234-4321-ABCD-1234567890AB'
and post the results here, that would be amazing. If you don't have access please let me know and I'll send you a version which does show you the prevalue string on your screen.
One last question: did you uninstall the data type before you installed the new version?
Cheers and thanks again for all your help,
Sascha
I am NOT able to create a new Embedded Content datatype. I tried creating a StaffTable2 and there seems to be something in the update/add button that is killing it.
Click the Add button and it looks all good
but when I click the "Save" for the datatype, it get this
When I run that query, the entry for the embedded content item I used in my previous screenshots shows as:
||id:1|Name: Name| Alias: staffName| Type: Textstring| Description: | Show in title? true| Required? false| Validation: ||id:2|Name: Title| Alias: staffTitle| Type: Textstring| Description: | Show in title? true| Required? false| Validation: ||id:3|Name: Description| Alias: staffDesc| Type: Textbox multiple| Description: | Show in title? false| Required? false| Validation: ||id:4|Name: Image| Alias: staffImage| Type: Media picker| Description: | Show in title? false| Required? false| Validation: ||showLabel:1;showType=1,showDescription=0,showTitle=0,showRequired=0,showValidation=0
To answer your question. I did NOT uninstall my previously created datatypes before uninstalling the previous package (ver 1.09 beta1) and installing the new one and running the extra update with it.
And I'm pretty sure those will be the conversion prevalues because I have not made a successful save to any of my datatypes (old or new) since the upgrade.
Hi Michael,
thanks again for your detailed description. Following Geoff's advice I've encoded all the XML on page, which means you should not get the 'dangerous request' error anymore. When you got the time can you please download 1.1 beta 2 and give it a shot? That would be fantastic, fingers crossed.
Cheers,
Sascha
I still keep getting the 'dangerous request' error because it puts this in my validation line
"<a href="#" onclick="elem = $(this).parent(); EC.EditProperty(elem); return false;" title="edit" class="edit"><div style="background-image: url("/WebResource.axd?d=rP7yYic9z47WnaRPG0pqKVGQml39q3Whps86paB8ecxrYZVOb_q0RU91Z1iuNQyj8HKFidveLu08ytZAo3UM29WBgGJWqY4WovybxX-XbrdGtNgMiUe7xo6UtTAzERYSOwIO5bhgvSkjvtOtWzzCu6FLpHNFPMik9Slufs-vMqSZ6V4X0&t=634331014305937500");" class="ECbigButton"></a><a href="#" onclick="EC.RemoveItem($(this))" title="remove" class="remove"><div style="background-image: url("/WebResource.axd?d=rP7yYic9z47WnaRPG0pqKVGQml39q3Whps86paB8ecxrYZVOb_q0RU91Z1iuNQyj8HKFidveLu08ytZAo3UM29WBgGJWqY4WovybxX-XbrdGtNgMiUe7xo6UtTAzERYSOwIO5bhgvSkjvtOtWzzCu6FLpHNFPMik9Slufs-vMqSZ6V4X0&t=634331014305937500");" class="ECbigButton"></a>"
every time I click add/update
btw. I uninstalled the old package, installed the new one and created a completely new datatype and got these results. Still unable to save existing/new datatypes.
This may help. This is after I added ^[a-z]*$ to the validation. It comes out with that plus the link. This is before I click save on the datatype.
Hi Michael,
that was really helpful. The regex to strip out the DIVs and As was not working correctly because the browser moved the attributes around. Have modified the regexes and uploaded a new beta 3, please give that a try. :)
Cheers, Sascha
That did the trick! I am now able to save datatypes without error. Even created a new datatype with no problems. Verified this in both FF3.6 and IE8
The only issue I have left is that it is requiring fields that aren't marked as required. (Last two screenshots of my original post)
High Five!
Hi Michael,
that's great news! :) Have also uploaded beta 4 with (hopefully) a fix for the required issue, give it a shot if you like.
Sascha
That did it! Woo hoo!
I'll resolve this but let me know when you put the release version out and I'll do some quick testing.
Great!! :)
Will push it live in 1-2 hours then, will let you know.
Thanks for all your work,
Sascha
Alright, v 1.1 is now officially out, give it a whirl if you like ;)
is working on a reply...