I've not seen this specific issue but will see if I can replicate it. Meanwhile if you would like to a have a go (and I would encourgae you to do so) at fixing the issue, the latest source code for v1.2.2 is available at https://bitbucket.org/reboot/embedded-content-umbraco/src and forking/pull requests can be done there.
Do you know how i go about get the source code down? Never used BitBucket before. I created a login etc and can see all of the files but can't find the zip button to download the code?
I see you have created a fork so you need to now clone your fork, there is a "help with cloning" button but you will need TortoiseHG (free) installed on your computer. Also here is a little video http://youtu.be/E1NJWrRoXek
I can send you a zip tomorrow if you don't succeed with a local clone.
I managed to get the source and spent the day trying to troubleshoot the issue without much avail. What I was able to do was identify the cause of the problem. For this particular doc type I also have the MNTP, different tab but on the same doc type. When I remove the MNTP the Embedded Content control starts to work again. This is breaking not only on IE9 but IE8 and IE7. While stepping through the JS I can see it setting up the initalisation of the EC, during this I see the Ajax calls from the MNTP after which the stepper jumps back to the EC code but by this time the EC variables are reset and hence receive the 'EC undefined' error on the window.load call. Its as if the MNTP ajax calls are getting in the way. I've tried rearranging the order of the generated JS but its not making any difference.
Because MNTP is now a part of Umbraco core I'm not sure if the problem lies with Umbraco or EC but as the MNTP is such an important part of project requirement I can't remove it and I'm not sure I know enough about either to fix it myself. Could anyone more familiar with EC or MNTP have a look into it?
I have been unable to recreate this issue in IE9 using Umbraco 4.11.5 and Embedded Content 1.2.2. Can you confirm the versions you have expereinced this issue on?
I'm using Umbraco 4.10.1 and embedded Content 1.2.2 and am happy to try anything to get this working. If i was in a position to just update my version of Umbraco to 4.11.5 I would but unfortunately cannot do it now.
Another thing that might help you replicate the issue. I my MNTP i have about 8 categories and underneath each theres approx 20 items. So altogether the MNTP has about 100 items which takes a few secs to load. I believe its the loading of these items that is the cause of the Embedded Content control breaking. If you were to add approx 100 item or more to the MNTP am confident you will be able to replicate it.
Get an error in IE9 that breaks page
First of all great control. My issue is only with IE9. This works fine in FF and Chrome.
When testing in IE i see an EC is undefined and the error points to this:
$(window).load(function () {
EC.InitializeSettings();
EC.ApplySettings();
});
In the JS file : ECPrevalueEditor.js
The result is that the add box doesn't appear but instead renders all of the fields (attached)
I tried to download the source to have a go at fixing it but the source appears to be 1.1 and not the latest version as downloadable binary package.
Would be great if someone could get this fixed as IE9 is important to me.
Cheers
Hi George,
I've not seen this specific issue but will see if I can replicate it. Meanwhile if you would like to a have a go (and I would encourgae you to do so) at fixing the issue, the latest source code for v1.2.2 is available at https://bitbucket.org/reboot/embedded-content-umbraco/src and forking/pull requests can be done there.
Cheers,
Jeavon
Hi Jeavon,
Do you know how i go about get the source code down? Never used BitBucket before. I created a login etc and can see all of the files but can't find the zip button to download the code?
Could you send me a zipped file with latest code?
Cheers
George
Hi George,
I see you have created a fork so you need to now clone your fork, there is a "help with cloning" button but you will need TortoiseHG (free) installed on your computer. Also here is a little video http://youtu.be/E1NJWrRoXek
I can send you a zip tomorrow if you don't succeed with a local clone.
Good luck
Jeavon
Thanks Jeavon,
I managed to get the source and spent the day trying to troubleshoot the issue without much avail. What I was able to do was identify the cause of the problem. For this particular doc type I also have the MNTP, different tab but on the same doc type. When I remove the MNTP the Embedded Content control starts to work again. This is breaking not only on IE9 but IE8 and IE7. While stepping through the JS I can see it setting up the initalisation of the EC, during this I see the Ajax calls from the MNTP after which the stepper jumps back to the EC code but by this time the EC variables are reset and hence receive the 'EC undefined' error on the window.load call. Its as if the MNTP ajax calls are getting in the way. I've tried rearranging the order of the generated JS but its not making any difference.
Because MNTP is now a part of Umbraco core I'm not sure if the problem lies with Umbraco or EC but as the MNTP is such an important part of project requirement I can't remove it and I'm not sure I know enough about either to fix it myself. Could anyone more familiar with EC or MNTP have a look into it?
Cheers
George
Hi George,
I have been unable to recreate this issue in IE9 using Umbraco 4.11.5 and Embedded Content 1.2.2. Can you confirm the versions you have expereinced this issue on?
Cheers,
Jeavon
Hi Jeavon,
I'm using Umbraco 4.10.1 and embedded Content 1.2.2 and am happy to try anything to get this working. If i was in a position to just update my version of Umbraco to 4.11.5 I would but unfortunately cannot do it now.
Many thanks
George
Hi Jeavon,
Another thing that might help you replicate the issue. I my MNTP i have about 8 categories and underneath each theres approx 20 items. So altogether the MNTP has about 100 items which takes a few secs to load. I believe its the loading of these items that is the cause of the Embedded Content control breaking. If you were to add approx 100 item or more to the MNTP am confident you will be able to replicate it.
Cheers
George
is working on a reply...