Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 20, 2012 @ 16:06
    Dmitriy Skudnov
    0

    Make field mandatory

    Hi.

    Is it possible to make Google Map datatype as mandatory field? Checking "Mandatory" in document type doesn't help. May be i am doing something wrong?

    Thanks in advanced.

    Dmitriy

  • Lee Kelleher 3905 posts 14863 karma points MVP 10x admin c-trib
    Jun 20, 2012 @ 16:15
    Lee Kelleher
    0

    Hi Dmitriy,

    No, it's nothing you are doing wrong, the code that checks if it's mandatory wasn't implemented.

    I'll look to add this to the next patch release, (should have time on Friday to implement it - unless you're a developer and want to patch it before then?)

    https://bitbucket.org/vertino/google-maps-for-umbraco/src

    Cheers, Lee.

  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 20, 2012 @ 17:33
    Dmitriy Skudnov
    2

    Hi Lee. 

    Thank you for your reply. I did the patch, that makes possible to make google map property mandatory. It was easy to do with ValidationProperty attribute.

    I have checked in changes.

    Best Regards, Dmitriy

  • Lee Kelleher 3905 posts 14863 karma points MVP 10x admin c-trib
    Jun 20, 2012 @ 18:46
    Lee Kelleher
    0

    Cool, sounds great. Feel free to make a Pull Request on the BitBucket repo.

    Cheers, Lee

  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 21, 2012 @ 09:28
    Dmitriy Skudnov
    0

    Hi Lee.

    I am trying to find funtionallity or button "Create Pull Request" but i can't. May be i need to have some spesial permission to repository or?

     I am new to TortoiseHg.  I can send a file to you with changes.

    Also i have some fixes to Umbraco 4.7.x. To whom i can talk to check them in into sources?

    Thanks, Dmitriy

  • Lee Kelleher 3905 posts 14863 karma points MVP 10x admin c-trib
    Jun 21, 2012 @ 10:05
    Lee Kelleher
    0

    Hi Dmitriy,

    Do you have a BitBucket account? If so, then the usual approach is to make a fork from the main repository, apply your changes, commit and push up to your fork.  From there you can make a Pull Request (via the BitBucket website) ... and I'd handle the rest.

    If you don't have a BitBucket account, then no worries, drop me an email, (via my contact form) and we'll sort out how to get a patch sent over.

    Thanks, Lee.

  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 21, 2012 @ 10:48
    Dmitriy Skudnov
    0

    Hi Lee. 

    Thank you for help! I am and my content managers are happy now :)

    Dmitriy.

  • Lee Kelleher 3905 posts 14863 karma points MVP 10x admin c-trib
    Jun 21, 2012 @ 10:59
    Lee Kelleher
    0

    Thank you Dmitriy, I got your pull request and all good! :-D #h5yr

    With Umbraco 4.x, it's a similar approach, but over on CodePlex: http://umbraco.codeplex.com/SourceControl/list/changesets?branch=4.8.0

    Make a fork, (warning the repo is large - as it currently has both v4 and v5 branches in there), then make a pull request. I can't say how long it will take for your pull request to be accepted, since v5 has been discontinued and efforts refocused on v4, we are working on future roadmaps, etc.

    Cheers, Lee.

  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 21, 2012 @ 11:13
    Dmitriy Skudnov
    0

    Thank you for guiding me. I will try do it with umbraco as well. 

    One more time thank you.

    Dmitriy

  • Lee Kelleher 3905 posts 14863 karma points MVP 10x admin c-trib
    Jun 21, 2012 @ 18:09
    Lee Kelleher
    1

    Hi Dmitriy,

    Just to let you know that I've just released Google Maps 2.0.4 - which contains your patch!

    http://our.umbraco.org/projects/backoffice-extensions/google-maps-datatype

    Thanks again, Lee.

  • Dmitriy Skudnov 39 posts 64 karma points
    Jun 22, 2012 @ 08:28
    Dmitriy Skudnov
    0

    Hi Lee.

    Thank you for notice. I already did a build, and your solution has nice MSBuild support, that producing package file. Very nice!

    Will look today on umbraco fixes.

    Thanks, Dmitriy

Please Sign in or register to post replies

Write your reply to:

Draft