Firstly, awesome package, really enjoying using it.
I've having an odd issue with content overriding. I've installed the "starter kit" and have been playing around. I've added a settings data type that allows me to configure the rotation of a content block.
What I'm then doing is rotating the original content block (which is a text block) on the Extra Large view point (this filters down to the other sizes).
I'm then going to the Large view point, going into the content block, going to settings and clicking "override" to remove the rotation at this level.
What is happening is that the css isn't hiding the default render for the Large break points. As a result I'm getting duplicate content showing, i.e. the rotated default block, and the non-rotated overridden block.
confession: I've not looked into it in detail just wondered if this is meant to be the expected behaviour as I wouldn't have thought it should be.
Umbraco 7.12.3, package installed via nuget, Positional content starter kit installed as local package.
I installed via nuget which installed version: 1.0.8
After I did the nuget install I downloaded the starter kit 1.0.0.1 from here so I could get a feel for what doc type setup should be like as that wasn't part of the nuget install. I assumed that installing the starter kit doesn't override the dll side of things?
Been looking into this a bit further and basically it looks like your function DimensionContentSetting in the PositionalContent.cshtml partial isn't checking if the settings have been overridden:
if ((d.Value.OverrideContent && d.Value.HasContent) || d.Value.Hide)
By changing it to:
if ((d.Value.OverrideContent && d.Value.HasContent) || (d.Value.OverrideSettings && d.Value.HasSettings) || d.Value.Hide)
I get the expected behaviour, but I haven't tested knock-on effects of this, just thought it might help your replication test later :-)
Overriding content blocks
Hi,
Firstly, awesome package, really enjoying using it.
I've having an odd issue with content overriding. I've installed the "starter kit" and have been playing around. I've added a settings data type that allows me to configure the rotation of a content block.
What I'm then doing is rotating the original content block (which is a text block) on the Extra Large view point (this filters down to the other sizes).
I'm then going to the Large view point, going into the content block, going to settings and clicking "override" to remove the rotation at this level.
What is happening is that the css isn't hiding the default render for the Large break points. As a result I'm getting duplicate content showing, i.e. the rotated default block, and the non-rotated overridden block.
confession: I've not looked into it in detail just wondered if this is meant to be the expected behaviour as I wouldn't have thought it should be.
Umbraco 7.12.3, package installed via nuget, Positional content starter kit installed as local package.
Hi
Thanks for taking a look!
Which version are you using? I did fix an issue with settings overriding recently so it might be fixed in the latest version.
Hi Phil,
I installed via nuget which installed version: 1.0.8
After I did the nuget install I downloaded the starter kit 1.0.0.1 from here so I could get a feel for what doc type setup should be like as that wasn't part of the nuget install. I assumed that installing the starter kit doesn't override the dll side of things?
Nik
Hi Nik
Ok, I'll take a look tonight and see if I can replicate!
No worries, if you need more info etc drop me a DM on twitter if I'm not responding quickly on here :-) @hotchillicode :-)
Hi Phil,
Been looking into this a bit further and basically it looks like your function
DimensionContentSettingin thePositionalContent.cshtmlpartial isn't checking if the settings have been overridden:By changing it to:
I get the expected behaviour, but I haven't tested knock-on effects of this, just thought it might help your replication test later :-)
Nik
Thanks Nik
I replicated this issue last night and have implemented your fix (thanks).
I've just released a new version.
Phil
is working on a reply...