Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Ronald Barendse 39 posts 218 karma points hq c-trib
    Sep 12, 2018 @ 14:32
    Ronald Barendse
    0

    Failed to Update all the links

    I'm trying out the new Jumoo.TranslationManager.LinkUpdater (2.0.1), but it seems the RJPMultiURLMapper is choking on a null value (when on a nested content property):

    Failed to Update all the links: System.NullReferenceException: Object reference not set to an instance of an object.
    at Jumoo.TranslationManager.LinkUpdater.LinkMappers.RJPMultiURLMapper.UpdateLinkValues(TranslationSet set, Int32 targetSiteId, Object sourceValue, Object targetValue)
    at Jumoo.TranslationManager.LinkUpdater.LinkMappers.NestedLinkMapper.UpdateLinkValues(TranslationSet set, Int32 targetSiteId, Object sourceValue, Object targetValue)
    at Jumoo.TranslationManager.LinkUpdater.LinkUpdater.ProcessPickedLinks(TranslationSet set, Int32 targetSiteId, IContent source, IContent target, Boolean publish)
    at Jumoo.TranslationManager.LinkUpdater.LinkUpdater.UpdateLinks(TranslationJob job, IEnumerable`1 nodes, Boolean publish)
    at Jumoo.TranslationManager.LinkUpdater.LinkUpdaterEventHandler.UpdateContentLinks(LinkUpdater updater, TranslationJob job, IEnumerable`1 nodes, Boolean publish, Boolean updatingSelf)
    

    I've checked all relations between the nodes and they're correctly set. I do have some mailto: and tel: links, maybe it can't handle those correctly?

  • Kevin Jump 2343 posts 14890 karma points MVP 8x c-trib
    Sep 12, 2018 @ 15:26
    Kevin Jump
    0

    Hi Ronald,

    Yes it does look like that is it - we will do some testing, fix it and push a new version out.

    Kevin

  • Kevin Jump 2343 posts 14890 karma points MVP 8x c-trib
    Sep 12, 2018 @ 15:54
    Kevin Jump
    0

    Hi

    there is an updated version now (v2.0.2) which has this fix in it

    https://www.nuget.org/packages/Jumoo.TranslationManager.LinkUpdater/2.0.2

    As you pointed out we weren't handling the mailto: links properly .

    Kevin

  • Ronald Barendse 39 posts 218 karma points hq c-trib
    Sep 13, 2018 @ 08:01
    Ronald Barendse
    0

    The links are now updating, thanks Kevin!

    We have a lot of small 2 language sites, so your Translation Manager package makes it really easy for us to copy, translate and now also update all linked pages!

    Because we're also using Cogworks.Meganav in almost all our sites, I've created a MeganavValueMapper and MeganavLinkMapper. The value mapper allows translating the manual 'Page title' field and the link mapper updates the id, name and URL. Inheriting from LinkMapperBase currently isn't that useful though, because GetLinkResolver() is internal, so I've had to duplicate that code...

    I'm willing to share these mappers as open-source, maybe as a 'contrib' package?

  • Kevin Jump 2343 posts 14890 karma points MVP 8x c-trib
    Sep 13, 2018 @ 08:24
    Kevin Jump
    100

    Hi Ronald,

    glad to hear its working for you :)

    yeah I have been thinking about a contrib package and it sounds like the MegaNavMappers are ideal canidates for that.

    We can also may the GetLinkResolver public, can't really think of a reason why it has to stay internal.

    I will give you a shout when we have got some contrib package repos up and running.

    Kevin

Please Sign in or register to post replies

Write your reply to:

Draft