Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Tom van Enckevort 100 posts 381 karma points
    Oct 07, 2019 @ 16:30
    Tom van Enckevort
    0

    Grid with DTGE and Vorto fields not in XLIFF export

    We're trying to set up Translation Manager (v2.4.1) on an existing site (Umbraco v7.11.1).

    We have multiple hostnames set up on the same site, so the translation set we created is a circular set with the same root node for the different languages.

    The pages that need translating have a couple of Vorto fields for things like meta data, and a grid field for the main page content that uses DTGE where each DTGE item uses Vorto fields for the translatable content within that grid element.

    When we create a translation job for any of the pages using the XLIFF provider, the exported .xliff2 file does contain the main meta Vorto fields, but none of the grid blocks are included.

    Is there something we need to configure for those grid fields to be included?

  • Kevin Jump 1532 posts 9802 karma points MVP 3x c-trib
    Oct 07, 2019 @ 21:49
    Kevin Jump
    0

    Hi Tom,

    that 'should' work. although with doctype grideditor there are so many config elements it might be missing something,.

    I've just tested it out of the "box", with a doctype grid editior with the standard views/etc, with a vorto datatype with a text string in it, and the value was extracted (and reimported) tothe xliff.

    things to check:

    1. does the translation set have the vorto element defined in the Multilanguage properties? and there isn't anything in the properties box stopping the properties been found?

    enter image description here

    if you where for example to put -gridContent in the properties box that would stop anynested vorto elements from ever being found

    Custom DocTypeGridEditor Views ?

    I think if you change the view in the grid config that might cause issues. the default:

    "view": "/App_Plugins/DocTypeGridEditor/Views/doctypegrideditor.html",
    

    How Translation Manager finds mappers in the grid is a little bit complex because unlike datatypes they don't have a set-id of any form, so the doctype grid editor is found (like a few other grid elements) by the view name, which in the default case it 'doctypegrideditor' this means we are looking for a mapper for Umbraco.Grid.doctypegrideditor

    if the view name ends in something else we won't find the mapper for the doctypegrid editor.

    at the moment there isn't a simple config for this (there should be). you could have a class that inherits DocTypeGridEditorMapper and override the editor values to match your doctype grid editors.

    e.g.

    public class MyCustomDocTypeGridEditorMapper : DocTypeGridEditorMapper, IValueMapper
    {
        public override string[] Editors => new string[]
        {
            "Umbraco.Gird.MyCustomDocTypeView",
            "Umbraco.Grid.AnotherCustomView"
        };
    }
    

    (where the bit after Umbraco.Grid. is the filename of the custom view, minus the .html)

    i think that would fix it.

  • Tom van Enckevort 100 posts 381 karma points
    Oct 09, 2019 @ 08:34
    Tom van Enckevort
    0

    Hey Kevin,

    Thanks for you suggestions.

    The settings in our translation set are exactly the same as in your screenshot, and we don't override the DTGE view either so that is the same path as well.

    But one thing that is 'different' is that the grid field for the node is included via a composition.

    I just tested it again by adding another grid field (using the exact same data type) directly to the doc type (same tab as well), added a DTGE field with some text in one of the Vorto fields (like we have in the first grid field), and then ran another translation export.

    This time the newly added grid field is included (including the Vorto field data as expected).

    Could it be somehow related to the fact that the original grid field is added via a composition that it's not included in the export?

  • Tom van Enckevort 100 posts 381 karma points
    Oct 09, 2019 @ 08:52
    Tom van Enckevort
    0

    So I did a few more tests, and I don't think it's related to the compositions at all:

    • I added a test grid field to the same composition as the original grid field, added some content and did an export: it exported the second field just fine.
    • I tried renaming the original grid field to something else and then did another export: grid fields not included.

    But then I had a look in the logs and I can see the following error:

        Jumoo.TranslationManager.Core.Services.TranslationValueService - Failed Property: [My Page] layout - System.InvalidCastException: Cannot cast Newtonsoft.Json.Linq.JArray to Newtonsoft.Json.Linq.JToken.
       at Newtonsoft.Json.Linq.Extensions.Convert[T,U](T token)
       at Newtonsoft.Json.Linq.JToken.Value[T](Object key)
       at Jumoo.TranslationManager.Core.ValueMappers.VortoValueMapper.GetSourceValue(String displayName, String propertyEditorAlias, Object value, CultureInfoView culture)
       at Jumoo.TranslationManager.Core.ValueMappers.DocTypeGridEditorMapper.GetSourceValue(String displayName, String propertyTypeAlias, Object value, CultureInfoView culture)
       at Jumoo.TranslationManager.Core.ValueMappers.GridValueMapper.GetSourceValue(String displayName, String propertyEditorAlias, Object value, CultureInfoView culture)
       at Jumoo.TranslationManager.Core.Services.TranslationValueService.GetPropertyValue(IContent item, String alias, CultureInfoView culture)
    

    So it looks like it fails to parse some of the content. Any ideas on why that might be?

  • Tom van Enckevort 100 posts 381 karma points
    Oct 09, 2019 @ 09:32
    Tom van Enckevort
    1

    So I think I narrowed down to what the issue might be:

    Some of our DTGE modules have Vorto fields that wrap a Nested Content field (to group multiple fields together inside a single Vorto group): enter image description here

    If I don't have any of these modules in my grid field the export is fine, but as soon as I add one the export fails with the previous JSON conversion error.

    I'm guessing that the VortoValueMapper isn't expecting that, hence why it fails on converting the value (which is a NC JSON array).

    Am I right in my assumptions here?

  • Kevin Jump 1532 posts 9802 karma points MVP 3x c-trib
    Oct 09, 2019 @ 09:54
    Kevin Jump
    1

    Hi Tom,

    yeah that sounds about right, i think i have seen this before with slightly different setup.

    The NC content is actually stored in different ways depending on if it's in the grid or just in another value (so a Vorto with a NestedConent in it not in the grid, would store it a bit differently).

    I will take a look because we've done something very similar before, and we then we should be able to fix the vorto mapper.

  • Kevin Jump 1532 posts 9802 karma points MVP 3x c-trib
    Oct 14, 2019 @ 13:05
    Kevin Jump
    1

    Hi,

    just released an update (v2.4.2) which fixes nested content elements inside vorto elements (inside the grid!).

    https://jumoo.co.uk/translate/releases/2.4.2/

    this should resolve the issues you are having.

    Kevin

  • Tom van Enckevort 100 posts 381 karma points
    Oct 14, 2019 @ 13:07
    Tom van Enckevort
    0

    Hi Kevin,

    That's great news!

    I won't have time to test it until later this week, but will definitely let you know how we get on.

  • Tom van Enckevort 100 posts 381 karma points
    Oct 16, 2019 @ 09:48
    Tom van Enckevort
    0

    Hey Kevin,

    I've just tested it with the updated version, and all the content from the grid is now in the export.

    We'll now go and send this to the translators and then test the import as well with the translated text, so will let you know if that is working as well.

    Thanks for providing the updated version so quickly 👍

Please Sign in or register to post replies

Write your reply to:

Draft