Sign in Register
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Tom 713 posts 954 karma points
    Jan 03, 2014 @ 03:21
    Tom
    0

    v7 RC Missing Elements

    Hi Marc,

    Thanks for writing such a detailed blog post on the control and porting to v7 really love it.

     

    I'm looking at the controller and found a bug where if the excludeList is null it'll blow up on line 51.

     

    Also if I try and use it with font awesome 4.0.3 and update the regex to be \.icon-(.*?):before it will only ever find the first item.

     

    Cheers,

    Tom

    Copy Link
  • Marc Goodson 2157 posts 14431 karma points MVP 9x c-trib
    Jan 04, 2014 @ 03:56
    Marc Goodson
    0

    Hi Tom,

    With font-awesome 4.03 the classname pattern has changed for rendering icons; it is <i class="fa fa-iconname"> instead of <i class="icon icon-iconname"> so the regex needs to be

    \.fa-(.*?):before

     thanks for the bug fix on github, I just cherry picked that commit rather than the whole pull request, this is because I don't want the base functionality of uCssClassNameDropdown to be entirely based upon font-awesome icon set. You should be able to use it in other circumstances ie other icon sets, or for selecting style options from a stylesheet ie 'btn-warning' etc or background images.

    If you have a look in the git repo, there is the work in progress for uCssClassNamePicker, which will work more like the version 4/6 usercontrol wrappers for font-awesome, in that you can see the icons and can click to select them; its pretty much there; just need to scroll to picked icon on first load.

    cheers

    marc

     


    Copy Link
Please Sign in or register to post replies

Write your reply to:

Draft